Qeti / POData

services/NorthWind/NorthWindDSExpressionProvider.php

Doc Comments -1 removed lines

@@ -50,7 +50,6 @@
     /**
      * Constructs new instance of SQLSrverExpressionProvider for NorthWind DB
      * 
-     * @param string $iterName The name of the iterator
      */
     public function __construct()
     {

Spacing +16 added lines, -16 removed lines

@@ -88,7 +88,7 @@ 
      */
     public function onLogicalExpression($expressionType, $left, $right)
     {
-        switch($expressionType) {
+        switch ($expressionType) {
         case ExpressionType::AND_LOGICAL:
             return $this->_prepareBinaryExpression(self::LOGICAL_AND, $left, $right);
             break;
@@ -111,7 +111,7 @@ 
      */
     public function onArithmeticExpression($expressionType, $left, $right)
     {
-        switch($expressionType) {
+        switch ($expressionType) {
         case ExpressionType::MULTIPLY:
             return $this->_prepareBinaryExpression(self::MULTIPLY, $left, $right);
             break;
@@ -143,7 +143,7 @@ 
      */
     public function onRelationalExpression($expressionType, $left, $right)
     {
-        switch($expressionType) {
+        switch ($expressionType) {
         case ExpressionType::GREATERTHAN:
             return $this->_prepareBinaryExpression(self::GREATERTHAN, $left, $right);
             break;
@@ -181,7 +181,7 @@ 
      */
     public function onUnaryExpression($expressionType, $child)
     {
-        switch($expressionType) {
+        switch ($expressionType) {
         case ExpressionType::NEGATE:
             return $this->_prepareUnaryExpression(self::NEGATE, $child);
             break;
@@ -297,7 +297,7 @@ 
      */
     public function onFunctionCallExpression($functionDescription, $params)
     {
-        switch($functionDescription->functionName) {
+        switch ($functionDescription->functionName) {
         case ODataConstants::STRFUN_COMPARE:
             return "STRCMP($params[0]; $params[1])";
             break;
@@ -423,12 +423,12 @@ 
                     $operator = "!".$operator;
               }
               return self::OPEN_BRAKET 
-                    . $str[0] . ' ' . $operator 
-                    . ' ' . $str[1] . self::CLOSE_BRACKET;
+                    . $str[0].' '.$operator 
+                    . ' '.$str[1].self::CLOSE_BRACKET;
             } else {
                 return self::OPEN_BRAKET 
-                    . $str[0] . ' ' . $operator 
-                    . ' ' . $str[1] . self::CLOSE_BRACKET;
+                    . $str[0].' '.$operator 
+                    . ' '.$str[1].self::CLOSE_BRACKET;
             }
         }
         
@@ -447,19 +447,19 @@ 
               $operator = "!".$operator;
             }
             return self::OPEN_BRAKET
-            . $str[0] . ' ' . $operator
-            . ' ' . $str[1] . self::CLOSE_BRACKET;
+            . $str[0].' '.$operator
+            . ' '.$str[1].self::CLOSE_BRACKET;
           } else {
             return self::OPEN_BRAKET
-            . $str[0] . ' ' . $operator
-            . ' ' . $str[1] . self::CLOSE_BRACKET;
+            . $str[0].' '.$operator
+            . ' '.$str[1].self::CLOSE_BRACKET;
           }
         }
 
         return 
             self::OPEN_BRAKET 
-            . $left . ' ' . $operator 
-            . ' ' . $right . self::CLOSE_BRACKET;
+            . $left.' '.$operator 
+            . ' '.$right.self::CLOSE_BRACKET;
     }
 
     /**
@@ -472,6 +472,6 @@ 
      */
     private function _prepareUnaryExpression($operator, $child)
     {
-        return $operator . self::OPEN_BRAKET . $child . self::CLOSE_BRACKET;
+        return $operator.self::OPEN_BRAKET.$child.self::CLOSE_BRACKET;
     }
 }

services/NorthWind/NorthWindMetadata.php

Doc Comments +1 added lines, -1 removed lines

@@ -172,7 +172,7 @@
      * 
      * @throws InvalidOperationException
      * 
-     * @return NorthWindMetadata
+     * @return SimpleMetadataProvider
      */
     public static function create()
     {

services/NorthWind/NorthWindQueryProvider.php

Doc Comments +6 added lines, -5 removed lines

@@ -418,7 +418,7 @@ 
      * 
      * @param array $record each row of customer
      * 
-     * @return object
+     * @return Customer
      */
     private function _serializeCustomer($record)
     {
@@ -461,7 +461,8 @@ 
      * 
      * @param Object &$src    source
      * @param Object &$target target
-     * @param Object $tag     tag
+     * @param integer $tag     tag
+     * @param Address $target
      * 
      * @return void
      */
@@ -503,7 +504,7 @@ 
      * 
      * @param array $record each row of customer
      * 
-     * @return object
+     * @return Order
      */
     private function _serializeOrder($record)
     {
@@ -547,7 +548,7 @@ 
      * 
      * @param array $record each row of employee
      * 
-     * @return object
+     * @return Employee
      */
     private function _serializeEmployee($record)
     {
@@ -595,7 +596,7 @@ 
      * 
      * @param array $record each row of order detail
      * 
-     * @return object
+     * @return Order_Details
      */
     private function _serializeOrderDetail($record)
     {

Spacing +44 added lines, -44 removed lines

@@ -47,7 +47,7 @@ 
     	}
 
         $this->_connectionHandle = sqlsrv_connect(SERVER, $connectionInfo);
-        if ( $this->_connectionHandle ) {        	
+        if ($this->_connectionHandle) {        	
         } else {
             $errorAsString = self::_getSQLSRVError();
         	throw ODataException::createInternalServerError($errorAsString);
@@ -92,15 +92,15 @@ 
      * @return array(Object)
      */
     public function getResourceSet(ResourceSet $resourceSet, $filterOption = null, 
-        $select=null, $orderby=null, $top=null, $skip=null
+        $select = null, $orderby = null, $top = null, $skip = null
     ) {
-        $resourceSetName =  $resourceSet->getName();
+        $resourceSetName = $resourceSet->getName();
         if ($resourceSetName !== 'Customers' 
             && $resourceSetName !== 'Orders' 
             && $resourceSetName !== 'Order_Details'
             && $resourceSetName !== 'Employees'
         ) {
-        	throw ODataException::createInternalServerError('(NorthWindQueryProvider) Unknown resource set ' . $resourceSetName . '! Contact service provider');
+        	throw ODataException::createInternalServerError('(NorthWindQueryProvider) Unknown resource set '.$resourceSetName.'! Contact service provider');
         }
 
         if ($resourceSetName === 'Order_Details') {
@@ -109,7 +109,7 @@ 
 
         $query = "SELECT * FROM [$resourceSetName]";
         if ($filterOption != null) {
-            $query .= ' WHERE ' . $filterOption;
+            $query .= ' WHERE '.$filterOption;
         }
         $stmt = sqlsrv_query($this->_connectionHandle, $query);
         if ($stmt === false) {
@@ -146,14 +146,14 @@ 
      */
     public function getResourceFromResourceSet(ResourceSet $resourceSet, KeyDescriptor $keyDescriptor)
     {   
-        $resourceSetName =  $resourceSet->getName();
+        $resourceSetName = $resourceSet->getName();
         if ($resourceSetName !== 'Customers' 
             && $resourceSetName !== 'Orders' 
             && $resourceSetName !== 'Order_Details' 
             && $resourceSetName !== 'Products' 
             && $resourceSetName !== 'Employees'
         ) {
-            die('(NorthWindQueryProvider) Unknown resource set ' . $resourceSetName);    
+            die('(NorthWindQueryProvider) Unknown resource set '.$resourceSetName);    
         }
 
         if ($resourceSetName === 'Order_Details') {
@@ -163,7 +163,7 @@ 
         $namedKeyValues = $keyDescriptor->getValidatedNamedValues();
         $condition = null;
         foreach ($namedKeyValues as $key => $value) {
-            $condition .= $key . ' = ' . $value[0] . ' and ';
+            $condition .= $key.' = '.$value[0].' and ';
         }
 
         $len = strlen($condition);
@@ -181,7 +181,7 @@ 
         }
 
         $result = null;
-        while ( $record = sqlsrv_fetch_array($stmt, SQLSRV_FETCH_ASSOC)) {
+        while ($record = sqlsrv_fetch_array($stmt, SQLSRV_FETCH_ASSOC)) {
             switch ($resourceSetName) {
             case 'Customers':
                 $result = $this->_serializeCustomer($record);
@@ -227,7 +227,7 @@ 
         $navigationPropName = $targetProperty->getName();
         $key = null;
         foreach ($keyDescriptor->getValidatedNamedValues() as $keyName => $valueDescription) {
-            $key = $key . $keyName . '=' . $valueDescription[0] . ' and ';
+            $key = $key.$keyName.'='.$valueDescription[0].' and ';
         }
 
         $key = rtrim($key, ' and ');
@@ -242,7 +242,7 @@ 
 
                 $result = $this->_serializeOrders($stmt);
             } else {
-                die('Customer does not have navigation porperty with name: ' . $navigationPropName);
+                die('Customer does not have navigation porperty with name: '.$navigationPropName);
             }            
         } else if ($srcClass === 'Order') {
             if ($navigationPropName === 'Order_Details') {
@@ -255,7 +255,7 @@ 
 
                 $result = $this->_serializeOrderDetails($stmt);
             } else {
-                die('Order does not have navigation porperty with name: ' . $navigationPropName);
+                die('Order does not have navigation porperty with name: '.$navigationPropName);
             }
         } 
 
@@ -287,7 +287,7 @@ 
         ResourceSet $targetResourceSet,
         ResourceProperty $targetProperty, 
         $filterOption = null,
-        $select=null, $orderby=null, $top=null, $skip=null
+        $select = null, $orderby = null, $top = null, $skip = null
     ) {    
         $result = array();
         $srcClass = get_class($sourceEntityInstance);
@@ -296,7 +296,7 @@ 
             if ($navigationPropName === 'Orders') {                
                 $query = "SELECT * FROM Orders WHERE CustomerID = '$sourceEntityInstance->CustomerID'";
                 if ($filterOption != null) {
-                    $query .= ' AND ' . $filterOption;
+                    $query .= ' AND '.$filterOption;
                 }
                 $stmt = sqlsrv_query($this->_connectionHandle, $query);
                 if ($stmt === false) {
@@ -306,13 +306,13 @@ 
 
                 $result = $this->_serializeOrders($stmt);
             } else {
-                die('Customer does not have navigation porperty with name: ' . $navigationPropName);
+                die('Customer does not have navigation porperty with name: '.$navigationPropName);
             }            
         } else if ($srcClass === 'Order') {
             if ($navigationPropName === 'Order_Details') {
                 $query = "SELECT * FROM [Order Details] WHERE OrderID = $sourceEntityInstance->OrderID";
                 if ($filterOption != null) {
-                    $query .= ' AND ' . $filterOption;
+                    $query .= ' AND '.$filterOption;
                 }
                 $stmt = sqlsrv_query($this->_connectionHandle, $query);
                 if ($stmt === false) {            
@@ -322,7 +322,7 @@ 
 
                 $result = $this->_serializeOrderDetails($stmt);
             } else {
-                die('Order does not have navigation porperty with name: ' . $navigationPropName);
+                die('Order does not have navigation porperty with name: '.$navigationPropName);
             }
         }
 
@@ -362,13 +362,13 @@ 
                     }
 
                     if (!sqlsrv_has_rows($stmt)) {
-                        $result =  null;
+                        $result = null;
                     }
 
                     $result = $this->_serializeCustomer(sqlsrv_fetch_array($stmt, SQLSRV_FETCH_ASSOC));
                 }
             } else {
-                die('Customer does not have navigation porperty with name: ' . $navigationPropName);
+                die('Customer does not have navigation porperty with name: '.$navigationPropName);
             }            
         } else if ($srcClass === 'Order_Details') {
             if ($navigationPropName === 'Order') {
@@ -383,13 +383,13 @@ 
                     }
                     
                     if (!sqlsrv_has_rows($stmt)) {
-                        $result =  null;
+                        $result = null;
                     }
                     
                     $result = $this->_serializeOrder(sqlsrv_fetch_array($stmt, SQLSRV_FETCH_ASSOC));
                 }
             } else {
-                die('Order_Details does not have navigation porperty with name: ' . $navigationPropName);
+                die('Order_Details does not have navigation porperty with name: '.$navigationPropName);
             }
         } 
 
@@ -437,14 +437,14 @@ 
         $customer->Address->Country = $record['Country'];
         //Set alternate address
         $customer->Address->AltAddress = new Address();
-        $customer->Address->AltAddress->StreetName = 'ALT_' . $customer->Address->StreetName;
-        $customer->Address->AltAddress->City = 'ALT_' . $customer->Address->City;
-        $customer->Address->AltAddress->Region = 'ALT_' . $customer->Address->Region;
-        $customer->Address->AltAddress->PostalCode = 'ALT_' . $customer->Address->PostalCode;
-        $customer->Address->AltAddress->Country = 'ALT_' . $customer->Address->Country;
+        $customer->Address->AltAddress->StreetName = 'ALT_'.$customer->Address->StreetName;
+        $customer->Address->AltAddress->City = 'ALT_'.$customer->Address->City;
+        $customer->Address->AltAddress->Region = 'ALT_'.$customer->Address->Region;
+        $customer->Address->AltAddress->PostalCode = 'ALT_'.$customer->Address->PostalCode;
+        $customer->Address->AltAddress->Country = 'ALT_'.$customer->Address->Country;
         $customer->EmailAddresses = array();
         for ($i = 1; $i < 4; $i++) {
-            $customer->EmailAddresses[] = $customer->CustomerID . $i . '@live.com'; 
+            $customer->EmailAddresses[] = $customer->CustomerID.$i.'@live.com'; 
         }
 
         $customer->OtherAddresses = array();
@@ -467,18 +467,18 @@ 
      */
     private function _copyAddress(&$src, &$target, $tag)
     {
-        $target->StreetName = $src->StreetName . $tag;
-        $target->City = $src->City . $tag;
-        $target->Region = $src->Region . $tag;
-        $target->PostalCode = $src->PostalCode . $tag;
-        $target->Country = $src->Country . $tag;
+        $target->StreetName = $src->StreetName.$tag;
+        $target->City = $src->City.$tag;
+        $target->Region = $src->Region.$tag;
+        $target->PostalCode = $src->PostalCode.$tag;
+        $target->Country = $src->Country.$tag;
         
         $target->AltAddress = new Address();
-        $target->AltAddress->StreetName = $target->AltAddress->StreetName . $tag;
-        $target->AltAddress->City = $target->AltAddress->City . $tag;
-        $target->AltAddress->Region = $target->AltAddress->Region . $tag;
-        $target->AltAddress->PostalCode = $target->AltAddress->PostalCode . $tag;
-        $target->AltAddress->Country = $target->AltAddress->Country . $tag;
+        $target->AltAddress->StreetName = $target->AltAddress->StreetName.$tag;
+        $target->AltAddress->City = $target->AltAddress->City.$tag;
+        $target->AltAddress->Region = $target->AltAddress->Region.$tag;
+        $target->AltAddress->PostalCode = $target->AltAddress->PostalCode.$tag;
+        $target->AltAddress->Country = $target->AltAddress->Country.$tag;
     }
 
     /**
@@ -491,7 +491,7 @@ 
     private function _serializeOrders($result)
     {
         $orders = array();
-        while ( $record = sqlsrv_fetch_array($result, SQLSRV_FETCH_ASSOC)) {
+        while ($record = sqlsrv_fetch_array($result, SQLSRV_FETCH_ASSOC)) {
              $orders[] = $this->_serializeOrder($record);
         }
 
@@ -511,9 +511,9 @@ 
         $order->OrderID = $record['OrderID'];
         $order->CustomerID = $record['CustomerID'];
         $order->EmployeeID = $record['EmployeeID'];
-        $order->OrderDate = !is_null($record['OrderDate']) ? $record['OrderDate']->format('Y-m-d\TH:i:s'): null;
-        $order->RequiredDate = !is_null($record['RequiredDate']) ? $record['RequiredDate']->format('Y-m-d\TH:i:s'): null;
-        $order->ShippedDate = !is_null($record['ShippedDate']) ? $record['ShippedDate']->format('Y-m-d\TH:i:s'): null;
+        $order->OrderDate = !is_null($record['OrderDate']) ? $record['OrderDate']->format('Y-m-d\TH:i:s') : null;
+        $order->RequiredDate = !is_null($record['RequiredDate']) ? $record['RequiredDate']->format('Y-m-d\TH:i:s') : null;
+        $order->ShippedDate = !is_null($record['ShippedDate']) ? $record['ShippedDate']->format('Y-m-d\TH:i:s') : null;
         $order->ShipVia = $record['ShipVia'];
         $order->Freight = $record['Freight'];
         $order->ShipName = $record['ShipName'];
@@ -557,8 +557,8 @@ 
         $employee->LastName = $record['LastName'];
         $employee->Title = $record['Title'];
         $employee->TitleOfCourtesy = $record['TitleOfCourtesy'];
-        $employee->BirthDate = !is_null($record['BirthDate']) ? $record['BirthDate']->format('Y-m-d\TH:i:s'): null;
-        $employee->HireDate = !is_null($record['HireDate']) ? $record['HireDate']->format('Y-m-d\TH:i:s'): null;        
+        $employee->BirthDate = !is_null($record['BirthDate']) ? $record['BirthDate']->format('Y-m-d\TH:i:s') : null;
+        $employee->HireDate = !is_null($record['HireDate']) ? $record['HireDate']->format('Y-m-d\TH:i:s') : null;        
         $employee->Address = $record['Address'];
         $employee->City = $record['City'];
         $employee->Region = $record['Region'];
@@ -569,7 +569,7 @@ 
         $employee->Notes = $record['Notes'];
         $employee->ReportsTo = $record['ReportsTo'];
         //$employee->Photo = $record['Photo'];
-        $employee->Emails = array ($employee->FirstName . '@hotmail.com', $employee->FirstName . '@live.com');
+        $employee->Emails = array($employee->FirstName.'@hotmail.com', $employee->FirstName.'@live.com');
         return $employee;
     }
 

services/NorthWind/NorthWindStreamProvider.php

Doc Comments +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
      * @param WebOperationContext $operationContext     A reference to the context
      *                                                  for the current operation.
      *
-     * @return mixed A valid  default stream which is associated with the entity, 
+     * @return string A valid  default stream which is associated with the entity, 
      * Null should never be returned from this method.
      *
      * @throws ODataException if a valid stream cannot be returned.  
@@ -212,7 +212,7 @@ 
      *                                                  conditional request.
      * @param WebOperationContext $operationContext     A reference to the context for the current operation.
      *
-     * @return mixed A valid stream the data service use to query/read a named stream which is
+     * @return string A valid stream the data service use to query/read a named stream which is
      * associated with the $entity. Null may be returned from this method if the requested named
      * stream has not been created since the creation of $entity. The data service will respond 
      * with 204 if this method returns null.

Spacing +3 added lines, -3 removed lines

@@ -76,7 +76,7 @@ 
         }
 
         $filePath = self::IMAGE_PATH_ROOT 
-            . 'Employee_' . $entity->EmployeeID 
+            . 'Employee_'.$entity->EmployeeID 
             . '.jpg';
         if (file_exists($filePath)) {
             $handle = fopen($filePath, 'r');
@@ -152,7 +152,7 @@ 
         }
 
         $lastModifiedTime = null;
-        $filePath = self::IMAGE_PATH_ROOT . 'Employee_' . $entity->EmployeeID . '.jpg';
+        $filePath = self::IMAGE_PATH_ROOT.'Employee_'.$entity->EmployeeID.'.jpg';
         if (file_exists($filePath)) {
             $lastModifiedTime = date("\"m-d-Y H:i:s\"", filemtime($filePath));
         } else {
@@ -236,7 +236,7 @@ 
             throw new ODataException('Internal Server Error.', 500);
         }
         
-        $filePath = self::IMAGE_PATH_ROOT . 'Employee_' 
+        $filePath = self::IMAGE_PATH_ROOT.'Employee_' 
             . $entity->EmployeeID 
             . '_' 
             . $resourceStreamInfo->getName() 

services/WordPress/WordPressQueryProvider.php

Doc Comments +10 added lines, -12 removed lines

@@ -76,7 +76,6 @@ 
      * 
      * @param ResourceSet      $resourceSet   The entity set whose 
      *                                        entities needs to be fetched
-     * @param string           $filterOption  Contains the filter condition
      * @param string           $select        For future purpose,no need to pass it
      * @param string           $orderby       For future purpose,no need to pass it
      * @param string           $top           For future purpose,no need to pass it
@@ -273,7 +272,6 @@ 
      *                                               the navigation property
      * @param ResourceProperty $targetProperty       The navigation property to be 
      *                                               retrieved
-     * @param string           $filterOption         Contains the filter condition
      * @param string           $select               For future purpose,no need to pass it
      * @param string           $orderby              For future purpose,no need to pass it
      * @param string           $top                  For future purpose,no need to pass it
@@ -662,7 +660,7 @@ 
     /**
      * Serialize the mysql result array into Post objects
      * 
-     * @param array(array) $result result of the mysql query
+     * @param resource $result result of the mysql query
      * 
      * @return array(Object)
      */
@@ -681,7 +679,7 @@ 
      * 
      * @param array $record each post row
      * 
-     * @return object
+     * @return Post
      */
     private function _serializePost($record)
     {
@@ -741,7 +739,7 @@ 
     /**
      * Serialize the mysql result array into Tag objects
      * 
-     * @param array(array) $result result of the mysql query
+     * @param resource $result result of the mysql query
      * 
      * @return array(Object)
      */
@@ -760,7 +758,7 @@ 
      * 
      * @param array $record each tag row
      * 
-     * @return object
+     * @return Tag
      */
     private function _serializeTag($record)
     {
@@ -775,7 +773,7 @@ 
     /**
      * Serialize the mysql result array into Category objects
      * 
-     * @param array(array) $result result of the mysql query
+     * @param resource $result result of the mysql query
      * 
      * @return array(Object)
      */
@@ -794,7 +792,7 @@ 
      * 
      * @param array $record each category row
      * 
-     * @return object
+     * @return Category
      */
     private function _serializeCategory($record)
     {
@@ -809,7 +807,7 @@ 
     /**
      * Serialize the mysql result array into Comment objects
      * 
-     * @param array(array) $result mysql query result
+     * @param resource $result mysql query result
      * 
      * @return array(Object)
      */
@@ -828,7 +826,7 @@ 
      * 
      * @param array $record each comment row
      * 
-     * @return object
+     * @return Comment
      */
     private function _serializeComment($record)
     {
@@ -867,7 +865,7 @@ 
     /**
      * Serialize the mysql result array into User objects
      * 
-     * @param array(array) $result result of the mysql query
+     * @param resource $result result of the mysql query
      * 
      * @return array(Object)
      */
@@ -886,7 +884,7 @@ 
      * 
      * @param array $record each user row
      * 
-     * @return object
+     * @return User
      */
     private function _serializeUser($record)
     {

Spacing +33 added lines, -33 removed lines

@@ -41,7 +41,7 @@ 
     public function __construct()
     {
         $this->_connectionHandle = @mysql_connect(DB_HOST, DB_USER, DB_PASSWORD, true);
-        if ( $this->_connectionHandle ) {
+        if ($this->_connectionHandle) {
         } else {             
              die(print_r(mysql_error(), true));
         } 
@@ -84,16 +84,16 @@ 
      * 
      * @return array(Object)
      */
-    public function getResourceSet(ResourceSet $resourceSet,$filter=null,$select=null,$orderby=null,$top=null,$skip=null)
+    public function getResourceSet(ResourceSet $resourceSet, $filter = null, $select = null, $orderby = null, $top = null, $skip = null)
     {   
-        $resourceSetName =  $resourceSet->getName();
+        $resourceSetName = $resourceSet->getName();
         if ($resourceSetName !== 'Posts' 
             && $resourceSetName !== 'Tags' 
             && $resourceSetName !== 'Categories' 
             && $resourceSetName !== 'Comments' 
             && $resourceSetName !== 'Users'
         ) {
-            die('(WordPressQueryProvider) Unknown resource set ' . $resourceSetName);
+            die('(WordPressQueryProvider) Unknown resource set '.$resourceSetName);
         }
 
        
@@ -167,14 +167,14 @@ 
      */
     public function getResourceFromResourceSet(ResourceSet $resourceSet, KeyDescriptor $keyDescriptor)
     {
-        $resourceSetName =  $resourceSet->getName();
+        $resourceSetName = $resourceSet->getName();
         if ($resourceSetName !== 'Posts' 
             && $resourceSetName !== 'Tags' 
             && $resourceSetName !== 'Categories' 
             && $resourceSetName !== 'Comments' 
             && $resourceSetName !== 'Users'
         ) {
-            die('(WordPressQueryProvider) Unknown resource set ' . $resourceSetName);
+            die('(WordPressQueryProvider) Unknown resource set '.$resourceSetName);
         }
 
         $namedKeyValues = $keyDescriptor->getValidatedNamedValues();
@@ -286,7 +286,7 @@ 
         $sourceEntityInstance, 
         ResourceSet $targetResourceSet,
         ResourceProperty $targetProperty,
-        $filter=null ,$select=null, $orderby=null, $top=null, $skip=null
+        $filter = null, $select = null, $orderby = null, $top = null, $skip = null
     ) {
         $result = array();
         $srcClass = get_class($sourceEntityInstance);
@@ -307,7 +307,7 @@ 
                     $query .= " AND $filter";
                 }
                 $stmt = mysql_query($query);
-                if ( $stmt === false) {
+                if ($stmt === false) {
                     die(mysql_error());
                 }
                         
@@ -325,7 +325,7 @@ 
                     $query .= " AND $filter";
                 }
                 $stmt = mysql_query($query);
-                if ( $stmt === false) {            
+                if ($stmt === false) {            
                        die(mysql_error());
                 }
                         
@@ -338,13 +338,13 @@ 
                     $query .= " AND $filter";
                 }
                 $stmt = mysql_query($query);
-                if ( $stmt === false) {
+                if ($stmt === false) {
                     die(mysql_error());
                 }
                         
                 $result = $this->_serializeComments($stmt);
             } else {
-                die('Post does not have navigation porperty with name: ' . $navigationPropName);
+                die('Post does not have navigation porperty with name: '.$navigationPropName);
             }
             break;
 
@@ -363,13 +363,13 @@ 
                     $query .= " AND $filter";
                 }
                 $stmt = mysql_query($query);
-                if ( $stmt === false) {
+                if ($stmt === false) {
                             die(mysql_error());
                 }
                         
                       $result = $this->_serializePosts($stmt);
             } else {
-                die('Tag does not have navigation porperty with name: ' . $navigationPropName);
+                die('Tag does not have navigation porperty with name: '.$navigationPropName);
             }
             break;
                     
@@ -388,18 +388,18 @@ 
                     $query .= " AND $filter";
                 }
                 $stmt = mysql_query($query);
-                if ( $stmt === false) {
+                if ($stmt === false) {
                     die(mysql_error());
                 }
                         
                 $result = $this->_serializePosts($stmt);
             } else {
-                die('Category does not have navigation porperty with name: ' . $navigationPropName);
+                die('Category does not have navigation porperty with name: '.$navigationPropName);
             }
             break;
                  
         case ($srcClass == 'Comment'):
-            die('Comment does not have navigation porperty with name: ' . $navigationPropName);
+            die('Comment does not have navigation porperty with name: '.$navigationPropName);
             break;
                     
         case ($srcClass == 'User'):
@@ -412,7 +412,7 @@ 
                     $query .= " AND $filter";
                 }
                 $stmt = mysql_query($query);
-                if ( $stmt === false) {
+                if ($stmt === false) {
                     die(mysql_error());
                 }
                             
@@ -425,13 +425,13 @@ 
                     $query .= " AND $filter";
                 }
                 $stmt = mysql_query($query);
-                if ( $stmt === false) {            
+                if ($stmt === false) {            
                     die(mysql_error());
                 }
                         
                 $result = $this->_serializeComments($stmt);
             } else {
-                die('User does not have navigation porperty with name: ' . $navigationPropName);
+                die('User does not have navigation porperty with name: '.$navigationPropName);
             }
             break;
         }
@@ -506,7 +506,7 @@ 
                 $stmt = mysql_query($query);
                 $result = $this->_serializeComments($stmt);
             } else {
-                die('Post does not have navigation porperty with name: ' . $navigationPropName);
+                die('Post does not have navigation porperty with name: '.$navigationPropName);
             }
             break;
 
@@ -525,7 +525,7 @@ 
                 $stmt = mysql_query($query);
                 $result = $this->_serializePosts($stmt);
             } else {
-                die('Tag does not have navigation porperty with name: ' . $navigationPropName);
+                die('Tag does not have navigation porperty with name: '.$navigationPropName);
             }
             break;
                     
@@ -544,12 +544,12 @@ 
                 $stmt = mysql_query($query);
                 $result = $this->_serializePosts($stmt);
             } else {
-                die('Category does not have navigation porperty with name: ' . $navigationPropName);
+                die('Category does not have navigation porperty with name: '.$navigationPropName);
             }
             break;
                  
         case ($srcClass == 'Comment'):
-            die('Comment does not have navigation porperty with name: ' . $navigationPropName);
+            die('Comment does not have navigation porperty with name: '.$navigationPropName);
             break;
                     
         case ($srcClass == 'User'):
@@ -569,7 +569,7 @@ 
                  $stmt = mysql_query($query);
                  $result = $this->_serializeComments($stmt);
             } else {
-                 die('User does not have navigation porperty with name: ' . $navigationPropName);
+                 die('User does not have navigation porperty with name: '.$navigationPropName);
             }
             break;
         }
@@ -606,15 +606,15 @@ 
                 $stmt = mysql_query($query);
                 $data = mysql_fetch_assoc($stmt);
                 $result = $this->_serializeUser($data);
-                if ( $stmt === false) {            
+                if ($stmt === false) {            
                     die(mysql_error());
                 }
                         
                 if (!mysql_num_rows($stmt)) {
-                    $result =  null;
+                    $result = null;
                 }
             } else {
-                die('Post does not have navigation porperty with name: ' . $navigationPropName);
+                die('Post does not have navigation porperty with name: '.$navigationPropName);
             }
             break;
 
@@ -622,12 +622,12 @@ 
             if ($navigationPropName == 'User') {
                 $query = "SELECT * FROM `wp_users` WHERE ID = $sourceEntityInstance->UserID";
                 $stmt = mysql_query($query);
-                if ( $stmt === false) {
+                if ($stmt === false) {
                     die(mysql_error());
                 }
                         
                 if (!mysql_num_rows($stmt)) {
-                    $result =  null;
+                    $result = null;
                 }
                         
                 $data = mysql_fetch_assoc($stmt);
@@ -639,18 +639,18 @@ 
                        ." AND wp_posts.post_status = 'publish'"
                        ." AND wp_posts.ID = $sourceEntityInstance->PostID";
                 $stmt = mysql_query($query);
-                if ( $stmt === false) {            
+                if ($stmt === false) {            
                     die(mysql_error());
                 }
                         
                 if (!mysql_num_rows($stmt)) {
-                    $result =  null;
+                    $result = null;
                 }
                         
                 $data = mysql_fetch_assoc($stmt);
                 $result = $this->_serializePost($data);
             } else {
-                die('Comment does not have navigation porperty with name: ' . $navigationPropName);
+                die('Comment does not have navigation porperty with name: '.$navigationPropName);
             }
             break;
         }
@@ -816,7 +816,7 @@ 
     private function _serializeComments($result)
     {
         $comments = array();
-        while ( $record = mysql_fetch_array($result, MYSQL_ASSOC)) {         
+        while ($record = mysql_fetch_array($result, MYSQL_ASSOC)) {         
              $comments[] = $this->_serializeComment($record);
         }
 

src/POData/BaseService.php

Doc Comments +1 added lines

@@ -665,6 +665,7 @@
      * @param boolean      &$needToSerializeResponse On return, this will contain 
      *                                               True if response needs to be
      *                                               serialized, False otherwise.
+     * @param boolean $needToSerializeResponse
      *                                              
      * @return string|null The ETag for the entry object if it has eTag properties 
      *                     NULL otherwise.

Spacing +16 added lines, -16 removed lines

@@ -316,11 +316,11 @@ 
 		$registry->register(new JsonODataV1Writer());
 		$registry->register(new AtomODataWriter($serviceURI));
 
-		if($serviceVersion->compare(Version::v2()) > -1){
+		if ($serviceVersion->compare(Version::v2()) > -1) {
 			$registry->register(new JsonODataV2Writer());
 		}
 
-		if($serviceVersion->compare(Version::v3()) > -1){
+		if ($serviceVersion->compare(Version::v3()) > -1) {
 			$registry->register(new JsonLightODataWriter(JsonLightMetadataLevel::NONE(), $serviceURI));
 			$registry->register(new JsonLightODataWriter(JsonLightMetadataLevel::MINIMAL(), $serviceURI));
 			$registry->register(new JsonLightODataWriter(JsonLightMetadataLevel::FULL(), $serviceURI));
@@ -351,7 +351,7 @@ 
 
 	    if (is_null($responseContentType) && $request->getTargetKind() != TargetKind::MEDIA_RESOURCE()) {
 		    //the responseContentType can ONLY be null if it's a stream (media resource) and that stream is storing null as the content type
-		    throw new ODataException( Messages::unsupportedMediaType(), 415 );
+		    throw new ODataException(Messages::unsupportedMediaType(), 415);
 	    }
 
 	    $odataModelInstance = null;
@@ -518,10 +518,10 @@ 
 
 	    //if the $format header is present it overrides the accepts header
 	    $format = $host->getQueryStringItem(ODataConstants::HTTPQUERY_STRING_FORMAT);
-	    if(!is_null($format)){
+	    if (!is_null($format)) {
 
             //There's a strange edge case..if application/json is supplied and it's V3
-            if($format == MimeTypes::MIME_APPLICATION_JSON && $requestVersion == Version::v3()){
+            if ($format == MimeTypes::MIME_APPLICATION_JSON && $requestVersion == Version::v3()) {
                 //then it's actual minimalmetadata
                 //TODO: should this be done with the header text too?
                 $format = MimeTypes::MIME_APPLICATION_JSON_MINIMAL_META;
@@ -537,7 +537,7 @@ 
 	    //getTargetKind doesn't deal with link resources directly and this can change things
 	    $targetKind = $request->isLinkUri() ? TargetKind::LINK() : $request->getTargetKind();
 
-	    switch($targetKind){
+	    switch ($targetKind) {
 		    case TargetKind::METADATA():
 			    return HttpProcessUtility::selectMimeType(
 				    $requestAcceptText,
@@ -614,7 +614,7 @@ 
 			    );
 
 		    case TargetKind::MEDIA_RESOURCE():
-			    if (!$request->isNamedStream() && !$request->getTargetResourceType()->isMediaLinkEntry()){
+			    if (!$request->isNamedStream() && !$request->getTargetResourceType()->isMediaLinkEntry()) {
 					throw ODataException::createBadRequestError(
 					    Messages::badRequestInvalidUriForMediaResource(
 						    $host->getAbsoluteRequestUri()->getUrlAsString()
@@ -648,7 +648,7 @@ 
 
 
 	    //If we got here, we just don't know what it is...
-        throw new ODataException( Messages::unsupportedMediaType(), 415 );
+        throw new ODataException(Messages::unsupportedMediaType(), 415);
 
     }
 
@@ -669,7 +669,7 @@ 
      * @return string|null The ETag for the entry object if it has eTag properties 
      *                     NULL otherwise.
      */
-    protected function compareETag(&$entryObject, ResourceType &$resourceType, 
+    protected function compareETag(&$entryObject, ResourceType & $resourceType, 
         &$needToSerializeResponse
     ) {      
         $needToSerializeResponse = true;
@@ -720,7 +720,7 @@ 
             // but that is causing an issue in Linux env where the 
             // firefix browser is unable to parse the ETag in this case.
             // Need to follow up PHP core devs for this. 
-            $eTag = ODataConstants::HTTP_WEAK_ETAG_PREFIX . $eTag . '"';
+            $eTag = ODataConstants::HTTP_WEAK_ETAG_PREFIX.$eTag.'"';
             if (!is_null($ifMatch)) {
                 if (strcmp($eTag, $ifMatch) != 0) {
                     // Requested If-Match value does not match with current 
@@ -743,7 +743,7 @@ 
             // but that is causing an issue in Linux env where the 
             // firefix browser is unable to parse the ETag in this case.
             // Need to follow up PHP core devs for this. 
-            $eTag = ODataConstants::HTTP_WEAK_ETAG_PREFIX . $eTag . '"';
+            $eTag = ODataConstants::HTTP_WEAK_ETAG_PREFIX.$eTag.'"';
         }
 
         return $eTag;
@@ -762,7 +762,7 @@ 
      *                     for use in a URI) there are etag properties, NULL if 
      *                     there is no etag property.
      */
-    protected function getETagForEntry(&$entryObject, ResourceType &$resourceType)
+    protected function getETagForEntry(&$entryObject, ResourceType & $resourceType)
     {
         $eTag = null;
         $comma = null;
@@ -777,18 +777,18 @@ 
             try {
 
 	            //TODO #88...also this seems like dupe work
-                $reflectionProperty  = new \ReflectionProperty($entryObject, $eTagProperty->getName() );
+                $reflectionProperty = new \ReflectionProperty($entryObject, $eTagProperty->getName());
                 $value = $reflectionProperty->getValue($entryObject);
             } catch (\ReflectionException $reflectionException) {
                 throw ODataException::createInternalServerError(
-                    Messages::failedToAccessProperty($eTagProperty->getName(), $resourceType->getName() )
+                    Messages::failedToAccessProperty($eTagProperty->getName(), $resourceType->getName())
                 );
             }
 
             if (is_null($value)) {
-                $eTag = $eTag . $comma. 'null';
+                $eTag = $eTag.$comma.'null';
             } else {
-                $eTag = $eTag . $comma . $type->convertToOData($value);
+                $eTag = $eTag.$comma.$type->convertToOData($value);
             }
 
             $comma = ',';

src/POData/Common/ODataException.php

Doc Comments +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
      * @param string $statusCode The status code
      * @param string $errorCode  The error code
      * 
-     * @return void
+     * @return ODataException
      */
     public function __construct($message, $statusCode, $errorCode= null)
     {

Spacing +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
      * 
      * @return void
      */
-    public function __construct($message, $statusCode, $errorCode= null)
+    public function __construct($message, $statusCode, $errorCode = null)
     {
         $this->_errorCode = $errorCode;
         $this->_statusCode = $statusCode;        

src/POData/HttpProcessUtility.php

Doc Comments +3 added lines, -2 removed lines

@@ -463,7 +463,7 @@ 
      * To check whether the given character is a HTTP token character
      * or not.
      * 
-     * @param char $char The character to inspect.
+     * @param string $char The character to inspect.
      * 
      * @return boolean True if the given character is a valid HTTP token
      *                 character, False otherwise.
@@ -606,6 +606,7 @@ 
      * @param string $text          Text to read qvalue from.
      * @param int    &$textIndex    Index into text where the qvalue starts.
      * @param int    &$qualityValue After the method executes, the normalized qvalue.
+     * @param integer $textIndex
      *
      * @throws HttpHeaderFailure If any error occured while reading and processing
      *                           the quality factor.
@@ -659,7 +660,7 @@ 
     /**
      * Converts the specified character from the ASCII range to a digit.
      * 
-     * @param char $c Character to convert
+     * @param string $c Character to convert
      *
      * @return int The Int32 value for $c, or -1 if it is an element separator.
      *

Spacing +6 added lines, -6 removed lines

@@ -63,7 +63,7 @@ 
      */
     public function getMimeType()
     {
-        return $this->_type . '/' . $this->_subType;
+        return $this->_type.'/'.$this->_subType;
     }
 
     /**
@@ -97,18 +97,18 @@ 
             //get the odata parameter (if there is one)
             $candidateODataValue = null;
             $candidateParts = explode(';', $candidate);
-            if(count($candidateParts) > 1){
+            if (count($candidateParts) > 1) {
                 //is it safe to assume the mime type is always the first part?
                 $candidate = array_shift($candidateParts); //move off the first type matcher
                 //the rest look like QSPs..kinda so we can do this
                 parse_str(implode("&", $candidateParts), $candidateParts);
-                if(array_key_exists('odata', $candidateParts)){
+                if (array_key_exists('odata', $candidateParts)) {
                    $candidateODataValue = $candidateParts['odata'];
                 }
             }
 
             //ensure that the odata parameter values match
-            if($this->getODataValue() !== $candidateODataValue){
+            if ($this->getODataValue() !== $candidateODataValue) {
                 return -1;
             }
 
@@ -697,7 +697,7 @@ 
     }
 
 
-	public static function headerToServerKey($headerName){
-		return 'HTTP_' . strtoupper(str_replace('-', '_', $headerName));
+	public static function headerToServerKey($headerName) {
+		return 'HTTP_'.strtoupper(str_replace('-', '_', $headerName));
 	}
 }
\ No newline at end of file

src/POData/ObjectModel/ObjectModelSerializer.php

Doc Comments +1 added lines, -1 removed lines

@@ -376,7 +376,7 @@
      *                                                    NULL for complex object.
      * @param string               $relativeUri           Relative uri for the given 
      *                                                    custom object.
-     * @param ODataEntry           &$odataEntry           ODataEntry instance to 
+     * @param ODataEntry           ODataEntry|null           ODataEntry instance to 
      *                                                    place links and
      *                                                    expansion of the 
      *                                                    entry object, 

Spacing +30 added lines, -31 removed lines

@@ -140,7 +140,7 @@ 
                 $this->getCurrentResourceSetWrapper()->getName()
             );
             
-            $url->url = rtrim($this->absoluteServiceUri, '/') . '/' . $relativeUri;
+            $url->url = rtrim($this->absoluteServiceUri, '/').'/'.$relativeUri;
         }
 
         return $url;
@@ -191,7 +191,7 @@ 
     public function writeTopLevelComplexObject(
 	    &$complexValue,
         $propertyName,
-        ResourceType &$resourceType
+        ResourceType & $resourceType
     ) {
 	    $propertyContent = new ODataPropertyContent();
         $this->_writeComplexValue(
@@ -218,7 +218,7 @@ 
     public function writeTopLevelBagObject(
 	    &$BagValue,
         $propertyName,
-        ResourceType &$resourceType
+        ResourceType & $resourceType
     ) {
 
 	    $propertyContent = new ODataPropertyContent();
@@ -245,7 +245,7 @@ 
      */
     public function writeTopLevelPrimitive(
 	    &$primitiveValue,
-        ResourceProperty &$resourceProperty
+        ResourceProperty & $resourceProperty
     ) {
 	    $propertyContent = new ODataPropertyContent();
 	    $propertyContent->properties[] = new ODataProperty();
@@ -287,7 +287,7 @@ 
                 $this->getCurrentResourceSetWrapper()->getName()
             );
 
-            $absoluteUri = rtrim($this->absoluteServiceUri, '/') . '/' . $relativeUri;
+            $absoluteUri = rtrim($this->absoluteServiceUri, '/').'/'.$relativeUri;
             $title = $resourceType->getName();
             //TODO Resolve actual resource type
             $actualResourceType = $resourceType;
@@ -334,18 +334,18 @@ 
      */
     private function _writeFeedElements(
         &$entryObjects,
-        ResourceType &$resourceType,
+        ResourceType & $resourceType,
         $title,
         $absoluteUri,
         $relativeUri,
-        ODataFeed &$feed
+        ODataFeed & $feed
     ) {
         $this->assert(is_array($entryObjects), '_writeFeedElements::is_array($entryObjects)');
         $feed->id = $absoluteUri;
         $feed->title = $title;
         $feed->selfLink = new ODataLink();
         $feed->selfLink->name = ODataConstants::ATOM_SELF_RELATION_ATTRIBUTE_VALUE;
-        $feed->selfLink->title =  $title;
+        $feed->selfLink->title = $title;
         $feed->selfLink->url = $relativeUri;
         
         if (empty($entryObjects)) {
@@ -389,11 +389,11 @@ 
      */
     private function _writeObjectProperties(
 	    $customObject,
-        ResourceType &$resourceType, 
+        ResourceType & $resourceType, 
         $absoluteUri, 
         $relativeUri, 
         &$odataEntry, 
-        ODataPropertyContent &$odataPropertyContent
+        ODataPropertyContent & $odataPropertyContent
     ) {
         $resourceTypeKind = $resourceType->getResourceTypeKind();
         if (is_null($absoluteUri) == ($resourceTypeKind == ResourceTypeKind::ENTITY)
@@ -464,7 +464,7 @@ 
                         $propertyValue,
                         $resourceProperty->getName(),
                         $resourceType2,
-                        $relativeUri . '/' . $resourceProperty->getName(),
+                        $relativeUri.'/'.$resourceProperty->getName(),
                         $odataPropertyContent
                     );
                 } else {
@@ -476,7 +476,7 @@ 
                             $propertyValue,
                             $resourceProperty->getName(),
                             $resourceType1,
-                            $relativeUri . '/' . $resourceProperty->getName(),
+                            $relativeUri.'/'.$resourceProperty->getName(),
                             $odataPropertyContent
                         );
                     } else if ($resourceProperty->getKind() == ResourcePropertyKind::PRIMITIVE 
@@ -541,7 +541,7 @@ 
                         $propertyValue,
                         $propertyName,
                         $bagResourceType,
-                        $relativeUri . '/' . $propertyName,
+                        $relativeUri.'/'.$propertyName,
                         $odataPropertyContent
                     );
                 } else if (ResourceProperty::sIsKindOf($propertyTypeKind, ResourcePropertyKind::PRIMITIVE)) {
@@ -554,7 +554,7 @@ 
                         $propertyValue,
                         $propertyName,
                         $complexResourceType,
-                        $relativeUri . '/' . $propertyName,
+                        $relativeUri.'/'.$propertyName,
                         $odataPropertyContent
                     );
                 } else {
@@ -569,17 +569,16 @@ 
             foreach ($navigationProperties as $navigationPropertyInfo) {
                 $propertyName = $navigationPropertyInfo->resourceProperty->getName();
                 $type = $navigationPropertyInfo->resourceProperty->getKind() == ResourcePropertyKind::RESOURCE_REFERENCE ? 
-                    'application/atom+xml;type=entry':
-                    'application/atom+xml;type=feed';
+                    'application/atom+xml;type=entry' : 'application/atom+xml;type=feed';
                 $link = new ODataLink();
-                $link->name = ODataConstants::ODATA_RELATED_NAMESPACE . $propertyName; 
+                $link->name = ODataConstants::ODATA_RELATED_NAMESPACE.$propertyName; 
                 $link->title = $propertyName;
                 $link->type = $type;
-                $link->url = $relativeUri . '/' . $propertyName;
+                $link->url = $relativeUri.'/'.$propertyName;
 
                 if ($navigationPropertyInfo->expanded) {
-                    $propertyRelativeUri = $relativeUri . '/' . $propertyName;
-                    $propertyAbsoluteUri = trim($absoluteUri, '/') . '/' . $propertyName;
+                    $propertyRelativeUri = $relativeUri.'/'.$propertyName;
+                    $propertyAbsoluteUri = trim($absoluteUri, '/').'/'.$propertyName;
                     $needPop = $this->pushSegmentForNavigationProperty($navigationPropertyInfo->resourceProperty);
                     $navigationPropertyKind = $navigationPropertyInfo->resourceProperty->getKind();
                     $this->assert(
@@ -645,7 +644,7 @@ 
      * @return void
      */
     private function _writePrimitiveValue(&$primitiveValue, 
-        ResourceProperty &$resourceProperty, ODataProperty &$odataProperty
+        ResourceProperty & $resourceProperty, ODataProperty & $odataProperty
     ) {
         if (is_object($primitiveValue)) {
             //TODO ERROR: The property 'PropertyName' 
@@ -684,8 +683,8 @@ 
      * @return void
      */
     private function _writeComplexValue(&$complexValue,
-        $propertyName, ResourceType &$resourceType, $relativeUri,
-        ODataPropertyContent &$odataPropertyContent
+        $propertyName, ResourceType & $resourceType, $relativeUri,
+        ODataPropertyContent & $odataPropertyContent
     ) {
         $odataProperty = new ODataProperty();
         $odataProperty->name = $propertyName;
@@ -724,8 +723,8 @@ 
      * @return void
      */
     private function _writeBagValue(&$BagValue,
-        $propertyName, ResourceType &$resourceType, $relativeUri,
-        ODataPropertyContent &$odataPropertyContent
+        $propertyName, ResourceType & $resourceType, $relativeUri,
+        ODataPropertyContent & $odataPropertyContent
     ) {
         $bagItemResourceTypeKind = $resourceType->getResourceTypeKind();
         $this->assert(
@@ -737,7 +736,7 @@ 
 
         $odataProperty = new ODataProperty();
         $odataProperty->name = $propertyName;
-        $odataProperty->typeName = 'Collection(' . $resourceType->getFullName() .')';
+        $odataProperty->typeName = 'Collection('.$resourceType->getFullName().')';
         if (is_null($BagValue) || (is_array($BagValue) && empty ($BagValue))) {
             $odataProperty->value = null;
         } else {
@@ -784,10 +783,10 @@ 
      */
     private function _writeMediaResourceMetadata(
         $entryObject,
-        ResourceType &$resourceType,
+        ResourceType & $resourceType,
         $title,
         $relativeUri,
-        ODataEntry &$odataEntry
+        ODataEntry & $odataEntry
     ) {
         if ($resourceType->isMediaLinkEntry()) {
             $odataEntry->isMediaLinkEntry = true;
@@ -833,7 +832,7 @@ 
      *                                            
      * @return void
      */
-    private function _primitiveToString(ResourceType &$primtiveResourceType,
+    private function _primitiveToString(ResourceType & $primtiveResourceType,
         $primitiveValue, &$stringValue
     ) {
         $type = $primtiveResourceType->getInstanceType();
@@ -868,8 +867,8 @@ 
      * @return void
      */
     private function _complexObjectToContent(&$complexValue,
-        $propertyName, ResourceType &$resourceType, $relativeUri,
-        ODataPropertyContent &$odataPropertyContent
+        $propertyName, ResourceType & $resourceType, $relativeUri,
+        ODataPropertyContent & $odataPropertyContent
     ) {
         $count = count($this->complexTypeInstanceCollection);
         for ($i = 0; $i < $count; $i++) {