WordPressDSExpressionProvider - Code Metrics - Qeti/POData - Measure and Improve Code Quality continuously with Scrutinizer

WordPressDSExpressionProvider C
last analyzed 2017-02-19 06:57 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	358
Duplicated Lines	34.64 %

Coupling/Cohesion

Components	2
Dependencies	2

Importance

Changes

Metric	Value
wmc	59
lcom	2
cbo	2
dl	124
loc	358
rs	6.1904
c	0
b	0
f	0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getIteratorName()	0	4	1
A	setResourceType()	0	4	1
A	onLogicalExpression()	13	13	3
B	onArithmeticExpression()	22	22	6
C	onRelationalExpression()	29	29	7
A	onUnaryExpression()	13	13	3
A	onConstantExpression()	10	10	3
A	onPropertyAccessExpression()	16	16	4
D	onFunctionCallExpression()	5	85	27
A	_prepareBinaryExpression()	16	16	2
A	_prepareUnaryExpression()	0	4	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like WordPressDSExpressionProvider often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use WordPressDSExpressionProvider, and based on these observations, apply Extract Interface, too.

<?php


use POData\UriProcessor\QueryProcessor\ExpressionParser\Expressions\ExpressionType;
use POData\Providers\Metadata\Type\IType;
use POData\Common\NotImplementedException;
use POData\Common\ODataConstants;
use POData\Providers\Expression\IExpressionProvider;
use POData\Providers\Metadata\ResourceType;
require_once 'WordPressMetadata.php';

class WordPressDSExpressionProvider implements IExpressionProvider
namespace YourVendor;

class YourClass { }
{
    const ADD                  = '+';
    const CLOSE_BRACKET        = ')';
    const COMMA                = ',';
    const DIVIDE               = '/';
    const SUBTRACT             = '-';
    const EQUAL                = '=';
    const GREATERTHAN          = '>';
    const GREATERTHAN_OR_EQUAL = '>=';
    const LESSTHAN             = '<';
    const LESSTHAN_OR_EQUAL    = '<=';
    const LOGICAL_AND          = '&&';
    const LOGICAL_NOT          = '!';
    const LOGICAL_OR           = '||';
    const MEMBERACCESS         = '';
    const MODULO               = '%';
    const MULTIPLY             = '*';
    const NEGATE               = '-';
    const NOTEQUAL             = '!=';
    const OPEN_BRAKET          = '(';
    
    /**
     * The type of the resource pointed by the resource path segement
     *
     * @var ResourceType
     */
    private $_resourceType;

    /**
     * 
     * @var array(string, array(string, string))
     */
    private $_entityMapping;

    /**
     * Constructs new instance of WordPressDSExpressionProvider
     *    
     */
    public function __construct()
    {
      $this->_entityMapping = CreateWordPressMetadata::getEntityMapping();
    }

    /**
     * Get the name of the iterator
     * 
     * @return string
     */
    public function getIteratorName()
    {
        return null;
    }

    /**
     * call-back for setting the resource type.
     *
     * @param ResourceType $resourceType The resource type on which the filter
     *                                   is going to be applied.
     */
    public function setResourceType(ResourceType $resourceType)
    {
      $this->_resourceType = $resourceType;
    }

    /**
     * Call-back for logical expression
     * 
     * @param ExpressionType $expressionType The type of logical expression.
     * @param string         $left           The left expression.
     * @param string         $right          The left expression.
     * 
     * @return string
     */
    public function onLogicalExpression($expressionType, $left, $right)

    {
        switch($expressionType) {
        case ExpressionType::AND_LOGICAL:
            return $this->_prepareBinaryExpression(self::LOGICAL_AND, $left, $right);
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ExpressionType::OR_LOGICAL:
            return $this->_prepareBinaryExpression(self::LOGICAL_OR, $left, $right);
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        default:
            throw new \InvalidArgumentException('onLogicalExpression');
        }
    }

    /**
     * Call-back for arithmetic expression
     * 
     * @param ExpressionType $expressionType The type of arithmetic expression.
     * @param string         $left           The left expression.
     * @param string         $right          The left expression.
     * 
     * @return string
     */
    public function onArithmeticExpression($expressionType, $left, $right)

    {
        switch($expressionType) {
        case ExpressionType::MULTIPLY:
            return $this->_prepareBinaryExpression(self::MULTIPLY, $left, $right);
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ExpressionType::DIVIDE:
            return $this->_prepareBinaryExpression(self::DIVIDE, $left, $right);
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ExpressionType::MODULO:
            return $this->_prepareBinaryExpression(self::MODULO, $left, $right);
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ExpressionType::ADD:
            return $this->_prepareBinaryExpression(self::ADD, $left, $right);
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ExpressionType::SUBTRACT:
            return $this->_prepareBinaryExpression(self::SUBTRACT, $left, $right);
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        default:
            throw new \InvalidArgumentException('onArithmeticExpression');
        }
    }

    /**
     * Call-back for relational expression
     * 
     * @param ExpressionType $expressionType The type of relation expression
     * @param string         $left           The left expression
     * @param string         $right          The left expression
     * 
     * @return string
     */
    public function onRelationalExpression($expressionType, $left, $right)

    {
        switch($expressionType) {
        case ExpressionType::GREATERTHAN:
            return $this->_prepareBinaryExpression(self::GREATERTHAN, $left, $right);
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ExpressionType::GREATERTHAN_OR_EQUAL:
            return $this->_prepareBinaryExpression(
                self::GREATERTHAN_OR_EQUAL, $left, $right
            );
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ExpressionType::LESSTHAN:
            return $this->_prepareBinaryExpression(self::LESSTHAN, $left, $right);
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ExpressionType::LESSTHAN_OR_EQUAL:
            return $this->_prepareBinaryExpression(
                self::LESSTHAN_OR_EQUAL, $left, $right
            );
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ExpressionType::EQUAL:
            return $this->_prepareBinaryExpression(self::EQUAL, $left, $right);
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ExpressionType::NOTEQUAL:
            return $this->_prepareBinaryExpression(self::NOTEQUAL, $left, $right);
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        default:
            throw new \InvalidArgumentException('onArithmeticExpression');
        }
    }

    /**
     * Call-back for unary expression
     * 
     * @param ExpressionType $expressionType The type of unary expression
     * @param string         $child          The child expression
     * 
     * @return string
     */
    public function onUnaryExpression($expressionType, $child)

    {
        switch($expressionType) {
        case ExpressionType::NEGATE:
            return $this->_prepareUnaryExpression(self::NEGATE, $child);
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ExpressionType::NOT_LOGICAL:
            return $this->_prepareUnaryExpression(self::LOGICAL_NOT, $child);
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        default:
            throw new \InvalidArgumentException('onUnaryExpression');
        }
    }

    /**
     * Call-back for constant expression
     * 
     * @param IType  $type  The type of constant
     * @param objetc $value The value of the constant
     * 
     * @return string
     */
    public function onConstantExpression(IType $type, $value)

    {
        if (is_bool($value)) {
            return var_export($value, true);
        } else if (is_null($value)) {
            return var_export(null, true);
        }

        return $value;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Call-back for property access expression
     * 
     * @param PropertyAccessExpression $expression The property access expression
     * 
     * @return string
     */

    public function onPropertyAccessExpression($expression)

    {
        $parent = $expression;
        $variable = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $entityTypeName = $this->_resourceType->getName();
        $propertyName = $parent->getResourceProperty()->getName();
        if (is_array($this->_entityMapping)) {
          if (array_key_exists($entityTypeName, $this->_entityMapping)) {
            if (array_key_exists($propertyName, $this->_entityMapping[$entityTypeName])) {
              return $this->_entityMapping[$entityTypeName][$propertyName];
            }
          }
        }
     
        return $propertyName;
    }

    /**
     * Call-back for function call expression
     * 
     * @param FunctionDescription $functionDescription Description of the function.
     * @param array<string>       $params              Paameters to the function.
     * 
     * @return string
     */
    public function onFunctionCallExpression($functionDescription, $params)
    {
        switch($functionDescription->functionName) {
        case ODataConstants::STRFUN_COMPARE:
            return "STRCMP($params[0], $params[1])";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::STRFUN_ENDSWITH:
          return "(STRCMP($params[1],RIGHT($params[0],LENGTH($params[1]))) = 0)";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::STRFUN_INDEXOF:
            return "INSTR($params[0], $params[1]) - 1";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::STRFUN_REPLACE:
          return "REPLACE($params[0],$params[1],$params[2])";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::STRFUN_STARTSWITH:
          return "(STRCMP($params[1],LEFT($params[0],LENGTH($params[1]))) = 0)";
            break; 
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::STRFUN_TOLOWER:
          return "LOWER($params[0])";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::STRFUN_TOUPPER:
          return "UPPER($params[0])";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::STRFUN_TRIM:
          return "TRIM($params[0])";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::STRFUN_SUBSTRING:

            return count($params) == 3 ?
                "SUBSTRING($params[0], $params[1] + 1, $params[2])" :
                "SUBSTRING($params[0], $params[1] + 1)";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::STRFUN_SUBSTRINGOF:
            return "(LOCATE($params[0], $params[1]) > 0)";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::STRFUN_CONCAT:
            return "CONCAT($params[0],$params[1])";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::STRFUN_LENGTH:
            return "LENGTH($params[0])";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::GUIDFUN_EQUAL:
        	return "STRCMP($params[0], $params[1])";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::DATETIME_COMPARE:
            return "DATETIMECMP($params[0]; $params[1])";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::DATETIME_YEAR:
            return "EXTRACT(YEAR from ".$params[0].")";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::DATETIME_MONTH:
            return "EXTRACT(MONTH from ".$params[0].")";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::DATETIME_DAY:
            return "EXTRACT(DAY from ".$params[0].")";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::DATETIME_HOUR:
            return "EXTRACT(HOUR from ".$params[0].")";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::DATETIME_MINUTE:
            return "EXTRACT(MINUTE from ".$params[0].")";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::DATETIME_SECOND:
            return "EXTRACT(SECOND from ".$params[0].")";
            break;                
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::MATHFUN_ROUND:
            return "ROUND($params[0])";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::MATHFUN_CEILING:
            return "CEIL($params[0])";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::MATHFUN_FLOOR:
            return "FLOOR($params[0])";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case ODataConstants::BINFUL_EQUAL:
            return "($params[0] = $params[1])";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        case 'is_null':
            return "is_null($params[0])";
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            
        default:
            throw new \InvalidArgumentException('onFunctionCallExpression');
        }
    }

    /**
     * To format binary expression
     * 
     * @param string $operator The binary operator.
     * @param string $left     The left operand.
     * @param string $right    The right operand.
     * 
     * @return string
     */
    private function _prepareBinaryExpression($operator, $left, $right)

    {
      // Special handling for DATETIMECMP
      if (!substr_compare($left, "DATETIMECMP", 0, 11)) {
        $str = explode(';', $left, 2);
        $str[0] = str_replace('DATETIMECMP', '', $str[0]);
        return self::OPEN_BRAKET
          . $str[0] . ' ' . $operator
          . ' ' . $str[1] . self::CLOSE_BRACKET;
      }

        return 
            self::OPEN_BRAKET 
            . $left . ' ' . $operator 
            . ' ' . $right . self::CLOSE_BRACKET;
    }

    /**
     * To format unary expression
     * 
     * @param string $operator The unary operator.
     * @param string $child    The operand.
     * 
     * @return string
     */
    private function _prepareUnaryExpression($operator, $child)
    {
        return $operator . self::OPEN_BRAKET . $child . self::CLOSE_BRACKET;
    }
}


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-02-22 16:32 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 11 and the first side effect is on line 9. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			use POData\UriProcessor\QueryProcessor\ExpressionParser\Expressions\ExpressionType;
4			use POData\Providers\Metadata\Type\IType;
5			use POData\Common\NotImplementedException;
6			use POData\Common\ODataConstants;
7			use POData\Providers\Expression\IExpressionProvider;
8			use POData\Providers\Metadata\ResourceType;
9			require_once 'WordPressMetadata.php';
10
11			class WordPressDSExpressionProvider implements IExpressionProvider
			0 ignored issues – show Coding Style Compatibility introduced 2016-02-22 16:32 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
12			{
13			const ADD = '+';
14			const CLOSE_BRACKET = ')';
15			const COMMA = ',';
16			const DIVIDE = '/';
17			const SUBTRACT = '-';
18			const EQUAL = '=';
19			const GREATERTHAN = '>';
20			const GREATERTHAN_OR_EQUAL = '>=';
21			const LESSTHAN = '<';
22			const LESSTHAN_OR_EQUAL = '<=';
23			const LOGICAL_AND = '&&';
24			const LOGICAL_NOT = '!';
25			const LOGICAL_OR = '\|\|';
26			const MEMBERACCESS = '';
27			const MODULO = '%';
28			const MULTIPLY = '*';
29			const NEGATE = '-';
30			const NOTEQUAL = '!=';
31			const OPEN_BRAKET = '(';
32
33			/**
34			* The type of the resource pointed by the resource path segement
35			*
36			* @var ResourceType
37			*/
38			private $_resourceType;

Qeti / POData

WordPressDSExpressionProvider C last analyzed 2017-02-19 06:57 UTC