MainController.completeTasks() - Code Metrics - Inspection of "re-enable deletion" - QTodoTxt/QTodoTxt2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — qml (#43)

by Olivier

created 2017-06-11 20:41 UTC

MainController.completeTasks() B

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
dl	0
loc	14
rs	8
c	0
b	0
f	0

import logging
import os
import string

from PyQt5 import QtCore

from qtodotxt2.lib import tasklib
from qtodotxt2.lib.file import File
from qtodotxt2.filters_controller import FiltersController

logger = logging.getLogger(__name__)


class MainController(QtCore.QObject):

    error = QtCore.pyqtSignal(str, arguments=["msg"])
    fileExternallyModified = QtCore.pyqtSignal()

    def __init__(self, args):
        super(MainController, self).__init__()
        self._args = args
        self._filteredTasks = []
        self._sortingMode = "default"
        # use object variable for setting only used in this class
        # others are accessed through QSettings
        self._settings = QtCore.QSettings()
        self._file = File()
        self._file.fileExternallyModified.connect(self.fileExternallyModified)
        self._file.fileModified.connect(self._fileModified)
        self.filtersController = FiltersController()
        self._title = "QTodoTxt"
        self._recentFiles = self._settings.value("recent_files", [])
        self._updateCompletionStrings()
        self._forced = None

    def showError(self, msg):
        logger.debug("ERROR: %s", msg)
        self.error.emit(msg)

    completionChanged = QtCore.pyqtSignal()

    @QtCore.pyqtProperty('QStringList', notify=completionChanged)
    def completionStrings(self):
        return self._completionStrings

    @QtCore.pyqtProperty('QStringList', notify=completionChanged)
    def calendarKeywords(self):
        return ['due:', 't:']

    def _updateCompletionStrings(self):
        contexts = ['@' + name for name in self._file.getAllContexts()]
        projects = ['+' + name for name in self._file.getAllProjects()]
        lowest_priority = self._settings.value("lowest_priority", "D")
        idx = string.ascii_uppercase.index(lowest_priority) + 1
        priorities = ['(' + val + ')' for val in string.ascii_uppercase[:idx]]
        keywords = ['rec:', 'h:1'] #['due:', 't:', 'rec:', 'h:1']
        self._completionStrings = contexts + projects + priorities + self.calendarKeywords + keywords
        self.completionChanged.emit()

    @QtCore.pyqtSlot('QModelIndexList')
    def filterByIndexes(self, idxs):
        self.filtersController.setFiltersByIndexes(idxs)
        self.applyFilters()

    @QtCore.pyqtSlot('QString', 'int', result='int')
    def newTask(self, text='', after=None):
        task = tasklib.Task(text)
        if bool(self._settings.value("Preferences/add_creation_date", False, type=bool)):
            task.addCreationDate()
        if after is None:
            after = len(self._filteredTasks) - 1
        #self._file.addTask(task)
        self._filteredTasks.insert(after + 1, task)  # force the new task to be visible
        self._file.tasks.append(task)

        self._file.connectTask(task)  #Ensure task will be added
        self.filteredTasksChanged.emit()
        return after + 1

    @QtCore.pyqtSlot('QModelIndexList')
    @QtCore.pyqtSlot('QVariantList')
    def deleteTasks(self, tasks):
        for task in tasks:
            if not isinstance(task, tasklib.Task):
                # if task is not a task assume it is an int
                task = self._filteredTasks[int(task)]
            self._file.deleteTask(task)

    @property
    def allTasks(self):
        return self._file.tasks

    @allTasks.setter
    def allTasks(self, tasks):
        self._file.tasks = tasks

    filteredTasksChanged = QtCore.pyqtSignal()

    @QtCore.pyqtProperty('QVariant', notify=filteredTasksChanged)
    def filteredTasks(self):
        return self._filteredTasks

    showFutureChanged = QtCore.pyqtSignal('bool')

    @QtCore.pyqtProperty('bool', notify=showFutureChanged)
    def showFuture(self):
        return self.filtersController.showFuture

    @showFuture.setter
    def showFuture(self, val):
        self.filtersController.showFuture = val
        self.showFutureChanged.emit(val)
        self.applyFilters()

    showHiddenChanged = QtCore.pyqtSignal('bool')

    @QtCore.pyqtProperty('bool', notify=showHiddenChanged)
    def showHidden(self):
        return self.filtersController.showHidden

    @showHidden.setter
    def showHidden(self, val):
        self.filtersController.showHidden = val
        self.showHiddenChanged.emit(val)
        self.applyFilters()

    sortingModeChanged = QtCore.pyqtSignal(str)

    @QtCore.pyqtProperty(str, notify=showFutureChanged)
    def sortingMode(self):
        return self._sortingMode

    @sortingMode.setter
    def sortingMode(self, val):
        self._sortingMode = val
        self.sortingModeChanged.emit(val)
        self.applyFilters()

    searchTextChanged = QtCore.pyqtSignal(str)

    @QtCore.pyqtProperty('QString', notify=searchTextChanged)
    def searchText(self):
        return self.filtersController.searchText

    @searchText.setter
    def searchText(self, txt):
        self.filtersController.searchText = txt
        self.applyFilters()
        self.searchTextChanged.emit(txt)

    showCompletedChanged = QtCore.pyqtSignal('bool')

    @QtCore.pyqtProperty('bool', notify=showCompletedChanged)
    def showCompleted(self):
        return self.filtersController.showCompleted

    @showCompleted.setter
    def showCompleted(self, val):
        self.filtersController.showCompleted = val
        self.showCompletedChanged.emit(val)
        self.applyFilters()

    def auto_save(self):
        if bool(self._settings.value("Preferences/auto_save", True, type=bool)):
            self.save()

    def start(self):
        if self._args.file:
            filename = self._args.file
        else:
            filename = self._settings.value("last_open_file")

        if filename:
            try:
                self.open(filename)
            except OSError as ex:
                self.showError(str(ex))

        self.applyFilters()
        self._updateTitle()

    filtersUpdated = QtCore.pyqtSignal()

    @QtCore.pyqtProperty('QVariant', notify=filtersUpdated)
    def filtersModel(self):
        return self.filtersController.model

    def _updateFilterTree(self):
        self.filtersController.updateFiltersModel(self._file)
        self.filtersUpdated.emit()

    def applyFilters(self, filters=None):
        if filters is not None:
            self.filtersController.setFilters(filters)
        tasks = self.filtersController.filter(self._file.tasks)
        tasks = getattr(tasklib.TaskSorter, self._sortingMode)(tasks)
        self._filteredTasks = tasks
        self.filteredTasksChanged.emit()

    @QtCore.pyqtSlot()
    def archiveCompletedTasks(self):
        done = [task for task in self._file.tasks if task.is_complete]
        for task in done:
            self._file.saveDoneTask(task)
            self._file.deleteTask(task)
        self.applyFilters()
        self.auto_save()

    modifiedChanged = QtCore.pyqtSignal(bool)

    @QtCore.pyqtProperty('bool', notify=modifiedChanged)
    def modified(self):
        return self._file.modified

    def _fileModified(self, val=True):
        if val:
            self.auto_save()
            self.applyFilters()
            self._updateCompletionStrings()
            self._updateFilterTree()
        self._updateTitle()
        self.modifiedChanged.emit(val)

    @QtCore.pyqtSlot("QUrl")
    @QtCore.pyqtSlot()
    def save(self, path=None):
        if not path:
            path = self._file.filename
        elif isinstance(path, QtCore.QUrl):
            path = path.toLocalFile()
        self._file.filename = path

        logger.debug('MainController, saving file: %s.', path)
        try:
            self._file.save(path)
        except OSError as ex:
            logger.exception("Error saving file %s", path)
            self.showError(ex)
            return
        self._settings.setValue("last_open_file", path)
        self._settings.sync()

    def _updateTitle(self):
        title = 'QTodoTxt - '
        if self._file.filename:
            filename = os.path.basename(self._file.filename)
            title += filename
        else:
            title += 'Untitled'
        if self._file.modified:
            title += ' (*)'
        self._title = title
        self.titleChanged.emit(self._title)

    titleChanged = QtCore.pyqtSignal(str)

    @QtCore.pyqtProperty('QString', notify=titleChanged)
    def title(self):
        return self._title

    @QtCore.pyqtSlot(result='bool')
    def canExit(self):
        self.auto_save()
        return not self._file.modified

    def new(self):
        if self.canExit():
            self._file = File()
            self._loadFileToUI()

    @QtCore.pyqtSlot()
    def reload(self):
        self.open(self._file.filename)

    @QtCore.pyqtSlot('QUrl')
    @QtCore.pyqtSlot('QString')
    def open(self, filename):
        if isinstance(filename, QtCore.QUrl):
            filename = filename.toLocalFile()
        logger.debug('MainController.open called with filename="%s"', filename)
        try:
            self._file.load(filename)
        except Exception as ex:
            self.showError(self.tr("Error opening file: {}.\n Exception:{}").format(filename, ex))
            return
        self._loadFileToUI()
        self._settings.setValue("last_open_file", filename)
        self.updateRecentFile()

    recentFilesChanged = QtCore.pyqtSignal()

    @QtCore.pyqtProperty('QVariant', notify=recentFilesChanged)
    def recentFiles(self):
        return self._recentFiles

    def updateRecentFile(self):
        if self._file.filename in self._recentFiles:
            self._recentFiles.remove(self._file.filename)
        self._recentFiles.insert(0, self._file.filename)
        self._recentFiles = self._recentFiles[:int(self._settings.value("max_recent_files", 6))]
        self._settings.setValue("recent_files", self._recentFiles)
        self.recentFilesChanged.emit()

    def _loadFileToUI(self):
        self.applyFilters()
        self._updateCompletionStrings()
        self._updateFilterTree()

    @QtCore.pyqtSlot('QModelIndexList')
    @QtCore.pyqtSlot('QVariantList')
    def completeTasks(self, tasks):
        for task in tasks:
            if not isinstance(task, tasklib.Task):
                # if task is not a task assume it is an int
                task = self._filteredTasks[int(task)]
            if not task.is_complete:
                if task.recursion is not None and task.due is not None:
                    new_task = tasklib.recurTask(task)
                    self._file.addTask(new_task)
                task.setCompleted()
            else:
                task.setPending()



1			import logging
2			import os
3			import string
4
5			from PyQt5 import QtCore
6
7			from qtodotxt2.lib import tasklib
8			from qtodotxt2.lib.file import File
9			from qtodotxt2.filters_controller import FiltersController
10
11			logger = logging.getLogger(__name__)
12
13
14			class MainController(QtCore.QObject):
15
16			error = QtCore.pyqtSignal(str, arguments=["msg"])
17			fileExternallyModified = QtCore.pyqtSignal()
18
19			def __init__(self, args):
20			super(MainController, self).__init__()
21			self._args = args
22			self._filteredTasks = []
23			self._sortingMode = "default"
24			# use object variable for setting only used in this class
25			# others are accessed through QSettings
26			self._settings = QtCore.QSettings()
27			self._file = File()
28			self._file.fileExternallyModified.connect(self.fileExternallyModified)
29			self._file.fileModified.connect(self._fileModified)
30			self.filtersController = FiltersController()
31			self._title = "QTodoTxt"
32			self._recentFiles = self._settings.value("recent_files", [])
33			self._updateCompletionStrings()
34			self._forced = None
35
36			def showError(self, msg):
37			logger.debug("ERROR: %s", msg)
38			self.error.emit(msg)
39
40			completionChanged = QtCore.pyqtSignal()
41
42			@QtCore.pyqtProperty('QStringList', notify=completionChanged)
43			def completionStrings(self):
44			return self._completionStrings
45
46			@QtCore.pyqtProperty('QStringList', notify=completionChanged)
47			def calendarKeywords(self):
48			return ['due:', 't:']
49
50			def _updateCompletionStrings(self):
51			contexts = ['@' + name for name in self._file.getAllContexts()]
52			projects = ['+' + name for name in self._file.getAllProjects()]
53			lowest_priority = self._settings.value("lowest_priority", "D")
54			idx = string.ascii_uppercase.index(lowest_priority) + 1
55			priorities = ['(' + val + ')' for val in string.ascii_uppercase[:idx]]
56			keywords = ['rec:', 'h:1'] #['due:', 't:', 'rec:', 'h:1']
57			self._completionStrings = contexts + projects + priorities + self.calendarKeywords + keywords
58			self.completionChanged.emit()
59
60			@QtCore.pyqtSlot('QModelIndexList')
61			def filterByIndexes(self, idxs):
62			self.filtersController.setFiltersByIndexes(idxs)
63			self.applyFilters()
64
65			@QtCore.pyqtSlot('QString', 'int', result='int')
66			def newTask(self, text='', after=None):
67			task = tasklib.Task(text)
68			if bool(self._settings.value("Preferences/add_creation_date", False, type=bool)):
69			task.addCreationDate()
70			if after is None:
71			after = len(self._filteredTasks) - 1
72			#self._file.addTask(task)
73			self._filteredTasks.insert(after + 1, task) # force the new task to be visible
74			self._file.tasks.append(task)
75
76			self._file.connectTask(task) #Ensure task will be added
77			self.filteredTasksChanged.emit()
78			return after + 1
79
80			@QtCore.pyqtSlot('QModelIndexList')
81			@QtCore.pyqtSlot('QVariantList')
82			def deleteTasks(self, tasks):
83			for task in tasks:
84			if not isinstance(task, tasklib.Task):
85			# if task is not a task assume it is an int
86			task = self._filteredTasks[int(task)]
87			self._file.deleteTask(task)
88
89			@property
90			def allTasks(self):
91			return self._file.tasks
92
93			@allTasks.setter
94			def allTasks(self, tasks):
95			self._file.tasks = tasks
96
97			filteredTasksChanged = QtCore.pyqtSignal()
98
99			@QtCore.pyqtProperty('QVariant', notify=filteredTasksChanged)
100			def filteredTasks(self):
101			return self._filteredTasks
102
103			showFutureChanged = QtCore.pyqtSignal('bool')
104
105			@QtCore.pyqtProperty('bool', notify=showFutureChanged)
106			def showFuture(self):
107			return self.filtersController.showFuture
108
109			@showFuture.setter
110			def showFuture(self, val):
111			self.filtersController.showFuture = val
112			self.showFutureChanged.emit(val)
113			self.applyFilters()
114
115			showHiddenChanged = QtCore.pyqtSignal('bool')
116
117			@QtCore.pyqtProperty('bool', notify=showHiddenChanged)
118			def showHidden(self):
119			return self.filtersController.showHidden
120
121			@showHidden.setter
122			def showHidden(self, val):
123			self.filtersController.showHidden = val
124			self.showHiddenChanged.emit(val)
125			self.applyFilters()
126
127			sortingModeChanged = QtCore.pyqtSignal(str)
128
129			@QtCore.pyqtProperty(str, notify=showFutureChanged)
130			def sortingMode(self):
131			return self._sortingMode
132
133			@sortingMode.setter
134			def sortingMode(self, val):
135			self._sortingMode = val
136			self.sortingModeChanged.emit(val)
137			self.applyFilters()
138
139			searchTextChanged = QtCore.pyqtSignal(str)
140
141			@QtCore.pyqtProperty('QString', notify=searchTextChanged)
142			def searchText(self):
143			return self.filtersController.searchText
144
145			@searchText.setter
146			def searchText(self, txt):
147			self.filtersController.searchText = txt
148			self.applyFilters()
149			self.searchTextChanged.emit(txt)
150
151			showCompletedChanged = QtCore.pyqtSignal('bool')
152
153			@QtCore.pyqtProperty('bool', notify=showCompletedChanged)
154			def showCompleted(self):
155			return self.filtersController.showCompleted
156
157			@showCompleted.setter
158			def showCompleted(self, val):
159			self.filtersController.showCompleted = val
160			self.showCompletedChanged.emit(val)
161			self.applyFilters()
162
163			def auto_save(self):
164			if bool(self._settings.value("Preferences/auto_save", True, type=bool)):
165			self.save()
166
167			def start(self):
168			if self._args.file:
169			filename = self._args.file
170			else:
171			filename = self._settings.value("last_open_file")
172
173			if filename:
174			try:
175			self.open(filename)
176			except OSError as ex:
177			self.showError(str(ex))
178
179			self.applyFilters()
180			self._updateTitle()
181
182			filtersUpdated = QtCore.pyqtSignal()
183
184			@QtCore.pyqtProperty('QVariant', notify=filtersUpdated)
185			def filtersModel(self):
186			return self.filtersController.model
187
188			def _updateFilterTree(self):
189			self.filtersController.updateFiltersModel(self._file)
190			self.filtersUpdated.emit()
191
192			def applyFilters(self, filters=None):
193			if filters is not None:
194			self.filtersController.setFilters(filters)
195			tasks = self.filtersController.filter(self._file.tasks)
196			tasks = getattr(tasklib.TaskSorter, self._sortingMode)(tasks)
197			self._filteredTasks = tasks
198			self.filteredTasksChanged.emit()
199
200			@QtCore.pyqtSlot()
201			def archiveCompletedTasks(self):
202			done = [task for task in self._file.tasks if task.is_complete]
203			for task in done:
204			self._file.saveDoneTask(task)
205			self._file.deleteTask(task)
206			self.applyFilters()
207			self.auto_save()
208
209			modifiedChanged = QtCore.pyqtSignal(bool)
210
211			@QtCore.pyqtProperty('bool', notify=modifiedChanged)
212			def modified(self):
213			return self._file.modified
214
215			def _fileModified(self, val=True):
216			if val:
217			self.auto_save()
218			self.applyFilters()
219			self._updateCompletionStrings()
220			self._updateFilterTree()
221			self._updateTitle()
222			self.modifiedChanged.emit(val)
223
224			@QtCore.pyqtSlot("QUrl")
225			@QtCore.pyqtSlot()
226			def save(self, path=None):
227			if not path:
228			path = self._file.filename
229			elif isinstance(path, QtCore.QUrl):
230			path = path.toLocalFile()
231			self._file.filename = path
232
233			logger.debug('MainController, saving file: %s.', path)
234			try:
235			self._file.save(path)
236			except OSError as ex:
237			logger.exception("Error saving file %s", path)
238			self.showError(ex)
239			return
240			self._settings.setValue("last_open_file", path)
241			self._settings.sync()
242
243			def _updateTitle(self):
244			title = 'QTodoTxt - '
245			if self._file.filename:
246			filename = os.path.basename(self._file.filename)
247			title += filename
248			else:
249			title += 'Untitled'
250			if self._file.modified:
251			title += ' (*)'
252			self._title = title
253			self.titleChanged.emit(self._title)
254
255			titleChanged = QtCore.pyqtSignal(str)
256
257			@QtCore.pyqtProperty('QString', notify=titleChanged)
258			def title(self):
259			return self._title
260
261			@QtCore.pyqtSlot(result='bool')
262			def canExit(self):
263			self.auto_save()
264			return not self._file.modified
265
266			def new(self):
267			if self.canExit():
268			self._file = File()
269			self._loadFileToUI()
270
271			@QtCore.pyqtSlot()
272			def reload(self):
273			self.open(self._file.filename)
274
275			@QtCore.pyqtSlot('QUrl')
276			@QtCore.pyqtSlot('QString')
277			def open(self, filename):
278			if isinstance(filename, QtCore.QUrl):
279			filename = filename.toLocalFile()
280			logger.debug('MainController.open called with filename="%s"', filename)
281			try:
282			self._file.load(filename)
283			except Exception as ex:
284			self.showError(self.tr("Error opening file: {}.\n Exception:{}").format(filename, ex))
285			return
286			self._loadFileToUI()
287			self._settings.setValue("last_open_file", filename)
288			self.updateRecentFile()
289
290			recentFilesChanged = QtCore.pyqtSignal()
291
292			@QtCore.pyqtProperty('QVariant', notify=recentFilesChanged)
293			def recentFiles(self):
294			return self._recentFiles
295
296			def updateRecentFile(self):
297			if self._file.filename in self._recentFiles:
298			self._recentFiles.remove(self._file.filename)
299			self._recentFiles.insert(0, self._file.filename)
300			self._recentFiles = self._recentFiles[:int(self._settings.value("max_recent_files", 6))]
301			self._settings.setValue("recent_files", self._recentFiles)
302			self.recentFilesChanged.emit()
303
304			def _loadFileToUI(self):
305			self.applyFilters()
306			self._updateCompletionStrings()
307			self._updateFilterTree()
308
309			@QtCore.pyqtSlot('QModelIndexList')
310			@QtCore.pyqtSlot('QVariantList')
311			def completeTasks(self, tasks):
312			for task in tasks:
313			if not isinstance(task, tasklib.Task):
314			# if task is not a task assume it is an int
315			task = self._filteredTasks[int(task)]
316			if not task.is_complete:
317			if task.recursion is not None and task.due is not None:
318			new_task = tasklib.recurTask(task)
319			self._file.addTask(new_task)
320			task.setCompleted()
321			else:
322			task.setPending()
323
324

QTodoTxt / QTodoTxt2

Pull Request — qml (#43)

MainController.completeTasks() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like