Schedule::__construct() - Code Metrics - Inspection of "Merge pull request #28 from PyRowMan/feature/19" - PyRowMan/pheanstalk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ab8b9d...7e5c9a )

by Valentin

created 2019-11-25 16:51 UTC

Schedule::__construct() A

↳ Parent: Schedule

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	1

Importance

Changes

Metric	Value
eloc	8
c	0
b	0
f	0
dl	0
loc	18
ccs	9
cts	9
cp	1
rs	10
cc	1
nc	1
nop	8
crap	1

How to fix Many Parameters

<?php


namespace Pheanstalk\Structure;


class Schedule
{
    const FAILURE_TYPE_CONTINUE = "CONTINUE";
    const FAILURE_TYPE_SUSPEND = "SUSPEND";

    /** @var int|null $id */
    protected $id;

    /** @var bool $active */
    protected $active;

    /** @var string|null $comment */
    protected $comment;

    /** @var string|null $host */
    protected $host;

    /** @var string|null $node */
    protected $node;

    /** @var string|null $node */
    protected $onFailure;

    /** @var TimeSchedule $schedule */
    protected $schedule;

    /** @var string|null $user */
    protected $user;

    /** @var int $workflow */
    protected $workflow;

    public function __construct(
        int $workflow,
        TimeSchedule $schedule,
        $onFailure = self::FAILURE_TYPE_CONTINUE,
        $active = true,
        $comment = null,
        $user = null,
        $host = null,
        $node = "any"
    ) {
        $this->workflow = $workflow;
        $this->schedule = $schedule;
        $this->onFailure = $onFailure;
        $this->active = $active;
        $this->comment = $comment;
        $this->user = $user;
        $this->host = $host;
        $this->node = $node;
    }

    /**
     * @return int|null
     */
    public function getId(): ?int
    {
        return $this->id;
    }

    /**
     * @param int|null $id
     *
     * @return Schedule
     */
    public function setId(?int $id): Schedule
    {
        $this->id = $id;
        return $this;
    }

    /**
     * @return bool
     */
    public function isActive(): bool
    {
        return $this->active;
    }

    /**
     * @param bool $active
     *
     * @return Schedule
     */
    public function setActive(bool $active): Schedule
    {
        $this->active = $active;
        return $this;
    }

    /**
     * @return string|null
     */
    public function getComment(): ?string
    {
        return $this->comment;
    }

    /**
     * @param string|null $comment
     *
     * @return Schedule
     */
    public function setComment(?string $comment): Schedule
    {
        $this->comment = $comment;
        return $this;
    }

    /**
     * @return string|null
     */
    public function getHost(): ?string
    {
        return $this->host;
    }

    /**
     * @param string|null $host
     *
     * @return Schedule
     */
    public function setHost(?string $host): Schedule
    {
        $this->host = $host;
        return $this;
    }

    /**
     * @return string|null
     */
    public function getNode(): ?string
    {
        return $this->node;
    }

    /**
     * @param string|null $node
     *
     * @return Schedule
     */
    public function setNode(?string $node): Schedule
    {
        $this->node = $node;
        return $this;
    }

    /**
     * @return string|null
     */
    public function getOnFailure(): ?string
    {
        return $this->onFailure;
    }

    /**
     * @param string|null $onFailure
     *
     * @return Schedule
     */
    public function setOnFailure(?string $onFailure): Schedule
    {
        $this->onFailure = $onFailure;
        return $this;
    }

    /**
     * @return TimeSchedule
     */
    public function getSchedule(): TimeSchedule
    {
        return $this->schedule;
    }

    /**
     * @param TimeSchedule $schedule
     *
     * @return Schedule
     */
    public function setSchedule(TimeSchedule $schedule): Schedule
    {
        $this->schedule = $schedule;
        return $this;
    }

    /**
     * @return string|null
     */
    public function getUser(): ?string
    {
        return $this->user;
    }

    /**
     * @param string|null $user
     *
     * @return Schedule
     */
    public function setUser(?string $user): Schedule
    {
        $this->user = $user;
        return $this;
    }

    /**
     * @return int
     */
    public function getWorkflow(): int
    {
        return $this->workflow;
    }

    /**
     * @param int $workflow
     *
     * @return Schedule
     */
    public function setWorkflow(int $workflow): Schedule
    {
        $this->workflow = $workflow;
        return $this;
    }

}

1		<?php
2
3
4		namespace Pheanstalk\Structure;
5
6
7		class Schedule
8		{
9		const FAILURE_TYPE_CONTINUE = "CONTINUE";
10		const FAILURE_TYPE_SUSPEND = "SUSPEND";
11
12		/** @var int\|null $id */
13		protected $id;
14
15		/** @var bool $active */
16		protected $active;
17
18		/** @var string\|null $comment */
19		protected $comment;
20
21		/** @var string\|null $host */
22		protected $host;
23
24		/** @var string\|null $node */
25		protected $node;
26
27		/** @var string\|null $node */
28		protected $onFailure;
29
30		/** @var TimeSchedule $schedule */
31		protected $schedule;
32
33		/** @var string\|null $user */
34		protected $user;
35
36		/** @var int $workflow */
37		protected $workflow;
38
39	10	public function __construct(
40		int $workflow,
41		TimeSchedule $schedule,
42		$onFailure = self::FAILURE_TYPE_CONTINUE,
43		$active = true,
44		$comment = null,
45		$user = null,
46		$host = null,
47		$node = "any"
48		) {
49	10	$this->workflow = $workflow;
50	10	$this->schedule = $schedule;
51	10	$this->onFailure = $onFailure;
52	10	$this->active = $active;
53	10	$this->comment = $comment;
54	10	$this->user = $user;
55	10	$this->host = $host;
56	10	$this->node = $node;
57		}
58
59		/**
60		* @return int\|null
61		*/
62	2	public function getId(): ?int
63		{
64	2	return $this->id;
65		}
66
67		/**
68		* @param int\|null $id
69		*
70		* @return Schedule
71		*/
72	2	public function setId(?int $id): Schedule
73		{
74	2	$this->id = $id;
75	2	return $this;
76		}
77
78		/**
79		* @return bool
80		*/
81	2	public function isActive(): bool
82		{
83	2	return $this->active;
84		}
85
86		/**
87		* @param bool $active
88		*
89		* @return Schedule
90		*/
91	1	public function setActive(bool $active): Schedule
92		{
93	1	$this->active = $active;
94	1	return $this;
95		}
96
97		/**
98		* @return string\|null
99		*/
100	2	public function getComment(): ?string
101		{
102	2	return $this->comment;
103		}
104
105		/**
106		* @param string\|null $comment
107		*
108		* @return Schedule
109		*/
110	1	public function setComment(?string $comment): Schedule
111		{
112	1	$this->comment = $comment;
113	1	return $this;
114		}
115
116		/**
117		* @return string\|null
118		*/
119	2	public function getHost(): ?string
120		{
121	2	return $this->host;
122		}
123
124		/**
125		* @param string\|null $host
126		*
127		* @return Schedule
128		*/
129	1	public function setHost(?string $host): Schedule
130		{
131	1	$this->host = $host;
132	1	return $this;
133		}
134
135		/**
136		* @return string\|null
137		*/
138	2	public function getNode(): ?string
139		{
140	2	return $this->node;
141		}
142
143		/**
144		* @param string\|null $node
145		*
146		* @return Schedule
147		*/
148	1	public function setNode(?string $node): Schedule
149		{
150	1	$this->node = $node;
151	1	return $this;
152		}
153
154		/**
155		* @return string\|null
156		*/
157	2	public function getOnFailure(): ?string
158		{
159	2	return $this->onFailure;
160		}
161
162		/**
163		* @param string\|null $onFailure
164		*
165		* @return Schedule
166		*/
167	1	public function setOnFailure(?string $onFailure): Schedule
168		{
169	1	$this->onFailure = $onFailure;
170	1	return $this;
171		}
172
173		/**
174		* @return TimeSchedule
175		*/
176	2	public function getSchedule(): TimeSchedule
177		{
178	2	return $this->schedule;
179		}
180
181		/**
182		* @param TimeSchedule $schedule
183		*
184		* @return Schedule
185		*/
186	2	public function setSchedule(TimeSchedule $schedule): Schedule
187		{
188	2	$this->schedule = $schedule;
189	2	return $this;
190		}
191
192		/**
193		* @return string\|null
194		*/
195	2	public function getUser(): ?string
196		{
197	2	return $this->user;
198		}
199
200		/**
201		* @param string\|null $user
202		*
203		* @return Schedule
204		*/
205	1	public function setUser(?string $user): Schedule
206		{
207	1	$this->user = $user;
208	1	return $this;
209		}
210
211		/**
212		* @return int
213		*/
214	2	public function getWorkflow(): int
215		{
216	2	return $this->workflow;
217		}
218
219		/**
220		* @param int $workflow
221		*
222		* @return Schedule
223		*/
224	1	public function setWorkflow(int $workflow): Schedule
225		{
226	1	$this->workflow = $workflow;
227	1	return $this;
228		}
229
230		}

PyRowMan / pheanstalk

Push — master ( ab8b9d...7e5c9a )

Schedule::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like