Pheanstalk\XmlResponseParser

Complexity

Total Complexity

2

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	parseResponse()	0	11	2

<?php

namespace Pheanstalk;

use Pheanstalk\Response\ArrayResponse;

/**
 * A response parser for commands that return a subset of XML.
 *
 * Expected response is 'OK', 'NOT_FOUND' response is also handled.
 * Parser expects either a YAML list or dictionary, depending on mode.
 *
 * @author  Paul Annesley
 * @package Pheanstalk
 * @license http://www.opensource.org/licenses/mit-license.php
 */
class XmlResponseParser implements \Pheanstalk\ResponseParser
{

    /**
     * @param string $responseLine
     * @param string $responseData
     *
     * @throws Exception\ServerException
     * @return Response\ArrayResponse
     */
    public function parseResponse($responseLine, $responseData)
    {
        if ($responseLine == Response::RESPONSE_NOT_FOUND) {
            throw new Exception\ServerException(sprintf(
                'Server reported %s',
                $responseLine
            ));
        }
        unset($responseData['@attributes']);
        $content = $responseData;

The assignment to $content is dead and can be removed.

        return new Response\ArrayResponse('OK', $responseData);

$responseData of type string is incompatible with the type array expected by parameter $data of Pheanstalk\Response\ArrayResponse::__construct().

    }
}