TimeSchedule::__fromString() - Code Metrics - Inspection of "Feature/19" - PyRowMan/pheanstalk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#28)

by Valentin

created 2019-11-25 16:26 UTC

TimeSchedule::__fromString() A

↳ Parent: TimeSchedule

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
eloc	6
c	0
b	0
f	0
dl	0
loc	9
ccs	7
cts	7
cp	1
rs	10
cc	3
nc	3
nop	1
crap	3

<?php


namespace Pheanstalk\Structure;

class TimeSchedule
{
    const SUM_SUBUNIT_IN_UNIT = 1770;
    const SUM_HOURS = 276;
    const SUM_DAYS = 465;
    const SUM_MONTHS = 66;
    const SUM_WEEKDAYS = 21;

    /** @var array[int] $seconds */

    private $seconds;

    /** @var array[int] $minutes */

    private $minutes;

    /** @var array[int] $hours */

    private $hours;

    /** @var array[int] $hours */

    private $days;

    /** @var array[int] $months */

    private $months;

    /** @var array[int] $weekdays */

    private $weekdays;

    /**
     * TimeSchedule constructor.
     *
     * @param array[int] $seconds

     * @param array[int] $minutes
     * @param array[int] $hours
     * @param array[int] $months
     * @param array[int] $weekdays
     */
    public function __construct(array $seconds = [], array $minutes = [], array $hours = [], array $days = [], array $months = [], array $weekdays = [])
    {
        $this
            ->setSeconds($seconds)
            ->setMinutes($minutes)
            ->setHours($hours)
            ->setDays($days)
            ->setMonths($months)
            ->setWeekdays($weekdays)
        ;
    }

    /**
     * @return array[int]

     */
    public function getSeconds(): array
    {
        return $this->seconds;
    }

    /**
     * @param array[int] $seconds

     *
     * @return TimeSchedule
     */
    public function setSeconds(array $seconds): TimeSchedule
    {
        if (count($seconds) !== count(array_filter($seconds, 'is_numeric')) || array_sum($seconds) > self::SUM_SUBUNIT_IN_UNIT) {
            throw new \Exception('Wrong units of time');
        }
        $this->seconds = $seconds;
        return $this;
    }

    /**
     * @return array[int]

     */
    public function getMinutes(): array
    {
        return $this->minutes;
    }

    /**
     * @param array[int] $minutes

     *
     * @return TimeSchedule
     */
    public function setMinutes(array $minutes): TimeSchedule
    {
        if (count($minutes) !== count(array_filter($minutes, 'is_numeric')) || array_sum($minutes) > self::SUM_SUBUNIT_IN_UNIT) {
            throw new \Exception('Wrong units of time');
        }
        $this->minutes = $minutes;
        return $this;
    }

    /**
     * @return array[int]

     */
    public function getHours(): array
    {
        return $this->hours;
    }

    /**
     * @param array[int] $hours

     *
     * @return TimeSchedule
     */
    public function setHours(array $hours): TimeSchedule
    {
        if (count($hours) !== count(array_filter($hours, 'is_numeric')) || array_sum($hours) > self::SUM_HOURS) {
            throw new \Exception('Wrong units of time');
        }
        $this->hours = $hours;
        return $this;
    }

    /**
     * @return array
     */
    public function getDays(): array
    {
        return $this->days;
    }

    /**
     * @param array $days
     *
     * @return TimeSchedule
     */
    public function setDays(array $days): TimeSchedule
    {
        if (count($days) !== count(array_filter($days, 'is_numeric')) || array_sum($days) > self::SUM_DAYS) {
            throw new \Exception('Wrong units of time');
        }
        $this->days = $days;
        return $this;
    }

    /**
     * @return array[int]

     */
    public function getMonths(): array
    {
        return $this->months;
    }

    /**
     * @param array[int] $months

     *
     * @return TimeSchedule
     */
    public function setMonths(array $months): TimeSchedule
    {
        if (count($months) !== count(array_filter($months, 'is_numeric')) || array_sum($months) > self::SUM_MONTHS) {
            throw new \Exception('Wrong units of time');
        }
        $this->months = $months;
        return $this;
    }

    /**
     * @return array[int]

     */
    public function getWeekdays(): array
    {
        return $this->weekdays;
    }

    /**
     * @param array[int] $weekdays

     *
     * @return TimeSchedule
     */
    public function setWeekdays(array $weekdays): TimeSchedule
    {
        $this->weekdays = $weekdays;
        return $this;
    }

    public function __toString()
    {
        return implode(",", $this->getSeconds()).";".
            implode(",", $this->getMinutes()).";".
            implode(",", $this->getHours()).";".
            implode(",", $this->getDays()).";".
            implode(",", $this->getMonths()).";".
            implode(",", $this->getWeekdays())
        ;
    }

    public function __fromString($time)
    {
        $times = explode(';', $time);
        $arrayOfTimes = [];
        foreach ($times as $time) {

            $arrayOfTimes[] = (empty($time)) ? [] : explode(',', $time);
        }
        $this->__construct($arrayOfTimes[0], $arrayOfTimes[1], $arrayOfTimes[2], $arrayOfTimes[3], $arrayOfTimes[4], $arrayOfTimes[5]);
        return $this;
    }
}


1		<?php
2
3
4		namespace Pheanstalk\Structure;
5
6		class TimeSchedule
7		{
8		const SUM_SUBUNIT_IN_UNIT = 1770;
9		const SUM_HOURS = 276;
10		const SUM_DAYS = 465;
11		const SUM_MONTHS = 66;
12		const SUM_WEEKDAYS = 21;
13
14		/** @var array[int] $seconds */
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
15		private $seconds;
16
17		/** @var array[int] $minutes */
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
18		private $minutes;
19
20		/** @var array[int] $hours */
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
21		private $hours;
22
23		/** @var array[int] $hours */
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
24		private $days;
25
26		/** @var array[int] $months */
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
27		private $months;
28
29		/** @var array[int] $weekdays */
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
30		private $weekdays;
31
32		/**
33		* TimeSchedule constructor.
34		*
35		* @param array[int] $seconds
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
36		* @param array[int] $minutes
37		* @param array[int] $hours
38		* @param array[int] $months
39		* @param array[int] $weekdays
40		*/
41	16	public function __construct(array $seconds = [], array $minutes = [], array $hours = [], array $days = [], array $months = [], array $weekdays = [])
42		{
43		$this
44	16	->setSeconds($seconds)
45	16	->setMinutes($minutes)
46	16	->setHours($hours)
47	16	->setDays($days)
48	16	->setMonths($months)
49	16	->setWeekdays($weekdays)
50		;
51		}
52
53		/**
54		* @return array[int]
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
55		*/
56	2	public function getSeconds(): array
57		{
58	2	return $this->seconds;
59		}
60
61		/**
62		* @param array[int] $seconds
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
63		*
64		* @return TimeSchedule
65		*/
66	16	public function setSeconds(array $seconds): TimeSchedule
67		{
68	16	if (count($seconds) !== count(array_filter($seconds, 'is_numeric')) \|\| array_sum($seconds) > self::SUM_SUBUNIT_IN_UNIT) {
69	3	throw new \Exception('Wrong units of time');
70		}
71	16	$this->seconds = $seconds;
72	16	return $this;
73		}
74
75		/**
76		* @return array[int]
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
77		*/
78	2	public function getMinutes(): array
79		{
80	2	return $this->minutes;
81		}
82
83		/**
84		* @param array[int] $minutes
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
85		*
86		* @return TimeSchedule
87		*/
88	16	public function setMinutes(array $minutes): TimeSchedule
89		{
90	16	if (count($minutes) !== count(array_filter($minutes, 'is_numeric')) \|\| array_sum($minutes) > self::SUM_SUBUNIT_IN_UNIT) {
91	1	throw new \Exception('Wrong units of time');
92		}
93	16	$this->minutes = $minutes;
94	16	return $this;
95		}
96
97		/**
98		* @return array[int]
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
99		*/
100	2	public function getHours(): array
101		{
102	2	return $this->hours;
103		}
104
105		/**
106		* @param array[int] $hours
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
107		*
108		* @return TimeSchedule
109		*/
110	16	public function setHours(array $hours): TimeSchedule
111		{
112	16	if (count($hours) !== count(array_filter($hours, 'is_numeric')) \|\| array_sum($hours) > self::SUM_HOURS) {
113	2	throw new \Exception('Wrong units of time');
114		}
115	16	$this->hours = $hours;
116	16	return $this;
117		}
118
119		/**
120		* @return array
121		*/
122	2	public function getDays(): array
123		{
124	2	return $this->days;
125		}
126
127		/**
128		* @param array $days
129		*
130		* @return TimeSchedule
131		*/
132	16	public function setDays(array $days): TimeSchedule
133		{
134	16	if (count($days) !== count(array_filter($days, 'is_numeric')) \|\| array_sum($days) > self::SUM_DAYS) {
135	2	throw new \Exception('Wrong units of time');
136		}
137	16	$this->days = $days;
138	16	return $this;
139		}
140
141		/**
142		* @return array[int]
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
143		*/
144	2	public function getMonths(): array
145		{
146	2	return $this->months;
147		}
148
149		/**
150		* @param array[int] $months
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
151		*
152		* @return TimeSchedule
153		*/
154	16	public function setMonths(array $months): TimeSchedule
155		{
156	16	if (count($months) !== count(array_filter($months, 'is_numeric')) \|\| array_sum($months) > self::SUM_MONTHS) {
157	2	throw new \Exception('Wrong units of time');
158		}
159	16	$this->months = $months;
160	16	return $this;
161		}
162
163		/**
164		* @return array[int]
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
165		*/
166	1	public function getWeekdays(): array
167		{
168	1	return $this->weekdays;
169		}
170
171		/**
172		* @param array[int] $weekdays
		0 ignored issues – show Documentation Bug introduced 2019-07-26 14:57 UTC by Report Bug Copy Issue Report The doc comment `array[int]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history...
173		*
174		* @return TimeSchedule
175		*/
176	16	public function setWeekdays(array $weekdays): TimeSchedule
177		{
178	16	$this->weekdays = $weekdays;
179	16	return $this;
180		}
181
182	1	public function __toString()
183		{
184	1	return implode(",", $this->getSeconds()).";".
185	1	implode(",", $this->getMinutes()).";".
186	1	implode(",", $this->getHours()).";".
187	1	implode(",", $this->getDays()).";".
188	1	implode(",", $this->getMonths()).";".
189	1	implode(",", $this->getWeekdays())
190		;
191		}
192
193	1	public function __fromString($time)
194		{
195	1	$times = explode(';', $time);
196	1	$arrayOfTimes = [];
197	1	foreach ($times as $time) {
		0 ignored issues – show introduced 2019-11-22 16:24 UTC by Report Bug Copy Issue Report `$time` is overwriting one of the parameters of this function. Loading history...
198	1	$arrayOfTimes[] = (empty($time)) ? [] : explode(',', $time);
199		}
200	1	$this->__construct($arrayOfTimes[0], $arrayOfTimes[1], $arrayOfTimes[2], $arrayOfTimes[3], $arrayOfTimes[4], $arrayOfTimes[5]);
201	1	return $this;
202		}
203		}
204

PyRowMan / pheanstalk

Pull Request — master (#28)

TimeSchedule::__fromString() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like