PheanstalkLocator::addPheanstalk() - Code Metrics - Inspection of "Merge pull request #8 from PyRowMan/feature/5" - PyRowMan/pheanstalk-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c86b81...7621ad )

by Valentin

created 2019-11-28 11:42 UTC

PheanstalkLocator::addPheanstalk() A

↳ Parent: PheanstalkLocator

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	3
c	1
b	0
f	0
nc	2
nop	3
dl	0
loc	7
ccs	4
cts	4
cp	1
crap	2
rs	10

<?php

namespace Pyrowman\PheanstalkBundle;

use Pheanstalk\PheanstalkInterface;

class PheanstalkLocator
{
    /**
     * @var PheanstalkInterface[]
     */
    private $pheanstalks;

    /**
     * @var string
     */
    private $default;

    /**
     * Constructor.
     */
    public function __construct()
    {
        $this->pheanstalks = [];
    }

    /**
     * @return PheanstalkInterface[]
     */
    public function getPheanstalks()
    {
        return $this->pheanstalks;
    }

    /**
     * @param string $name
     *
     * @return PheanstalkInterface
     */
    public function getPheanstalk($name = null)
    {
        $name = null !== $name ? $name : $this->default;

        if (array_key_exists($name, $this->pheanstalks)) {
            return $this->pheanstalks[$name];
        }

        return;
    }

    /**
     * @return array
     */
    public function getDefaultPheanstalk()
    {
        return $this->getPheanstalk();

    }

    /**
     * @param string              $name
     * @param PheanstalkInterface $pheanstalk
     * @param bool                $default
     */
    public function addPheanstalk($name, PheanstalkInterface $pheanstalk, bool $default = false)
    {
        $this->pheanstalks[$name] = $pheanstalk;

        // Set the default connection name
        if ($default) {
            $this->default = $name;
        }
    }
}


1		<?php
2
3		namespace Pyrowman\PheanstalkBundle;
4
5		use Pheanstalk\PheanstalkInterface;
6
7		class PheanstalkLocator
8		{
9		/**
10		* @var PheanstalkInterface[]
11		*/
12		private $pheanstalks;
13
14		/**
15		* @var string
16		*/
17		private $default;
18
19		/**
20		* Constructor.
21		*/
22	5	public function __construct()
23		{
24	5	$this->pheanstalks = [];
25		}
26
27		/**
28		* @return PheanstalkInterface[]
29		*/
30	4	public function getPheanstalks()
31		{
32	4	return $this->pheanstalks;
33		}
34
35		/**
36		* @param string $name
37		*
38		* @return PheanstalkInterface
39		*/
40	4	public function getPheanstalk($name = null)
41		{
42	4	$name = null !== $name ? $name : $this->default;
43
44	4	if (array_key_exists($name, $this->pheanstalks)) {
45	3	return $this->pheanstalks[$name];
46		}
47
48	1	return;
49		}
50
51		/**
52		* @return array
53		*/
54	3	public function getDefaultPheanstalk()
55		{
56	3	return $this->getPheanstalk();
		0 ignored issues – show Bug Best Practice introduced 2019-11-26 13:47 UTC by Report Bug Copy Issue Report The expression `return $this->getPheanstalk()` returns the type `Pheanstalk\PheanstalkInterface` which is incompatible with the documented return type `array`. Loading history...
57		}
58
59		/**
60		* @param string $name
61		* @param PheanstalkInterface $pheanstalk
62		* @param bool $default
63		*/
64	4	public function addPheanstalk($name, PheanstalkInterface $pheanstalk, bool $default = false)
65		{
66	4	$this->pheanstalks[$name] = $pheanstalk;
67
68		// Set the default connection name
69	4	if ($default) {
70	3	$this->default = $name;
71		}
72		}
73		}
74

PyRowMan / pheanstalk-bundle

Push — master ( c86b81...7621ad )

PheanstalkLocator::addPheanstalk() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like