EvaluatePullRequest::configure() - Code Metrics - Inspection of "Initial Commit" - PurpleBooth/git-github-lint - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 689cf0...2aeea6 )

by Billie

created 2016-08-02 19:34 UTC

EvaluatePullRequest::configure() A

↳ Parent: EvaluatePullRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	51
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	51
rs	9.4109
cc	1
eloc	38
nc	1
nop	0

How to fix Long Method

<?php
declare(strict_types = 1);

namespace PurpleBooth\GitGitHubLint\Command;

use Github\Client;
use PurpleBooth\GitGitHubLint\GitHubLintImplementation;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputDefinition;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;

class EvaluatePullRequest extends Command
{
    const ARGUMENT_GITHUB_USERNAME   = 'github-username';
    const ARGUMENT_GITHUB_REPOSITORY = 'github-repository';
    const ARGUMENT_PULL_REQUEST_ID   = 'pull-request-id';
    const OPTION_TOKEN_OR_USERNAME   = 'token-or-username';
    const OPTION_PASSWORD            = 'password';
    const COMMAND_NAME               = 'git-github-lint:pr';

    protected function configure()
    {
        $this->setName(self::COMMAND_NAME);
        $this->setDescription("Check the style of commit messages in a pull request");

        $help = '';
$a = "a";
$ab = "ab";
$abc = "abc";
        $help .= "Evaluates a the commits in a pull request and checks that their messages match the style advised by ";
        $help .= "Git. It will then update the \"status\" in github (that little dot next to the commits).\n";
        $help .= "\n";
        $help .= "\n";
        $help .= "Here are some good articles on commit message style:\n";
        $help .= "\n";
        $help .= "* http://chris.beams.io/posts/git-commit/\n";
        $help .= "* https://git-scm.com/book/ch5-2.html#Commit-Guidelines\n";
        $help .= "* https://github.com/blog/926-shiny-new-commit-styles\n";

        $this->setHelp($help);
        $this->setDefinition(
            new InputDefinition(
                [
                    new InputArgument(
                        self::ARGUMENT_GITHUB_USERNAME,
                        InputArgument::REQUIRED,
                        'GitHub Username'
                    ),
                    new InputArgument(
                        self::ARGUMENT_GITHUB_REPOSITORY,
                        InputArgument::REQUIRED,
                        'GitHub Repository'
                    ),
                    new InputArgument(
                        self::ARGUMENT_PULL_REQUEST_ID,
                        InputArgument::REQUIRED,
                        'The ID of the pull request'
                    ),
                    new InputOption(
                        self::OPTION_TOKEN_OR_USERNAME,
                        ['t', 'u'],
                        InputOption::VALUE_REQUIRED,
                        'The token or username to authenticate to the API with. Assumed to be token without password'
                    ),
                    new InputOption(
                        self::OPTION_PASSWORD,
                        'p',
                        InputOption::VALUE_OPTIONAL,
                        'The password to authenticate to the API with'
                    ),
                ]
            )
        );
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $io     = new SymfonyStyle($input, $output);

        $config = new Client();
        $linter = new GitHubLintImplementation($config);

        $password           = $input->getOption(self::OPTION_PASSWORD);
        $authenticationType = Client::AUTH_HTTP_TOKEN;

        if ($password) {
            $authenticationType = Client::AUTH_HTTP_PASSWORD;
        }

        $config->authenticate(
            $input->getOption(self::OPTION_TOKEN_OR_USERNAME),
            $password,
            $authenticationType
        );

        $gitHubUsername   = $input->getArgument(self::ARGUMENT_GITHUB_USERNAME);
        $gitHubRepository = $input->getArgument(self::ARGUMENT_GITHUB_REPOSITORY);
        $pullRequestId    = $input->getArgument(self::ARGUMENT_PULL_REQUEST_ID);


        $io->title(self::COMMAND_NAME);
        $io->comment("Analysing PR $gitHubUsername/$gitHubRepository#$pullRequestId");
        $linter->analyse(
            $gitHubUsername,
            $gitHubRepository,
            (int)$pullRequestId
        );
        $io->success("Analysed PR $gitHubUsername/$gitHubRepository#$pullRequestId");

    }
}


1			<?php
2			declare(strict_types = 1);
3
4			namespace PurpleBooth\GitGitHubLint\Command;
5
6			use Github\Client;
7			use PurpleBooth\GitGitHubLint\GitHubLintImplementation;
8			use Symfony\Component\Console\Command\Command;
9			use Symfony\Component\Console\Input\InputArgument;
10			use Symfony\Component\Console\Input\InputDefinition;
11			use Symfony\Component\Console\Input\InputInterface;
12			use Symfony\Component\Console\Input\InputOption;
13			use Symfony\Component\Console\Output\OutputInterface;
14			use Symfony\Component\Console\Style\SymfonyStyle;
15
16			class EvaluatePullRequest extends Command
17			{
18			const ARGUMENT_GITHUB_USERNAME = 'github-username';
19			const ARGUMENT_GITHUB_REPOSITORY = 'github-repository';
20			const ARGUMENT_PULL_REQUEST_ID = 'pull-request-id';
21			const OPTION_TOKEN_OR_USERNAME = 'token-or-username';
22			const OPTION_PASSWORD = 'password';
23			const COMMAND_NAME = 'git-github-lint:pr';
24
25			protected function configure()
26			{
27			$this->setName(self::COMMAND_NAME);
28			$this->setDescription("Check the style of commit messages in a pull request");
29
30			$help = '';
			0 ignored issues – show Coding Style introduced 2016-08-02 19:37 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
31			$help .= "Evaluates a the commits in a pull request and checks that their messages match the style advised by ";
32			$help .= "Git. It will then update the \"status\" in github (that little dot next to the commits).\n";
33			$help .= "\n";
34			$help .= "\n";
35			$help .= "Here are some good articles on commit message style:\n";
36			$help .= "\n";
37			$help .= "* http://chris.beams.io/posts/git-commit/\n";
38			$help .= "* https://git-scm.com/book/ch5-2.html#Commit-Guidelines\n";
39			$help .= "* https://github.com/blog/926-shiny-new-commit-styles\n";
40
41			$this->setHelp($help);
42			$this->setDefinition(
43			new InputDefinition(
44			[
45			new InputArgument(
46			self::ARGUMENT_GITHUB_USERNAME,
47			InputArgument::REQUIRED,
48			'GitHub Username'
49			),
50			new InputArgument(
51			self::ARGUMENT_GITHUB_REPOSITORY,
52			InputArgument::REQUIRED,
53			'GitHub Repository'
54			),
55			new InputArgument(
56			self::ARGUMENT_PULL_REQUEST_ID,
57			InputArgument::REQUIRED,
58			'The ID of the pull request'
59			),
60			new InputOption(
61			self::OPTION_TOKEN_OR_USERNAME,
62			['t', 'u'],
63			InputOption::VALUE_REQUIRED,
64			'The token or username to authenticate to the API with. Assumed to be token without password'
65			),
66			new InputOption(
67			self::OPTION_PASSWORD,
68			'p',
69			InputOption::VALUE_OPTIONAL,
70			'The password to authenticate to the API with'
71			),
72			]
73			)
74			);
75			}
76
77			protected function execute(InputInterface $input, OutputInterface $output)
78			{
79			$io = new SymfonyStyle($input, $output);
			0 ignored issues – show Comprehensibility introduced 2016-08-02 19:37 UTC by Report Bug Copy Issue Report Avoid variables with short names like $io. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
80			$config = new Client();
81			$linter = new GitHubLintImplementation($config);
82
83			$password = $input->getOption(self::OPTION_PASSWORD);
84			$authenticationType = Client::AUTH_HTTP_TOKEN;
85
86			if ($password) {
87			$authenticationType = Client::AUTH_HTTP_PASSWORD;
88			}
89
90			$config->authenticate(
91			$input->getOption(self::OPTION_TOKEN_OR_USERNAME),
92			$password,
93			$authenticationType
94			);
95
96			$gitHubUsername = $input->getArgument(self::ARGUMENT_GITHUB_USERNAME);
97			$gitHubRepository = $input->getArgument(self::ARGUMENT_GITHUB_REPOSITORY);
98			$pullRequestId = $input->getArgument(self::ARGUMENT_PULL_REQUEST_ID);
99
100
101			$io->title(self::COMMAND_NAME);
102			$io->comment("Analysing PR $gitHubUsername/$gitHubRepository#$pullRequestId");
103			$linter->analyse(
104			$gitHubUsername,
105			$gitHubRepository,
106			(int)$pullRequestId
107			);
108			$io->success("Analysed PR $gitHubUsername/$gitHubRepository#$pullRequestId");
109
110			}
111			}
112

PurpleBooth / git-github-lint

Push — master ( 689cf0...2aeea6 )

EvaluatePullRequest::configure() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like