Authors::add() - Code Metrics - Inspection of "Delete DataMerger and introduce Output objects + m..." - PubPeerFoundation/PublicationDataExtractor - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c3bafb...29fa5f )

by Xavier

created 2018-06-21 16:00 UTC

Authors::add() A

↳ Parent: Authors

Complexity

Conditions	4
Paths	4

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.2
c	0
b	0
f	0
cc	4
eloc	7
nc	4
nop	1

<?php

namespace PubPeerFoundation\PublicationDataExtractor\Models;

class Authors extends Model
{
    /**
     * Hold cherry picked list of authors.
     *
     * @var array
     */
    protected $list = [];

    /**
     * Add unknown authors to the current list.
     *
     * @param $authors
     * @return array
     */
    public function add(array $authors): array
    {
        if (($count = count($authors)) !== ($listCount = count($this->list))) {
            if ($count > $listCount) {
                return $this->list = $authors;
            }

            return $this->list;
        }

        for ($i = 0; $i < $count; ++$i) {
            $this->addUnknownAttributes($authors, $i);
        }

        return $this->list;
    }

    protected function addUnknownAttributes($authors, $i)
    {
        foreach ($authors[$i] as $key => $value) {
            if (empty($value)) {
                continue;
            }
            if (isset($this->list[$i][$key]) && ! empty($this->list[$i][$key])) {
                $this->list[$i][$key] = $value;
            }
        }
    }
}


1			<?php
2
3			namespace PubPeerFoundation\PublicationDataExtractor\Models;
4
5			class Authors extends Model
6			{
7			/**
8			* Hold cherry picked list of authors.
9			*
10			* @var array
11			*/
12			protected $list = [];
13
14			/**
15			* Add unknown authors to the current list.
16			*
17			* @param $authors
18			* @return array
19			*/
20			public function add(array $authors): array
21			{
22			if (($count = count($authors)) !== ($listCount = count($this->list))) {
23			if ($count > $listCount) {
24			return $this->list = $authors;
25			}
26
27			return $this->list;
28			}
29
30			for ($i = 0; $i < $count; ++$i) {
31			$this->addUnknownAttributes($authors, $i);
32			}
33
34			return $this->list;
35			}
36
37			protected function addUnknownAttributes($authors, $i)
38			{
39			foreach ($authors[$i] as $key => $value) {
40			if (empty($value)) {
41			continue;
42			}
43			if (isset($this->list[$i][$key]) && ! empty($this->list[$i][$key])) {
44			$this->list[$i][$key] = $value;
45			}
46			}
47			}
48			}
49

PubPeerFoundation / PublicationDataExtractor

Push — master ( c3bafb...29fa5f )

Authors::add() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like