Status::__construct() - Code Metrics - Inspection of "Implement status endpoint" - PtrTn/battlerite-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e99512...934009 )

by Peter

created 2017-12-02 15:20 UTC

Status::__construct() A

↳ Parent: Status

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	7
cts	7
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	4
crap	1

<?php

namespace PtrTn\Battlerite\Dto;

use DateTime;
use Webmozart\Assert\Assert;

class Status
{
    /**
     * @var string
     */
    public $type;

    /**
     * @var string
     */
    public $id;

    /**
     * @var DateTime
     */
    public $releasedAt;

    /**
     * @var string
     */
    public $version;

    public function __construct(
        string $type,
        string $id,
        DateTime $releasedAt,
        string $version
    ) {
        $this->type = $type;
        $this->type = $type;
        $this->id = $id;
        $this->releasedAt = $releasedAt;
        $this->version = $version;
    }

    public static function createFromArray($status): self
    {
        Assert::string($status['type']);
        Assert::string($status['id']);
        Assert::string($status['attributes']['releasedAt']);
        Assert::string($status['attributes']['version']);

        return new self(
            $status['type'],
            $status['id'],
            DateTime::createFromFormat(DateTime::ISO8601, $status['attributes']['releasedAt']),

            $status['attributes']['version']
        );
    }
}


1		<?php
2
3		namespace PtrTn\Battlerite\Dto;
4
5		use DateTime;
6		use Webmozart\Assert\Assert;
7
8		class Status
9		{
10		/**
11		* @var string
12		*/
13		public $type;
14
15		/**
16		* @var string
17		*/
18		public $id;
19
20		/**
21		* @var DateTime
22		*/
23		public $releasedAt;
24
25		/**
26		* @var string
27		*/
28		public $version;
29
30	1	public function __construct(
31		string $type,
32		string $id,
33		DateTime $releasedAt,
34		string $version
35		) {
36	1	$this->type = $type;
37	1	$this->type = $type;
38	1	$this->id = $id;
39	1	$this->releasedAt = $releasedAt;
40	1	$this->version = $version;
41	1	}
42
43	1	public static function createFromArray($status): self
44		{
45	1	Assert::string($status['type']);
46	1	Assert::string($status['id']);
47	1	Assert::string($status['attributes']['releasedAt']);
48	1	Assert::string($status['attributes']['version']);
49
50	1	return new self(
51	1	$status['type'],
52	1	$status['id'],
53	1	DateTime::createFromFormat(DateTime::ISO8601, $status['attributes']['releasedAt']),
		0 ignored issues – show Security Bug introduced 2017-12-02 15:21 UTC by Report Bug Copy Issue Report It seems like `\DateTime::createFromFor...ibutes']['releasedAt'])` targeting `DateTime::createFromFormat()` can also be of type `false`; however, `PtrTn\Battlerite\Dto\Status::__construct()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? Loading history...
54	1	$status['attributes']['version']
55		);
56		}
57		}
58

PtrTn / battlerite-sdk

Push — master ( e99512...934009 )

Status::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like