Rosters::hasParticipantWon() - Code Metrics - Inspection of "Feature/collection helper methods" - PtrTn/battlerite-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Peter

created 2017-12-17 10:23 UTC

Rosters::hasParticipantWon() A

↳ Parent: Rosters

Complexity

Conditions	4
Paths	4

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4.0312

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	7
cts	8
cp	0.875
rs	9.2
c	0
b	0
f	0
cc	4
eloc	8
nc	4
nop	1
crap	4.0312

<?php

namespace PtrTn\Battlerite\Dto\Match;

use ArrayIterator;
use PtrTn\Battlerite\Dto\CollectionDto;
use RuntimeException;
use Traversable;
use Webmozart\Assert\Assert;

class Rosters extends CollectionDto
{
    /**
     * @var Roster[]
     */
    public $items;

    public function __construct(array $rosters)
    {
        parent::__construct(Roster::class, $rosters);
    }

    public static function createFromArray(array $rosters): self
    {
        Assert::notNull($rosters);

        $createdRosters = [];
        foreach ($rosters as $roster) {
            $createdRosters[] = Roster::createFromArray($roster);
        }
        return new self($createdRosters);
    }

    /**
     * @return Traversable|Roster[]
     */
    public function getIterator(): Traversable
    {
        return new ArrayIterator($this->items);
    }

    public function getWinningRoster(): ?Roster
    {
        foreach ($this->items as $roster) {
            if ($roster->won === true) {
                return $roster;
            }
        }
        return null;
    }

    /**
     * Returns true if participant was victorious
     * Returns false if opponent was victorious
     * Returns null if nobody is victorious
     */
    public function hasParticipantWon(Participant $participant): ?bool
    {
        $winningRoster = $this->getWinningRoster();
        if ($winningRoster === null) {
            return null;
        }

        foreach ($winningRoster->participants as $winningParticipant) {
            if ($winningParticipant->id === $participant->id) {
                return true;
            }
        }
        return false;
    }
}


1		<?php
2
3		namespace PtrTn\Battlerite\Dto\Match;
4
5		use ArrayIterator;
6		use PtrTn\Battlerite\Dto\CollectionDto;
7		use RuntimeException;
8		use Traversable;
9		use Webmozart\Assert\Assert;
10
11		class Rosters extends CollectionDto
12		{
13		/**
14		* @var Roster[]
15		*/
16		public $items;
17
18	6	public function __construct(array $rosters)
19		{
20	6	parent::__construct(Roster::class, $rosters);
21	6	}
22
23		public static function createFromArray(array $rosters): self
24		{
25		Assert::notNull($rosters);
26
27		$createdRosters = [];
28		foreach ($rosters as $roster) {
29		$createdRosters[] = Roster::createFromArray($roster);
30		}
31		return new self($createdRosters);
32		}
33
34		/**
35		* @return Traversable\|Roster[]
36		*/
37		public function getIterator(): Traversable
38		{
39		return new ArrayIterator($this->items);
40		}
41
42	3	public function getWinningRoster(): ?Roster
43		{
44	3	foreach ($this->items as $roster) {
45	3	if ($roster->won === true) {
46	3	return $roster;
47		}
48		}
49		return null;
50		}
51
52		/**
53		* Returns true if participant was victorious
54		* Returns false if opponent was victorious
55		* Returns null if nobody is victorious
56		*/
57	2	public function hasParticipantWon(Participant $participant): ?bool
58		{
59	2	$winningRoster = $this->getWinningRoster();
60	2	if ($winningRoster === null) {
61		return null;
62		}
63
64	2	foreach ($winningRoster->participants as $winningParticipant) {
65	2	if ($winningParticipant->id === $participant->id) {
66	2	return true;
67		}
68		}
69	2	return false;
70		}
71		}
72

PtrTn / battlerite-sdk

Pull Request — master (#3)

Rosters::hasParticipantWon() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like