Roster::createFromArray() - Code Metrics - Inspection of "Updated tests" - PtrTn/battlerite-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bdc105...ec8122 )

by Peter

created 2017-12-07 23:28 UTC

Roster::createFromArray() B

↳ Parent: Roster

Complexity

Conditions	4
Paths	8

Size

Total Lines	25
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	25
ccs	16
cts	16
cp	1
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	16
nc	8
nop	1
crap	4

<?php

namespace PtrTn\Battlerite\Dto\Match;

use Webmozart\Assert\Assert;

class Roster
{
    /**
     * @var string
     */
    public $type;

    /**
     * @var string
     */
    public $id;

    /**
     * @var null|string
     */
    private $shardId;

    /**
     * @var int|null
     */
    private $score;

    /**
     * @var bool|null
     */
    private $won;

    /**
     * @var null|Participants
     */
    private $participants;

    private function __construct(
        string $type,
        string $id,
        ?string $shardId,
        ?int $score,
        ?bool $won,
        ?Participants $participants
    ) {
        $this->type = $type;
        $this->id = $id;
        $this->shardId = $shardId;
        $this->score = $score;
        $this->won = $won;
        $this->participants = $participants;
    }

    public static function createFromArray(array $roster): self
    {
        Assert::string($roster['type']);
        Assert::string($roster['id']);
        if (isset($roster['attributes'])) {
            Assert::nullOrString($roster['attributes']['shardId']);
            Assert::nullOrInteger($roster['attributes']['stats']['score']);
            Assert::nullOrString($roster['attributes']['won']);
        }
        if (isset($roster['relationships']['participants'])) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            // Todo, make a reference / detailed dto for paticipants?
        }

        // Todo, this should probably be a boolean in json.
        $won = $roster['attributes']['won'] ? filter_var($roster['attributes']['won'], FILTER_VALIDATE_BOOLEAN) : null;

        return new self(
            $roster['type'],
            $roster['id'],
            $roster['attributes']['shardId'] ?? null,
            $roster['attributes']['stats']['score'] ?? null,
            $won,
            null
        );
    }
}


1		<?php
2
3		namespace PtrTn\Battlerite\Dto\Match;
4
5		use Webmozart\Assert\Assert;
6
7		class Roster
8		{
9		/**
10		* @var string
11		*/
12		public $type;
13
14		/**
15		* @var string
16		*/
17		public $id;
18
19		/**
20		* @var null\|string
21		*/
22		private $shardId;
23
24		/**
25		* @var int\|null
26		*/
27		private $score;
28
29		/**
30		* @var bool\|null
31		*/
32		private $won;
33
34		/**
35		* @var null\|Participants
36		*/
37		private $participants;
38
39	1	private function __construct(
40		string $type,
41		string $id,
42		?string $shardId,
43		?int $score,
44		?bool $won,
45		?Participants $participants
46		) {
47	1	$this->type = $type;
48	1	$this->id = $id;
49	1	$this->shardId = $shardId;
50	1	$this->score = $score;
51	1	$this->won = $won;
52	1	$this->participants = $participants;
53	1	}
54
55	1	public static function createFromArray(array $roster): self
56		{
57	1	Assert::string($roster['type']);
58	1	Assert::string($roster['id']);
59	1	if (isset($roster['attributes'])) {
60	1	Assert::nullOrString($roster['attributes']['shardId']);
61	1	Assert::nullOrInteger($roster['attributes']['stats']['score']);
62	1	Assert::nullOrString($roster['attributes']['won']);
63		}
64	1	if (isset($roster['relationships']['participants'])) {
		0 ignored issues – show Unused Code introduced 2017-12-07 23:30 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
65		// Todo, make a reference / detailed dto for paticipants?
66		}
67
68		// Todo, this should probably be a boolean in json.
69	1	$won = $roster['attributes']['won'] ? filter_var($roster['attributes']['won'], FILTER_VALIDATE_BOOLEAN) : null;
70
71	1	return new self(
72	1	$roster['type'],
73	1	$roster['id'],
74	1	$roster['attributes']['shardId'] ?? null,
75	1	$roster['attributes']['stats']['score'] ?? null,
76	1	$won,
77	1	null
78		);
79		}
80		}
81

PtrTn / battlerite-sdk

Push — master ( bdc105...ec8122 )

Roster::createFromArray() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like