Player::createFromArray() - Code Metrics - Inspection of "Updated tests" - PtrTn/battlerite-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bdc105...ec8122 )

by Peter

created 2017-12-07 23:28 UTC

Player::createFromArray() A

↳ Parent: Player

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	18
ccs	14
cts	14
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	14
nc	1
nop	1
crap	1

<?php

namespace PtrTn\Battlerite\Dto\Match;

use Webmozart\Assert\Assert;

class Player
{
    /**
     * @var string
     */
    public $type;

    /**
     * @var string
     */
    public $id;

    /**
     * @var string
     */
    public $name;

    /**
     * @var string
     */
    public $patchVersion;

    /**
     * @var string
     */
    public $shardId;

    /**
     * @var string
     */
    public $titleId;

    private function __construct(
        string $type,
        string $id,
        string $name,
        string $patchVersion,
        string $shardId,
        string $titleId
    ) {
        $this->type = $type;
        $this->id = $id;
        $this->name = $name;
        $this->patchVersion = $patchVersion;
        $this->shardId = $shardId;
        $this->titleId = $titleId;
    }

    public static function createFromArray(array $player): self
    {
        Assert::string($player['type']);
        Assert::string($player['id']);
        Assert::string($player['attributes']['name']);
        Assert::string($player['attributes']['patchVersion']);
        Assert::string($player['attributes']['shardId']);
        Assert::string($player['attributes']['titleId']);

        return new self(
            $player['type'],
            $player['id'],
            $player['attributes']['name'],
            $player['attributes']['patchVersion'],
            $player['attributes']['shardId'],
            $player['attributes']['titleId']
        );
    }
}


1		<?php
2
3		namespace PtrTn\Battlerite\Dto\Match;
4
5		use Webmozart\Assert\Assert;
6
7		class Player
8		{
9		/**
10		* @var string
11		*/
12		public $type;
13
14		/**
15		* @var string
16		*/
17		public $id;
18
19		/**
20		* @var string
21		*/
22		public $name;
23
24		/**
25		* @var string
26		*/
27		public $patchVersion;
28
29		/**
30		* @var string
31		*/
32		public $shardId;
33
34		/**
35		* @var string
36		*/
37		public $titleId;
38
39	1	private function __construct(
40		string $type,
41		string $id,
42		string $name,
43		string $patchVersion,
44		string $shardId,
45		string $titleId
46		) {
47	1	$this->type = $type;
48	1	$this->id = $id;
49	1	$this->name = $name;
50	1	$this->patchVersion = $patchVersion;
51	1	$this->shardId = $shardId;
52	1	$this->titleId = $titleId;
53	1	}
54
55	1	public static function createFromArray(array $player): self
56		{
57	1	Assert::string($player['type']);
58	1	Assert::string($player['id']);
59	1	Assert::string($player['attributes']['name']);
60	1	Assert::string($player['attributes']['patchVersion']);
61	1	Assert::string($player['attributes']['shardId']);
62	1	Assert::string($player['attributes']['titleId']);
63
64	1	return new self(
65	1	$player['type'],
66	1	$player['id'],
67	1	$player['attributes']['name'],
68	1	$player['attributes']['patchVersion'],
69	1	$player['attributes']['shardId'],
70	1	$player['attributes']['titleId']
71		);
72		}
73		}
74

PtrTn / battlerite-sdk

Push — master ( bdc105...ec8122 )

Player::createFromArray() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like