EndDateCriterion::checkCollisionWithCriteria() - Code Metrics - Inspection of "Update matches and players queries and matching te..." - PtrTn/battlerite-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 345229...b82efc )

by Peter

created 2017-12-09 10:30 UTC

EndDateCriterion::checkCollisionWithCriteria() A

↳ Parent: EndDateCriterion

Complexity

Conditions	4
Paths	4

Size

Total Lines	11
Code Lines	6

Duplication

Lines	11
Ratio	100 %

Code Coverage

Tests	6
CRAP Score	4

Importance

Changes

Metric	Value
dl	11
loc	11
ccs	6
cts	6
cp	1
rs	9.2
c	0
b	0
f	0
cc	4
eloc	6
nc	4
nop	1
crap	4

<?php

namespace PtrTn\Battlerite\Query\Criterion;

use DateTime;
use PtrTn\Battlerite\Exception\InvalidQueryException;

class EndDateCriterion implements CriterionInterface

{
    /**
     * @var DateTime
     */
    private $endDate;

    public function __construct(DateTime $endDate)
    {
        $this->endDate = $endDate;
    }

    public function toArray(): array
    {
        return ['filter[createdAt-end]' => $this->endDate->format(DateTime::ISO8601)];
    }

    public function checkCollisionWithCriteria(array $critera): void
    {
        foreach ($critera as $criterion) {
            if ($criterion instanceof StartDateCriterion) {
                if ($this->endDate < $criterion->getValue()) {
                    throw InvalidQueryException::criteriaCollision('End date must be later than start date');
                }
            }
        }
        return;
    }

    public function getValue(): DateTime
    {
        return $this->endDate;
    }
}


1			<?php
2
3			namespace PtrTn\Battlerite\Query\Criterion;
4
5			use DateTime;
6			use PtrTn\Battlerite\Exception\InvalidQueryException;
7
8		View Code Duplication	class EndDateCriterion implements CriterionInterface
			0 ignored issues – show Duplication introduced 2017-12-09 10:32 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9			{
10			/**
11			* @var DateTime
12			*/
13			private $endDate;
14
15	3		public function __construct(DateTime $endDate)
16			{
17	3		$this->endDate = $endDate;
18	3		}
19
20	1		public function toArray(): array
21			{
22	1		return ['filter[createdAt-end]' => $this->endDate->format(DateTime::ISO8601)];
23			}
24
25	3		public function checkCollisionWithCriteria(array $critera): void
26			{
27	3		foreach ($critera as $criterion) {
28	2		if ($criterion instanceof StartDateCriterion) {
29	2		if ($this->endDate < $criterion->getValue()) {
30	1		throw InvalidQueryException::criteriaCollision('End date must be later than start date');
31			}
32			}
33			}
34	2		return;
35			}
36
37	1		public function getValue(): DateTime
38			{
39	1		return $this->endDate;
40			}
41			}
42

PtrTn / battlerite-sdk

Push — master ( 345229...b82efc )

EndDateCriterion::checkCollisionWithCriteria() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like