Pterodactyl\Http\Controllers\API\NodeController

Complexity

Total Complexity

18

Size/Duplication

Total Lines	176
Duplicated Lines	10.23 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	lists()	0	4	1
A	create()	0	21	4
B	view()	6	22	5
A	config()	0	9	2
A	allocations()	0	4	1
A	allocationsView()	0	4	1
A	delete()	12	13	3

<?php
/**
 * Pterodactyl - Panel
 * Copyright (c) 2015 - 2017 Dane Everitt <dane@daneeveritt.com>.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

namespace Pterodactyl\Http\Controllers\API;

use Log;
use Pterodactyl\Models;
use Illuminate\Http\Request;
use Dingo\Api\Exception\ResourceException;
use Pterodactyl\Exceptions\DisplayException;
use Pterodactyl\Repositories\NodeRepository;
use Pterodactyl\Exceptions\DisplayValidationException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
use Symfony\Component\HttpKernel\Exception\ServiceUnavailableHttpException;

/**
 * @Resource("Servers")
 */
class NodeController extends BaseController
{
    public function __construct()
    {
        //
    }

    /**
     * List All Nodes.
     *
     * Lists all nodes currently on the system.
     *
     * @Get("/nodes/{?page}")
     * @Versions({"v1"})
     * @Parameters({
     *      @Parameter("page", type="integer", description="The page of results to view.", default=1)
     * })
     * @Response(200)
     */
    public function lists(Request $request)

The parameter $request is not used and could be removed.

    {
        return Models\Node::all()->toArray();
    }

    /**
     * Create a New Node.
     *
     * @Post("/nodes")
     * @Versions({"v1"})
     * @Transaction({
     *      @Request({
     *      	'name' => 'My API Node',
     *      	'location' => 1,
     *      	'public' => 1,
     *      	'fqdn' => 'daemon.wuzzle.woo',
     *      	'scheme' => 'https',
     *      	'memory' => 10240,
     *      	'memory_overallocate' => 100,
     *      	'disk' => 204800,
     *      	'disk_overallocate' => -1,
     *      	'daemonBase' => '/srv/daemon-data',
     *      	'daemonSFTP' => 2022,
     *      	'daemonListen' => 8080
     *      }, headers={"Authorization": "Bearer <jwt-token>"}),
     *       @Response(200),
     *       @Response(422, body={
     *          "message": "A validation error occured.",
     *          "errors": {},
     *          "status_code": 422
     *       }),
     *       @Response(503, body={
     *       	"message": "There was an error while attempting to add this node to the system.",
     *       	"status_code": 503
     *       })
     * })
     */
    public function create(Request $request)
    {
        try {
            $repo = new NodeRepository;
            $node = $repo->create($request->only([

$node is not used, you could remove the assignment.

                'name', 'location_id', 'public', 'fqdn',
                'scheme', 'memory', 'memory_overallocate',
                'disk', 'disk_overallocate', 'daemonBase',
                'daemonSFTP', 'daemonListen',
            ]));

            return ['id' => $repo->id];

The property id does not seem to exist in Pterodactyl\Repositories\NodeRepository.

        } catch (DisplayValidationException $ex) {
            throw new ResourceException('A validation error occured.', json_decode($ex->getMessage(), true));
        } catch (DisplayException $ex) {
            throw new ResourceException($ex->getMessage());
        } catch (\Exception $ex) {
            Log::error($ex);
            throw new BadRequestHttpException('There was an error while attempting to add this node to the system.');
        }
    }

    /**
     * List Specific Node.
     *
     * Lists specific fields about a server or all fields pertaining to that node.
     *
     * @Get("/nodes/{id}/{?fields}")
     * @Versions({"v1"})
     * @Parameters({
     *      @Parameter("id", type="integer", required=true, description="The ID of the node to get information on."),
     *      @Parameter("fields", type="string", required=false, description="A comma delimidated list of fields to include.")
     * })
     * @Response(200)
     */
    public function view(Request $request, $id, $fields = null)

The parameter $fields is not used and could be removed.

    {
        $node = Models\Node::with('allocations')->where('id', $id)->first();

The method where does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

        if (! $node) {
            throw new NotFoundHttpException('No node by that ID was found.');
        }

        $node->allocations->transform(function ($item) {
            return collect($item)->only([
                'id', 'ip', 'ip_alias', 'port', 'server_id',
            ]);
        });

        if (! is_null($request->input('fields'))) {

This code seems to be duplicated across your project.

            $fields = explode(',', $request->input('fields'));
            if (! empty($fields) && is_array($fields)) {
                return collect($node)->only($fields);
            }
        }

        return $node;
    }

    public function config(Request $request, $id)

The parameter $request is not used and could be removed.

    {
        $node = Models\Node::where('id', $id)->first();
        if (! $node) {
            throw new NotFoundHttpException('No node by that ID was found.');
        }

        return $node->getConfigurationAsJson();
    }

     /**
      * List all Node Allocations.
      *
      * Returns a listing of all allocations for every node.
      *
      * @Get("/nodes/allocations")
      * @Versions({"v1"})
      * @Response(200)
      */
     public function allocations(Request $request)

The parameter $request is not used and could be removed.

     {
         return Models\Allocation::all()->toArray();
     }

     /**
      * List Node Allocation based on assigned to ID.
      *
      * Returns a listing of the allocation for the specified server id.
      *
      * @Get("/nodes/allocations/{id}")
      * @Versions({"v1"})
      * @Response(200)
      */
     public function allocationsView(Request $request, $id)

The parameter $request is not used and could be removed.

     {
         return Models\Allocation::where('assigned_to', $id)->get()->toArray();
     }

    /**
     * Delete Node.
     *
     * @Delete("/nodes/{id}")
     * @Versions({"v1"})
     * @Parameters({
     *      @Parameter("id", type="integer", required=true, description="The ID of the node."),
     * })
     * @Response(204)
     */
    public function delete(Request $request, $id)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        try {
            $node = new NodeRepository;
            $node->delete($id);

            return $this->response->noContent();
        } catch (DisplayException $ex) {
            throw new ResourceException($ex->getMessage());
        } catch (\Exception $e) {
            throw new ServiceUnavailableHttpException('An error occured while attempting to delete this node.');
        }
    }
}