Pterodactyl\Repositories\ServerRepository::updateStartup()

Complexity

Conditions	18
Paths	212

Size

Total Lines	108
Code Lines	61

Duplication

Lines	19
Ratio	17.59 %

Importance

Changes

0

<?php
    public function updateStartup($id, array $data, $admin = false)
    {
        $server = Models\Server::with('variables', 'option.variables')->findOrFail($id);

The method findOrFail does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

        DB::beginTransaction();

        try {
            // Check the startup
            if (isset($data['startup'])) {
                $server->startup = $data['startup'];
                $server->save();
            }

            // Check those Variables
            $server->option->variables->transform(function ($item, $key) use ($server) {

The parameter $key is not used and could be removed.

                $displayValue = $server->variables->where('variable_id', $item->id)->pluck('variable_value')->first();
                $item->server_value = (! is_null($displayValue)) ? $displayValue : $item->default_value;

                return $item;
            });

            $variableList = [];
            if ($server->option->variables) {
                foreach ($server->option->variables as &$variable) {
                    // Move on if the new data wasn't even sent
                    if (! isset($data[$variable->env_variable])) {

This code seems to be duplicated across your project.

                        $variableList[] = [
                            'id' => $variable->id,
                            'env' => $variable->env_variable,
                            'val' => $variable->server_value,
                        ];
                        continue;
                    }

                    // Update Empty but skip validation
                    if (empty($data[$variable->env_variable])) {

This code seems to be duplicated across your project.

                        $variableList[] = [
                            'id' => $variable->id,
                            'env' => $variable->env_variable,
                            'val' => null,
                        ];
                        continue;
                    }

                    // Is the variable required?
                    // @TODO: is this even logical to perform this check?
                    if (isset($data[$variable->env_variable]) && empty($data[$variable->env_variable])) {
                        if ($variable->required) {
                            throw new DisplayException('A required service option variable field (' . $variable->env_variable . ') was included in this request but was left blank.');
                        }
                    }

                    // Variable hidden and/or not user editable
                    if ((! $variable->user_viewable || ! $variable->user_editable) && ! $admin) {
                        throw new DisplayException('A service option variable field (' . $variable->env_variable . ') does not exist or you do not have permission to edit it.');
                    }

                    // Check aganist Regex Pattern
                    if (! is_null($variable->regex) && ! preg_match($variable->regex, $data[$variable->env_variable])) {

This code seems to be duplicated across your project.

                        throw new DisplayException('Failed to validate service option variable field (' . $variable->env_variable . ') aganist regex (' . $variable->regex . ').');
                    }

                    $variableList[] = [
                        'id' => $variable->id,
                        'env' => $variable->env_variable,
                        'val' => $data[$variable->env_variable],
                    ];
                }
            }

            // Add Variables
            $environmentVariables = [
                'STARTUP' => $server->startup,
            ];
            foreach ($variableList as $item) {
                $environmentVariables[$item['env']] = $item['val'];

                // Update model or make a new record if it doesn't exist.
                $model = Models\ServerVariable::firstOrNew([
                    'variable_id' => $item['id'],
                    'server_id' => $server->id,
                ]);
                $model->variable_value = $item['val'];
                $model->save();
            }

            $server->node->guzzleClient([
                'X-Access-Server' => $server->uuid,
                'X-Access-Token' => $server->node->daemonSecret,
            ])->request('PATCH', '/server', [
                'json' => [
                    'build' => [
                        'env|overwrite' => $environmentVariables,
                    ],
                ],
            ]);

            DB::commit();

            return true;
        } catch (TransferException $ex) {
            DB::rollBack();
            throw new DisplayException('An error occured while attempting to update the server configuration.', $ex);
        } catch (\Exception $ex) {
            DB::rollBack();
            throw $ex;
        }
    }