PackController::formatServices() - Code Metrics - Inspection of "Implementation of improved Model logic and relatio..." - Pterodactyl/Panel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#286)

by Dane

created 2017-02-12 21:26 UTC

PackController::formatServices() A

↳ Parent: PackController

Complexity

Conditions	3
Paths	3

Size

Total Lines	22
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	9.2
c	0
b	0
f	0
cc	3
eloc	14
nc	3
nop	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	PackController::listByOption()	0	6	1
A	PackController::listByService()	0	6	1

<?php
/**
 * Pterodactyl - Panel
 * Copyright (c) 2015 - 2017 Dane Everitt <[email protected]>.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

namespace Pterodactyl\Http\Controllers\Admin;

use Log;
use Alert;
use Storage;
use Pterodactyl\Models;
use Illuminate\Http\Request;
use Pterodactyl\Exceptions\DisplayException;
use Pterodactyl\Http\Controllers\Controller;
use Pterodactyl\Repositories\ServiceRepository\Pack;
use Pterodactyl\Exceptions\DisplayValidationException;

class PackController extends Controller
{
    public function __construct()
    {
        //
    }

    public function listAll(Request $request)

    {
        return view('admin.services.packs.index', ['services' => Models\Service::all()]);
    }

    public function listByOption(Request $request, $id)

    {
        return view('admin.services.packs.byoption', [
            'option' => Models\ServiceOption::with('service', 'packs')->findOrFail($id),
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        ]);
    }

    public function listByService(Request $request, $id)

    {
        return view('admin.services.packs.byservice', [
            'service' => Models\Service::with('options', 'options.packs')->findOrFail($id),
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        ]);
    }

    public function new(Request $request, $opt = null)

    {
        return view('admin.services.packs.new', [
            'services' => Models\Service::with('options')->get(),
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        ]);
    }

    public function create(Request $request)
    {
        try {
            $repo = new Pack;
            $pack = $repo->create($request->only([
                'name', 'version', 'description',
                'option', 'selectable', 'visible',
                'file_upload',
            ]));
            Alert::success('Successfully created new service!')->flash();

            return redirect()->route('admin.services.packs.edit', $pack->id)->withInput();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } catch (DisplayValidationException $ex) {
            return redirect()->route('admin.services.packs.new', $request->input('option'))->withErrors(json_decode($ex->getMessage()))->withInput();

        } catch (DisplayException $ex) {
            Alert::danger($ex->getMessage())->flash();
        } catch (\Exception $ex) {
            Log::error($ex);
            Alert::danger('An error occured while attempting to add a new service pack.')->flash();
        }

        return redirect()->route('admin.services.packs.new', $request->input('option'))->withInput();

    }

    public function edit(Request $request, $id)

    {
        $pack = Models\ServicePack::with('option.service')->findOrFail($id);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return view('admin.services.packs.edit', [
            'pack' => $pack,
            'services' => Models\Service::all()->load('options'),
            'files' => Storage::files('packs/' . $pack->uuid),

        ]);
    }

    public function update(Request $request, $id)
    {
        if (! is_null($request->input('action_delete'))) {
            try {
                $repo = new Pack;
                $repo->delete($id);
                Alert::success('The requested service pack has been deleted from the system.')->flash();

                return redirect()->route('admin.services.packs');
            } catch (DisplayException $ex) {
                Alert::danger($ex->getMessage())->flash();
            } catch (\Exception $ex) {
                Log::error($ex);
                Alert::danger('An error occured while attempting to delete this pack.')->flash();
            }

            return redirect()->route('admin.services.packs.edit', $id);
        } else {
            try {
                $repo = new Pack;
                $repo->update($id, $request->only([
                    'name', 'version', 'description',
                    'option', 'selectable', 'visible',
                ]));
                Alert::success('Service pack has been successfully updated.')->flash();
            } catch (DisplayValidationException $ex) {
                return redirect()->route('admin.services.packs.edit', $id)->withErrors(json_decode($ex->getMessage()))->withInput();
            } catch (\Exception $ex) {
                Log::error($ex);
                Alert::danger('An error occured while attempting to add edit this pack.')->flash();
            }

            return redirect()->route('admin.services.packs.edit', $id);
        }
    }

    public function export(Request $request, $id, $files = false)

    {
        $pack = Models\ServicePack::findOrFail($id);
        $json = [
            'name' => $pack->name,
            'version' => $pack->version,
            'description' => $pack->dscription,
            'selectable' => (bool) $pack->selectable,
            'visible' => (bool) $pack->visible,
        ];

        $filename = tempnam(sys_get_temp_dir(), 'pterodactyl_');
        if ((bool) $files) {
            $zip = new \ZipArchive;
            if (! $zip->open($filename, \ZipArchive::CREATE)) {
                abort(503, 'Unable to open file for writing.');
            }

            $files = Storage::files('packs/' . $pack->uuid);

            foreach ($files as $file) {
                $zip->addFile(storage_path('app/' . $file), basename(storage_path('app/' . $file)));
            }

            $zip->addFromString('import.json', json_encode($json, JSON_PRETTY_PRINT));
            $zip->close();

            return response()->download($filename, 'pack-' . $pack->name . '.zip')->deleteFileAfterSend(true);
        } else {
            $fp = fopen($filename, 'a+');
            fwrite($fp, json_encode($json, JSON_PRETTY_PRINT));
            fclose($fp);

            return response()->download($filename, 'pack-' . $pack->name . '.json', [
                'Content-Type' => 'application/json',
            ])->deleteFileAfterSend(true);
        }
    }

    public function uploadForm(Request $request, $for = null)

    {
        return view('admin.services.packs.upload', [
            'services' => Models\Service::all()->load('options'),
        ]);
    }

    public function postUpload(Request $request)

    {
        try {
            $repo = new Pack;
            $pack = $repo->createWithTemplate($request->only(['option', 'file_upload']));
            Alert::success('Successfully created new service!')->flash();

            return redirect()->route('admin.services.packs.edit', $pack->id)->withInput();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } catch (DisplayValidationException $ex) {
            return redirect()->back()->withErrors(json_decode($ex->getMessage()))->withInput();
        } catch (DisplayException $ex) {
            Alert::danger($ex->getMessage())->flash();
        } catch (\Exception $ex) {
            Log::error($ex);
            Alert::danger('An error occured while attempting to add a new service pack.')->flash();
        }

        return redirect()->back();
    }
}


GitHub Access Token became invalid

Pull Request — develop (#286)

PackController::formatServices() A

Complexity

Size

Duplication

Importance

2 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2		/**
3		* Pterodactyl - Panel
4		* Copyright (c) 2015 - 2017 Dane Everitt <[email protected]>.
5		*
6		* Permission is hereby granted, free of charge, to any person obtaining a copy
7		* of this software and associated documentation files (the "Software"), to deal
8		* in the Software without restriction, including without limitation the rights
9		* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10		* copies of the Software, and to permit persons to whom the Software is
11		* furnished to do so, subject to the following conditions:
12		*
13		* The above copyright notice and this permission notice shall be included in all
14		* copies or substantial portions of the Software.
15		*
16		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17		* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18		* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19		* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20		* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21		* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
22		* SOFTWARE.
23		*/
24
25		namespace Pterodactyl\Http\Controllers\Admin;
26
27		use Log;
28		use Alert;
29		use Storage;
30		use Pterodactyl\Models;
31		use Illuminate\Http\Request;
32		use Pterodactyl\Exceptions\DisplayException;
33		use Pterodactyl\Http\Controllers\Controller;
34		use Pterodactyl\Repositories\ServiceRepository\Pack;
35		use Pterodactyl\Exceptions\DisplayValidationException;
36
37		class PackController extends Controller
38		{
39		public function __construct()
40		{
41		//
42		}
43
44		public function listAll(Request $request)
		0 ignored issues – show Unused Code introduced 2017-01-12 20:50 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
45		{
46		return view('admin.services.packs.index', ['services' => Models\Service::all()]);
47		}
48
49		public function listByOption(Request $request, $id)
		0 ignored issues – show Unused Code introduced 2017-01-12 20:50 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
50		{
51		return view('admin.services.packs.byoption', [
52		'option' => Models\ServiceOption::with('service', 'packs')->findOrFail($id),
		0 ignored issues – show Bug introduced 2017-02-05 23:03 UTC by Report Bug Copy Issue Report The method `findOrFail` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
53		]);
54		}
55
56		public function listByService(Request $request, $id)
		0 ignored issues – show Unused Code introduced 2017-01-12 20:50 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
57		{
58		return view('admin.services.packs.byservice', [
59		'service' => Models\Service::with('options', 'options.packs')->findOrFail($id),
		0 ignored issues – show Bug introduced 2017-02-05 23:03 UTC by Report Bug Copy Issue Report The method `findOrFail` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
60		]);
61		}
62
63		public function new(Request $request, $opt = null)
		0 ignored issues – show Unused Code introduced 2017-01-12 20:50 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-02-05 23:03 UTC by Report Bug Copy Issue Report The parameter `$opt` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
64		{
65		return view('admin.services.packs.new', [
66		'services' => Models\Service::with('options')->get(),
		0 ignored issues – show Bug introduced 2017-02-05 23:03 UTC by Report Bug Copy Issue Report The method `get` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
67		]);
68		}
69
70		public function create(Request $request)
71		{
72		try {
73		$repo = new Pack;
74		$pack = $repo->create($request->only([
75		'name', 'version', 'description',
76		'option', 'selectable', 'visible',
77		'file_upload',
78		]));
79		Alert::success('Successfully created new service!')->flash();
80
81		return redirect()->route('admin.services.packs.edit', $pack->id)->withInput();
		0 ignored issues – show Documentation introduced 2017-02-05 23:03 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Pterodactyl\Models\ServicePack>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
82		} catch (DisplayValidationException $ex) {
83		return redirect()->route('admin.services.packs.new', $request->input('option'))->withErrors(json_decode($ex->getMessage()))->withInput();
		0 ignored issues – show Bug introduced 2017-01-12 20:50 UTC by Report Bug Copy Issue Report It seems like `$request->input('option')` targeting `Illuminate\Http\Request::input()` can also be of type `string`; however, `Illuminate\Routing\Redirector::route()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
84		} catch (DisplayException $ex) {
85		Alert::danger($ex->getMessage())->flash();
86		} catch (\Exception $ex) {
87		Log::error($ex);
88		Alert::danger('An error occured while attempting to add a new service pack.')->flash();
89		}
90
91		return redirect()->route('admin.services.packs.new', $request->input('option'))->withInput();
		0 ignored issues – show Bug introduced 2017-01-12 20:50 UTC by Report Bug Copy Issue Report It seems like `$request->input('option')` targeting `Illuminate\Http\Request::input()` can also be of type `string`; however, `Illuminate\Routing\Redirector::route()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
92		}
93
94		public function edit(Request $request, $id)
		0 ignored issues – show Unused Code introduced 2017-01-12 20:50 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
95		{
96		$pack = Models\ServicePack::with('option.service')->findOrFail($id);
		0 ignored issues – show Bug introduced 2017-02-05 23:03 UTC by Report Bug Copy Issue Report The method `findOrFail` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
97
98		return view('admin.services.packs.edit', [
99		'pack' => $pack,
100		'services' => Models\Service::all()->load('options'),
101		'files' => Storage::files('packs/' . $pack->uuid),
		0 ignored issues – show Bug introduced 2017-01-12 20:50 UTC by Report Bug Copy Issue Report The method `files()` does not seem to exist on `object<Illuminate\Contracts\Filesystem\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
102		]);
103		}
104
105		public function update(Request $request, $id)
106		{
107		if (! is_null($request->input('action_delete'))) {
108		try {
109		$repo = new Pack;
110		$repo->delete($id);
111		Alert::success('The requested service pack has been deleted from the system.')->flash();
112
113		return redirect()->route('admin.services.packs');
114		} catch (DisplayException $ex) {
115		Alert::danger($ex->getMessage())->flash();
116		} catch (\Exception $ex) {
117		Log::error($ex);
118		Alert::danger('An error occured while attempting to delete this pack.')->flash();
119		}
120
121		return redirect()->route('admin.services.packs.edit', $id);
122		} else {
123		try {
124		$repo = new Pack;
125		$repo->update($id, $request->only([
126		'name', 'version', 'description',
127		'option', 'selectable', 'visible',
128		]));
129		Alert::success('Service pack has been successfully updated.')->flash();
130		} catch (DisplayValidationException $ex) {
131		return redirect()->route('admin.services.packs.edit', $id)->withErrors(json_decode($ex->getMessage()))->withInput();
132		} catch (\Exception $ex) {
133		Log::error($ex);
134		Alert::danger('An error occured while attempting to add edit this pack.')->flash();
135		}
136
137		return redirect()->route('admin.services.packs.edit', $id);
138		}
139		}
140
141		public function export(Request $request, $id, $files = false)
		0 ignored issues – show Unused Code introduced 2017-01-12 20:50 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
142		{
143		$pack = Models\ServicePack::findOrFail($id);
144		$json = [
145		'name' => $pack->name,
146		'version' => $pack->version,
147		'description' => $pack->dscription,
148		'selectable' => (bool) $pack->selectable,
149		'visible' => (bool) $pack->visible,
150		];
151
152		$filename = tempnam(sys_get_temp_dir(), 'pterodactyl_');
153		if ((bool) $files) {
154		$zip = new \ZipArchive;
155		if (! $zip->open($filename, \ZipArchive::CREATE)) {
156		abort(503, 'Unable to open file for writing.');
157		}
158
159		$files = Storage::files('packs/' . $pack->uuid);
		0 ignored issues – show Bug introduced 2017-01-12 20:50 UTC by Report Bug Copy Issue Report The method `files()` does not seem to exist on `object<Illuminate\Contracts\Filesystem\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
160		foreach ($files as $file) {
161		$zip->addFile(storage_path('app/' . $file), basename(storage_path('app/' . $file)));
162		}
163
164		$zip->addFromString('import.json', json_encode($json, JSON_PRETTY_PRINT));
165		$zip->close();
166
167		return response()->download($filename, 'pack-' . $pack->name . '.zip')->deleteFileAfterSend(true);
168		} else {
169		$fp = fopen($filename, 'a+');
170		fwrite($fp, json_encode($json, JSON_PRETTY_PRINT));
171		fclose($fp);
172
173		return response()->download($filename, 'pack-' . $pack->name . '.json', [
174		'Content-Type' => 'application/json',
175		])->deleteFileAfterSend(true);
176		}
177		}
178
179		public function uploadForm(Request $request, $for = null)
		0 ignored issues – show Unused Code introduced 2017-01-12 20:50 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-02-05 23:03 UTC by Report Bug Copy Issue Report The parameter `$for` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
180		{
181		return view('admin.services.packs.upload', [
182		'services' => Models\Service::all()->load('options'),
183		]);
184		}
185
186	View Code Duplication	public function postUpload(Request $request)
		0 ignored issues – show Duplication introduced 2017-01-12 20:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
187		{
188		try {
189		$repo = new Pack;
190		$pack = $repo->createWithTemplate($request->only(['option', 'file_upload']));
191		Alert::success('Successfully created new service!')->flash();
192
193		return redirect()->route('admin.services.packs.edit', $pack->id)->withInput();
		0 ignored issues – show Documentation introduced 2017-02-05 23:03 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Pterodactyl\Models\ServicePack>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
194		} catch (DisplayValidationException $ex) {
195		return redirect()->back()->withErrors(json_decode($ex->getMessage()))->withInput();
196		} catch (DisplayException $ex) {
197		Alert::danger($ex->getMessage())->flash();
198		} catch (\Exception $ex) {
199		Log::error($ex);
200		Alert::danger('An error occured while attempting to add a new service pack.')->flash();
201		}
202
203		return redirect()->back();
204		}
205		}
206

Pterodactyl / Panel

GitHub Access Token became invalid

Pull Request — develop (#286)

PackController::formatServices() A

Complexity

Size

Duplication

Importance

2 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like