Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
30 | View Code Duplication | class Subuser extends Model |
|
|
|||
31 | { |
||
32 | /** |
||
33 | * The table associated with the model. |
||
34 | * |
||
35 | * @var string |
||
36 | */ |
||
37 | protected $table = 'subusers'; |
||
38 | |||
39 | /** |
||
40 | * The attributes excluded from the model's JSON form. |
||
41 | * |
||
42 | * @var array |
||
43 | */ |
||
44 | protected $hidden = ['daemonSecret']; |
||
45 | |||
46 | /** |
||
47 | * Fields that are not mass assignable. |
||
48 | * |
||
49 | * @var array |
||
50 | */ |
||
51 | protected $guarded = ['id', 'created_at', 'updated_at']; |
||
52 | |||
53 | /** |
||
54 | * Cast values to correct type. |
||
55 | * |
||
56 | * @var array |
||
57 | */ |
||
58 | protected $casts = [ |
||
59 | 'user_id' => 'integer', |
||
60 | 'server_id' => 'integer', |
||
61 | ]; |
||
62 | |||
63 | /** |
||
64 | * Gets the server associated with a subuser. |
||
65 | * |
||
66 | * @return \Illuminate\Database\Eloquent\Relations\BelongsTo |
||
67 | */ |
||
68 | public function server() |
||
72 | |||
73 | /** |
||
74 | * Gets the user associated with a subuser. |
||
75 | * |
||
76 | * @return \Illuminate\Database\Eloquent\Relations\BelongsTo |
||
77 | */ |
||
78 | public function user() |
||
82 | |||
83 | /** |
||
84 | * Gets the permissions associated with a subuser. |
||
85 | * |
||
86 | * @return \Illuminate\Database\Eloquent\Relations\HasMany |
||
87 | */ |
||
88 | public function permissions() |
||
92 | } |
||
93 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.