RebuildServer::handle() - Code Metrics - Inspection of "Add support for rebuilding servers from the consol..." - Pterodactyl/Panel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 9a803e...9a581e )

by Dane

created 2017-03-18 19:26 UTC

RebuildServer::handle() B

↳ Parent: RebuildServer

Complexity

Conditions	7
Paths	13

Size

Total Lines	57
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	57
rs	7.6759
cc	7
eloc	39
nc	13
nop	0

How to fix Long Method

<?php
/**
 * Pterodactyl - Panel
 * Copyright (c) 2015 - 2017 Dane Everitt <[email protected]>.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

namespace Pterodactyl\Console\Commands;

use Pterodactyl\Models\Node;
use Pterodactyl\Models\Server;
use Illuminate\Console\Command;

class RebuildServer extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'pterodactyl:rebuild
                            {--all}
                            {--node= : Id of node to rebuild all servers on.}
                            {--server= : UUID of server to rebuild.}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Rebuild docker containers for a server or multiple servers.';

    /**
     * Create a new command instance.
     *
     * @return void

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        if ($this->option('all')) {
            $servers = Server::with('node')->get();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        } elseif ($this->option('node')) {
            $servers = Server::with('node')->where('node_id', $this->option('node'))->get();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        } elseif ($this->option('server')) {
            $servers = Server::with('node')->where('id', $this->option('server'))->get();
        } else {
            $this->error('You must pass a flag to determine which server(s) to rebuild.');
            return;
        }

        $this->line('Beginning processing, do not exit this script.');
        $bar = $this->output->createProgressBar(count($servers));
        $results = collect([]);
        foreach($servers as $server) {
            try {
                $server->node->guzzleClient([
                    'X-Access-Server' => $server->uuid,
                    'X-Access-Token' => $server->node->daemonSecret,
                ])->request('POST', '/server/rebuild');

                $results = $results->merge([
                    $server->uuid => [
                        'status' => 'info',
                        'messages' => [
                                '[✓] Processed rebuild request for ' . $server->uuid,
                        ],
                    ],
                ]);
            } catch (\Exception $ex) {
                $results = $results->merge([
                    $server->uuid => [
                        'status' => 'error',
                        'messages' => [
                            '[✗] Failed to process rebuild request for ' . $server->uuid,
                            $ex->getMessage(),
                        ],
                    ],
                ]);
            }

            $bar->advance();
        }

        $bar->finish();
        $console = $this;

        $this->line("\n");
        $results->each(function ($item, $key) use ($console) {

            foreach($item['messages'] as $line) {
                $console->{$item['status']}($line);
            }
        });
        $this->line("\nCompleted rebuild command processing.");
    }
}


GitHub Access Token became invalid

Push — develop ( 9a803e...9a581e )

RebuildServer::handle() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

1			<?php
2			/**
3			* Pterodactyl - Panel
4			* Copyright (c) 2015 - 2017 Dane Everitt <[email protected]>.
5			*
6			* Permission is hereby granted, free of charge, to any person obtaining a copy
7			* of this software and associated documentation files (the "Software"), to deal
8			* in the Software without restriction, including without limitation the rights
9			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10			* copies of the Software, and to permit persons to whom the Software is
11			* furnished to do so, subject to the following conditions:
12			*
13			* The above copyright notice and this permission notice shall be included in all
14			* copies or substantial portions of the Software.
15			*
16			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
22			* SOFTWARE.
23			*/
24
25			namespace Pterodactyl\Console\Commands;
26
27			use Pterodactyl\Models\Node;
28			use Pterodactyl\Models\Server;
29			use Illuminate\Console\Command;
30
31			class RebuildServer extends Command
32			{
33			/**
34			* The name and signature of the console command.
35			*
36			* @var string
37			*/
38			protected $signature = 'pterodactyl:rebuild
39			{--all}
40			{--node= : Id of node to rebuild all servers on.}
41			{--server= : UUID of server to rebuild.}';
42
43			/**
44			* The console command description.
45			*
46			* @var string
47			*/
48			protected $description = 'Rebuild docker containers for a server or multiple servers.';
49
50			/**
51			* Create a new command instance.
52			*
53			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-03-18 19:28 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
54			*/
55			public function __construct()
56			{
57			parent::__construct();
58			}
59
60			/**
61			* Execute the console command.
62			*
63			* @return mixed
64			*/
65			public function handle()
66			{
67			if ($this->option('all')) {
68			$servers = Server::with('node')->get();
			0 ignored issues – show Bug introduced 2017-03-18 19:28 UTC by Report Bug Copy Issue Report The method `get` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
69			} elseif ($this->option('node')) {
70			$servers = Server::with('node')->where('node_id', $this->option('node'))->get();
			0 ignored issues – show Bug introduced 2017-03-18 19:28 UTC by Report Bug Copy Issue Report The method `where` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
71			} elseif ($this->option('server')) {
72			$servers = Server::with('node')->where('id', $this->option('server'))->get();
73			} else {
74			$this->error('You must pass a flag to determine which server(s) to rebuild.');
75			return;
76			}
77
78			$this->line('Beginning processing, do not exit this script.');
79			$bar = $this->output->createProgressBar(count($servers));
80			$results = collect([]);
81			foreach($servers as $server) {
82			try {
83			$server->node->guzzleClient([
84			'X-Access-Server' => $server->uuid,
85			'X-Access-Token' => $server->node->daemonSecret,
86			])->request('POST', '/server/rebuild');
87
88			$results = $results->merge([
89			$server->uuid => [
90			'status' => 'info',
91			'messages' => [
92			'[✓] Processed rebuild request for ' . $server->uuid,
93			],
94			],
95			]);
96			} catch (\Exception $ex) {
97			$results = $results->merge([
98			$server->uuid => [
99			'status' => 'error',
100			'messages' => [
101			'[✗] Failed to process rebuild request for ' . $server->uuid,
102			$ex->getMessage(),
103			],
104			],
105			]);
106			}
107
108			$bar->advance();
109			}
110
111			$bar->finish();
112			$console = $this;
113
114			$this->line("\n");
115			$results->each(function ($item, $key) use ($console) {
			0 ignored issues – show Unused Code introduced 2017-03-18 19:28 UTC by Report Bug Copy Issue Report The parameter `$key` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
116			foreach($item['messages'] as $line) {
117			$console->{$item['status']}($line);
118			}
119			});
120			$this->line("\nCompleted rebuild command processing.");
121			}
122			}
123

Pterodactyl / Panel

GitHub Access Token became invalid

Push — develop ( 9a803e...9a581e )

RebuildServer::handle() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like