Pterodactyl\Http\Controllers\Admin\PackController

Complexity

Total Complexity

28

Size/Duplication

Total Lines	215
Duplicated Lines	19.53 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes

0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	formatServices()	10	22	3
A	listAll()	0	6	1
A	listByOption()	0	10	1
A	listByService()	11	11	1
A	new()	0	7	1
A	create()	0	21	4
A	edit()	0	13	1
B	update()	0	34	6
B	export()	0	45	4
A	uploadForm()	0	7	1
A	postUpload()	21	21	4

<?php
/**
 * Pterodactyl - Panel
 * Copyright (c) 2015 - 2016 Dane Everitt <dane@daneeveritt.com>.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

namespace Pterodactyl\Http\Controllers\Admin;

use DB;
use Log;
use Alert;
use Storage;
use Pterodactyl\Models;
use Illuminate\Http\Request;
use Pterodactyl\Exceptions\DisplayException;
use Pterodactyl\Http\Controllers\Controller;
use Pterodactyl\Repositories\ServiceRepository\Pack;
use Pterodactyl\Exceptions\DisplayValidationException;

class PackController extends Controller
{
    public function __construct()
    {
        //
    }

    protected function formatServices()
    {
        $options = Models\ServiceOptions::select(
            'services.name AS p_service',
            'service_options.id',
            'service_options.name'
        )->join('services', 'services.id', '=', 'service_options.parent_service')->get();

        $array = [];
        foreach ($options as &$option) {

This code seems to be duplicated across your project.

            if (! array_key_exists($option->p_service, $array)) {
                $array[$option->p_service] = [];
            }

            $array[$option->p_service] = array_merge($array[$option->p_service], [[
                'id' => $option->id,
                'name' => $option->name,
            ]]);
        }

        return $array;
    }

    public function listAll(Request $request)

The parameter $request is not used and could be removed.

    {
        return view('admin.services.packs.index', [
            'services' => Models\Service::all(),
        ]);
    }

    public function listByOption(Request $request, $id)

The parameter $request is not used and could be removed.

    {
        $option = Models\ServiceOptions::findOrFail($id);

        return view('admin.services.packs.byoption', [
            'packs' => Models\ServicePack::where('option', $option->id)->get(),
            'service' => Models\Service::findOrFail($option->parent_service),
            'option' => $option,
        ]);
    }

    public function listByService(Request $request, $id)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        return view('admin.services.packs.byservice', [
            'service' => Models\Service::findOrFail($id),
            'options' => Models\ServiceOptions::select(
                'service_options.id',
                'service_options.name',
                DB::raw('(SELECT COUNT(id) FROM service_packs WHERE service_packs.option = service_options.id) AS p_count')
            )->where('parent_service', $id)->get(),
        ]);
    }

    public function new(Request $request, $opt = null)

The parameter $request is not used and could be removed.

    {
        return view('admin.services.packs.new', [
            'services' => $this->formatServices(),
            'packFor' => $opt,
        ]);
    }

    public function create(Request $request)
    {
        try {
            $repo = new Pack;
            $id = $repo->create($request->except([
                '_token',
            ]));
            Alert::success('Successfully created new service!')->flash();

            return redirect()->route('admin.services.packs.edit', $id)->withInput();
        } catch (DisplayValidationException $ex) {
            return redirect()->route('admin.services.packs.new', $request->input('option'))->withErrors(json_decode($ex->getMessage()))->withInput();

It seems like $request->input('option') targeting Illuminate\Http\Request::input() can also be of type string; however, Illuminate\Routing\Redirector::route() does only seem to accept array, maybe add an additional type check?

        } catch (DisplayException $ex) {
            Alert::danger($ex->getMessage())->flash();
        } catch (\Exception $ex) {
            Log::error($ex);
            Alert::danger('An error occured while attempting to add a new service pack.')->flash();
        }

        return redirect()->route('admin.services.packs.new', $request->input('option'))->withInput();

It seems like $request->input('option') targeting Illuminate\Http\Request::input() can also be of type string; however, Illuminate\Routing\Redirector::route() does only seem to accept array, maybe add an additional type check?

    }

    public function edit(Request $request, $id)

The parameter $request is not used and could be removed.

    {
        $pack = Models\ServicePack::findOrFail($id);
        $option = Models\ServiceOptions::select('id', 'parent_service', 'name')->where('id', $pack->option)->first();

        return view('admin.services.packs.edit', [
            'pack' => $pack,
            'services' => $this->formatServices(),
            'files' => Storage::files('packs/' . $pack->uuid),

The method files() does not seem to exist on object<Illuminate\Contracts\Filesystem\Factory>.

            'service' => Models\Service::findOrFail($option->parent_service),
            'option' => $option,
        ]);
    }

    public function update(Request $request, $id)
    {
        if (! is_null($request->input('action_delete'))) {
            try {
                $repo = new Pack;
                $repo->delete($id);
                Alert::success('The requested service pack has been deleted from the system.')->flash();

                return redirect()->route('admin.services.packs');
            } catch (DisplayException $ex) {
                Alert::danger($ex->getMessage())->flash();
            } catch (\Exception $ex) {
                Log::error($ex);
                Alert::danger('An error occured while attempting to delete this pack.')->flash();
            }

            return redirect()->route('admin.services.packs.edit', $id);
        } else {
            try {
                $repo = new Pack;
                $repo->update($id, $request->except([
                    '_token',
                ]));
                Alert::success('Service pack has been successfully updated.')->flash();
            } catch (DisplayValidationException $ex) {
                return redirect()->route('admin.services.packs.edit', $id)->withErrors(json_decode($ex->getMessage()))->withInput();
            } catch (\Exception $ex) {
                Log::error($ex);
                Alert::danger('An error occured while attempting to add edit this pack.')->flash();
            }

            return redirect()->route('admin.services.packs.edit', $id);
        }
    }

    public function export(Request $request, $id, $files = false)

The parameter $request is not used and could be removed.

    {
        $pack = Models\ServicePack::findOrFail($id);
        $json = [
            'name' => $pack->name,
            'version' => $pack->version,
            'description' => $pack->dscription,
            'selectable' => (bool) $pack->selectable,
            'visible' => (bool) $pack->visible,
            'build' => [
                'memory' => $pack->build_memory,
                'swap' => $pack->build_swap,
                'cpu' => $pack->build_cpu,
                'io' => $pack->build_io,
                'container' => $pack->build_container,
                'script' => $pack->build_script,
            ],
        ];

        $filename = tempnam(sys_get_temp_dir(), 'pterodactyl_');
        if ((bool) $files) {
            $zip = new \ZipArchive;
            if (! $zip->open($filename, \ZipArchive::CREATE)) {
                abort(503, 'Unable to open file for writing.');
            }

            $files = Storage::files('packs/' . $pack->uuid);

The method files() does not seem to exist on object<Illuminate\Contracts\Filesystem\Factory>.

            foreach ($files as $file) {
                $zip->addFile(storage_path('app/' . $file), basename(storage_path('app/' . $file)));
            }

            $zip->addFromString('import.json', json_encode($json, JSON_PRETTY_PRINT));
            $zip->close();

            return response()->download($filename, 'pack-' . $pack->name . '.zip')->deleteFileAfterSend(true);
        } else {
            $fp = fopen($filename, 'a+');
            fwrite($fp, json_encode($json, JSON_PRETTY_PRINT));
            fclose($fp);

            return response()->download($filename, 'pack-' . $pack->name . '.json', [
                'Content-Type' => 'application/json',
            ])->deleteFileAfterSend(true);
        }
    }

    public function uploadForm(Request $request, $for = null)

The parameter $request is not used and could be removed.

    {
        return view('admin.services.packs.upload', [
            'services' => $this->formatServices(),
            'for' => $for,
        ]);
    }

    public function postUpload(Request $request)

This method seems to be duplicated in your project.

    {
        try {
            $repo = new Pack;
            $id = $repo->createWithTemplate($request->except([
                '_token',
            ]));
            Alert::success('Successfully created new service!')->flash();

            return redirect()->route('admin.services.packs.edit', $id)->withInput();
        } catch (DisplayValidationException $ex) {
            return redirect()->back()->withErrors(json_decode($ex->getMessage()))->withInput();
        } catch (DisplayException $ex) {
            Alert::danger($ex->getMessage())->flash();
        } catch (\Exception $ex) {
            Log::error($ex);
            Alert::danger('An error occured while attempting to add a new service pack.')->flash();
        }

        return redirect()->back();
    }
}