Complex classes like ServerPolicy often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ServerPolicy, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
32 | class ServerPolicy |
||
33 | { |
||
34 | /** |
||
35 | * Create a new policy instance. |
||
36 | * |
||
37 | * @return void |
||
|
|||
38 | */ |
||
39 | public function __construct() |
||
43 | |||
44 | /** |
||
45 | * Checks if the user has the given permission on/for the server. |
||
46 | * |
||
47 | * @param \Pterodactyl\Models\User $user |
||
48 | * @param \Pterodactyl\Models\Server $server |
||
49 | * @param $permission |
||
50 | * @return bool |
||
51 | */ |
||
52 | private function checkPermission(User $user, Server $server, $permission) |
||
66 | |||
67 | /** |
||
68 | * Determine if current user is the owner of a server. |
||
69 | * |
||
70 | * @param \Pterodactyl\Models\User $user |
||
71 | * @param \Pterodactyl\Models\Server $server |
||
72 | * @return bool |
||
73 | */ |
||
74 | protected function isOwner(User $user, Server $server) |
||
78 | |||
79 | /** |
||
80 | * Runs before any of the functions are called. Used to determine if user is root admin, if so, ignore permissions. |
||
81 | * |
||
82 | * @param \Pterodactyl\Models\User $user |
||
83 | * @param string $ability |
||
84 | * @return bool |
||
85 | */ |
||
86 | public function before(User $user, $ability) |
||
92 | |||
93 | /** |
||
94 | * Check if user has permission to control power for a server. |
||
95 | * |
||
96 | * @param \Pterodactyl\Models\User $user |
||
97 | * @param \Pterodactyl\Models\Server $server |
||
98 | * @return bool |
||
99 | */ |
||
100 | public function power(User $user, Server $server) |
||
104 | |||
105 | /** |
||
106 | * Check if user has permission to start a server. |
||
107 | * |
||
108 | * @param \Pterodactyl\Models\User $user |
||
109 | * @param \Pterodactyl\Models\Server $server |
||
110 | * @return bool |
||
111 | */ |
||
112 | public function powerStart(User $user, Server $server) |
||
116 | |||
117 | /** |
||
118 | * Check if user has permission to stop a server. |
||
119 | * |
||
120 | * @param \Pterodactyl\Models\User $user |
||
121 | * @param \Pterodactyl\Models\Server $server |
||
122 | * @return bool |
||
123 | */ |
||
124 | public function powerStop(User $user, Server $server) |
||
128 | |||
129 | /** |
||
130 | * Check if user has permission to restart a server. |
||
131 | * |
||
132 | * @param \Pterodactyl\Models\User $user |
||
133 | * @param \Pterodactyl\Models\Server $server |
||
134 | * @return bool |
||
135 | */ |
||
136 | public function powerRestart(User $user, Server $server) |
||
140 | |||
141 | /** |
||
142 | * Check if user has permission to kill a server. |
||
143 | * |
||
144 | * @param \Pterodactyl\Models\User $user |
||
145 | * @param \Pterodactyl\Models\Server $server |
||
146 | * @return bool |
||
147 | */ |
||
148 | public function powerKill(User $user, Server $server) |
||
152 | |||
153 | /** |
||
154 | * Check if user has permission to run a command on a server. |
||
155 | * |
||
156 | * @param \Pterodactyl\Models\User $user |
||
157 | * @param \Pterodactyl\Models\Server $server |
||
158 | * @return bool |
||
159 | */ |
||
160 | public function sendCommand(User $user, Server $server) |
||
164 | |||
165 | /** |
||
166 | * Check if user has permission to list files on a server. |
||
167 | * |
||
168 | * @param \Pterodactyl\Models\User $user |
||
169 | * @param \Pterodactyl\Models\Server $server |
||
170 | * @return bool |
||
171 | */ |
||
172 | public function listFiles(User $user, Server $server) |
||
176 | |||
177 | /** |
||
178 | * Check if user has permission to edit files on a server. |
||
179 | * |
||
180 | * @param \Pterodactyl\Models\User $user |
||
181 | * @param \Pterodactyl\Models\Server $server |
||
182 | * @return bool |
||
183 | */ |
||
184 | public function editFiles(User $user, Server $server) |
||
188 | |||
189 | /** |
||
190 | * Check if user has permission to save files on a server. |
||
191 | * |
||
192 | * @param \Pterodactyl\Models\User $user |
||
193 | * @param \Pterodactyl\Models\Server $server |
||
194 | * @return bool |
||
195 | */ |
||
196 | public function saveFiles(User $user, Server $server) |
||
200 | |||
201 | /** |
||
202 | * Check if user has permission to move and rename files and folders on a server. |
||
203 | * |
||
204 | * @param \Pterodactyl\Models\User $user |
||
205 | * @param \Pterodactyl\Models\Server $server |
||
206 | * @return bool |
||
207 | */ |
||
208 | public function moveFiles(User $user, Server $server) |
||
212 | |||
213 | /** |
||
214 | * Check if user has permission to copy folders and files on a server. |
||
215 | * |
||
216 | * @param \Pterodactyl\Models\User $user |
||
217 | * @param \Pterodactyl\Models\Server $server |
||
218 | * @return bool |
||
219 | */ |
||
220 | public function copyFiles(User $user, Server $server) |
||
224 | |||
225 | /** |
||
226 | * Check if user has permission to compress files and folders on a server. |
||
227 | * |
||
228 | * @param \Pterodactyl\Models\User $user |
||
229 | * @param \Pterodactyl\Models\Server $server |
||
230 | * @return bool |
||
231 | */ |
||
232 | public function compressFiles(User $user, Server $server) |
||
236 | |||
237 | /** |
||
238 | * Check if user has permission to decompress files on a server. |
||
239 | * |
||
240 | * @param \Pterodactyl\Models\User $user |
||
241 | * @param \Pterodactyl\Models\Server $server |
||
242 | * @return bool |
||
243 | */ |
||
244 | public function decompressFiles(User $user, Server $server) |
||
248 | |||
249 | /** |
||
250 | * Check if user has permission to add files to a server. |
||
251 | * |
||
252 | * @param \Pterodactyl\Models\User $user |
||
253 | * @param \Pterodactyl\Models\Server $server |
||
254 | * @return bool |
||
255 | */ |
||
256 | public function createFiles(User $user, Server $server) |
||
257 | { |
||
258 | return $this->checkPermission($user, $server, 'create-files'); |
||
259 | } |
||
260 | |||
261 | /** |
||
262 | * Check if user has permission to upload files to a server. |
||
263 | * This permission relies on the user having the 'create-files' permission as well due to page authorization. |
||
264 | * |
||
265 | * @param \Pterodactyl\Models\User $user |
||
266 | * @param \Pterodactyl\Models\Server $server |
||
267 | * @return bool |
||
268 | */ |
||
269 | public function uploadFiles(User $user, Server $server) |
||
273 | |||
274 | /** |
||
275 | * Check if user has permission to download files from a server. |
||
276 | * |
||
277 | * @param \Pterodactyl\Models\User $user |
||
278 | * @param \Pterodactyl\Models\Server $server |
||
279 | * @return bool |
||
280 | */ |
||
281 | public function downloadFiles(User $user, Server $server) |
||
285 | |||
286 | /** |
||
287 | * Check if user has permission to delete files from a server. |
||
288 | * |
||
289 | * @param \Pterodactyl\Models\User $user |
||
290 | * @param \Pterodactyl\Models\Server $server |
||
291 | * @return bool |
||
292 | */ |
||
293 | public function deleteFiles(User $user, Server $server) |
||
297 | |||
298 | /** |
||
299 | * Check if user has permission to view subusers for the server. |
||
300 | * |
||
301 | * @param \Pterodactyl\Models\User $user |
||
302 | * @param \Pterodactyl\Models\Server $server |
||
303 | * @return bool |
||
304 | */ |
||
305 | public function listSubusers(User $user, Server $server) |
||
309 | |||
310 | /** |
||
311 | * Check if user has permission to view specific subuser permissions. |
||
312 | * |
||
313 | * @param \Pterodactyl\Models\User $user |
||
314 | * @param \Pterodactyl\Models\Server $server |
||
315 | * @return bool |
||
316 | */ |
||
317 | public function viewSubuser(User $user, Server $server) |
||
321 | |||
322 | /** |
||
323 | * Check if user has permission to edit a subuser. |
||
324 | * |
||
325 | * @param \Pterodactyl\Models\User $user |
||
326 | * @param \Pterodactyl\Models\Server $server |
||
327 | * @return bool |
||
328 | */ |
||
329 | public function editSubuser(User $user, Server $server) |
||
333 | |||
334 | /** |
||
335 | * Check if user has permission to delete a subuser. |
||
336 | * |
||
337 | * @param \Pterodactyl\Models\User $user |
||
338 | * @param \Pterodactyl\Models\Server $server |
||
339 | * @return bool |
||
340 | */ |
||
341 | public function deleteSubuser(User $user, Server $server) |
||
345 | |||
346 | /** |
||
347 | * Check if user has permission to edit a subuser. |
||
348 | * |
||
349 | * @param \Pterodactyl\Models\User $user |
||
350 | * @param \Pterodactyl\Models\Server $server |
||
351 | * @return bool |
||
352 | */ |
||
353 | public function createSubuser(User $user, Server $server) |
||
357 | |||
358 | /** |
||
359 | * Check if user has permission to set the default connection for a server. |
||
360 | * |
||
361 | * @param \Pterodactyl\Models\User $user |
||
362 | * @param \Pterodactyl\Models\Server $server |
||
363 | * @return bool |
||
364 | */ |
||
365 | public function setConnection(User $user, Server $server) |
||
369 | |||
370 | /** |
||
371 | * Check if user has permission to view the startup command used for a server. |
||
372 | * |
||
373 | * @param \Pterodactyl\Models\User $user |
||
374 | * @param \Pterodactyl\Models\Server $server |
||
375 | * @return bool |
||
376 | */ |
||
377 | public function viewStartup(User $user, Server $server) |
||
381 | |||
382 | /** |
||
383 | * Check if user has permission to edit the startup command used for a server. |
||
384 | * |
||
385 | * @param \Pterodactyl\Models\User $user |
||
386 | * @param \Pterodactyl\Models\Server $server |
||
387 | * @return bool |
||
388 | */ |
||
389 | public function editStartup(User $user, Server $server) |
||
393 | |||
394 | /** |
||
395 | * Check if user has permission to view the SFTP information for a server. |
||
396 | * |
||
397 | * @param \Pterodactyl\Models\User $user |
||
398 | * @param \Pterodactyl\Models\Server $server |
||
399 | * @return bool |
||
400 | */ |
||
401 | public function viewSftp(User $user, Server $server) |
||
405 | |||
406 | /** |
||
407 | * Check if user has permission to reset the SFTP password for a server. |
||
408 | * |
||
409 | * @param \Pterodactyl\Models\User $user |
||
410 | * @param \Pterodactyl\Models\Server $server |
||
411 | * @return bool |
||
412 | */ |
||
413 | public function resetSftp(User $user, Server $server) |
||
417 | |||
418 | /** |
||
419 | * Check if user has permission to view the SFTP password for a server. |
||
420 | * |
||
421 | * @param \Pterodactyl\Models\User $user |
||
422 | * @param \Pterodactyl\Models\Server $server |
||
423 | * @return bool |
||
424 | */ |
||
425 | public function viewSftpPassword(User $user, Server $server) |
||
429 | |||
430 | /** |
||
431 | * Check if user has permission to view databases for a server. |
||
432 | * |
||
433 | * @param \Pterodactyl\Models\User $user |
||
434 | * @param \Pterodactyl\Models\Server $server |
||
435 | * @return bool |
||
436 | */ |
||
437 | public function viewDatabases(User $user, Server $server) |
||
441 | |||
442 | /** |
||
443 | * Check if user has permission to reset database passwords. |
||
444 | * |
||
445 | * @param \Pterodactyl\Models\User $user |
||
446 | * @param \Pterodactyl\Models\Server $server |
||
447 | * @return bool |
||
448 | */ |
||
449 | public function resetDbPassword(User $user, Server $server) |
||
453 | |||
454 | /** |
||
455 | * Check if user has permission to view all tasks for a server. |
||
456 | * |
||
457 | * @param \Pterodactyl\Models\User $user |
||
458 | * @param \Pterodactyl\Models\Server $server |
||
459 | * @return bool |
||
460 | */ |
||
461 | public function listTasks(User $user, Server $server) |
||
465 | |||
466 | /** |
||
467 | * Check if user has permission to view a specific task for a server. |
||
468 | * |
||
469 | * @param \Pterodactyl\Models\User $user |
||
470 | * @param \Pterodactyl\Models\Server $server |
||
471 | * @return bool |
||
472 | */ |
||
473 | public function viewTask(User $user, Server $server) |
||
477 | |||
478 | /** |
||
479 | * Check if user has permission to view a toggle a task for a server. |
||
480 | * |
||
481 | * @param \Pterodactyl\Models\User $user |
||
482 | * @param \Pterodactyl\Models\Server $server |
||
483 | * @return bool |
||
484 | */ |
||
485 | public function toggleTask(User $user, Server $server) |
||
489 | |||
490 | /** |
||
491 | * Check if user has permission to queue a task for a server. |
||
492 | * |
||
493 | * @param \Pterodactyl\Models\User $user |
||
494 | * @param \Pterodactyl\Models\Server $server |
||
495 | * @return bool |
||
496 | */ |
||
497 | public function queueTask(User $user, Server $server) |
||
501 | |||
502 | /** |
||
503 | * Check if user has permission to delete a specific task for a server. |
||
504 | * |
||
505 | * @param \Pterodactyl\Models\User $user |
||
506 | * @param \Pterodactyl\Models\Server $server |
||
507 | * @return bool |
||
508 | */ |
||
509 | public function deleteTask(User $user, Server $server) |
||
513 | |||
514 | /** |
||
515 | * Check if user has permission to create a task for a server. |
||
516 | * |
||
517 | * @param \Pterodactyl\Models\User $user |
||
518 | * @param \Pterodactyl\Models\Server $server |
||
519 | * @return bool |
||
520 | */ |
||
521 | public function createTask(User $user, Server $server) |
||
525 | |||
526 | /** |
||
527 | * Check if user has permission to view server allocations. |
||
528 | * |
||
529 | * @param \Pterodactyl\Models\User $user |
||
530 | * @param \Pterodactyl\Models\Server $server |
||
531 | * @return bool |
||
532 | */ |
||
533 | public function viewAllocation(User $user, Server $server) |
||
537 | |||
538 | /** |
||
539 | * Check if user has permission to set the default allocation. |
||
540 | * |
||
541 | * @param \Pterodactyl\Models\User $user |
||
542 | * @param \Pterodactyl\Models\Server $server |
||
543 | * @return bool |
||
544 | */ |
||
545 | public function setAllocation(User $user, Server $server) |
||
549 | } |
||
550 |
Adding a
@return
annotation to a constructor is not recommended, since a constructor does not have a meaningful return value.Please refer to the PHP core documentation on constructors.