OptionController::details() - Code Metrics - Inspection of "Feature/option scripts" - Pterodactyl/Panel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#401)

by Dane

created 2017-04-22 00:59 UTC

OptionController::details() B

↳ Parent: OptionController

Complexity

Conditions	2
Paths	1

Size

Total Lines	25
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	25
rs	8.8571
c	0
b	0
f	0
cc	2
eloc	17
nc	1
nop	2

<?php
/**
 * Pterodactyl - Panel
 * Copyright (c) 2015 - 2017 Dane Everitt <[email protected]>.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

namespace Pterodactyl\Http\Controllers\Daemon;

use Illuminate\Http\Request;
use Pterodactyl\Models\Server;
use Pterodactyl\Models\ServiceOption;
use Pterodactyl\Http\Controllers\Controller;

class OptionController extends Controller
{
    public function details(Request $request, $server)

    {
        $server = Server::with('allocation', 'option', 'variables.variable')->where('uuid', $server)->firstOrFail();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $environment = $server->variables->map(function ($item) {
            return sprintf('%s=%s', $item->variable->env_variable, $item->variable_value);
        });

        return response()->json([
            'scripts' => [
                'install' => (! $server->option->script_install) ? null : str_replace(["\r\n", "\n", "\r"], "\n", $server->option->script_install),
                'privileged' => $server->option->script_is_privileged,
            ],
            'config' => [
                'container' => $server->option->script_container,
                'entry' => $server->option->script_entry,
            ],
            'env' => $environment->merge([
                'STARTUP=' . $server->startup,
                'SERVER_MEMORY=' . $server->memory,
                'SERVER_IP=' . $server->allocation->ip,
                'SERVER_PORT=' . $server->allocation->port,
            ])->toArray(),
        ]);
    }
}


GitHub Access Token became invalid

Pull Request — develop (#401)

OptionController::details() B

Complexity

Size

Duplication

Importance

Available Fixes

1			<?php
2			/**
3			* Pterodactyl - Panel
4			* Copyright (c) 2015 - 2017 Dane Everitt <[email protected]>.
5			*
6			* Permission is hereby granted, free of charge, to any person obtaining a copy
7			* of this software and associated documentation files (the "Software"), to deal
8			* in the Software without restriction, including without limitation the rights
9			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10			* copies of the Software, and to permit persons to whom the Software is
11			* furnished to do so, subject to the following conditions:
12			*
13			* The above copyright notice and this permission notice shall be included in all
14			* copies or substantial portions of the Software.
15			*
16			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
22			* SOFTWARE.
23			*/
24
25			namespace Pterodactyl\Http\Controllers\Daemon;
26
27			use Illuminate\Http\Request;
28			use Pterodactyl\Models\Server;
29			use Pterodactyl\Models\ServiceOption;
30			use Pterodactyl\Http\Controllers\Controller;
31
32			class OptionController extends Controller
33			{
34			public function details(Request $request, $server)
			0 ignored issues – show Unused Code introduced 2017-04-22 01:02 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
35			{
36			$server = Server::with('allocation', 'option', 'variables.variable')->where('uuid', $server)->firstOrFail();
			0 ignored issues – show Bug introduced 2017-04-22 01:02 UTC by Report Bug Copy Issue Report The method `where` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
37
38			$environment = $server->variables->map(function ($item) {
39			return sprintf('%s=%s', $item->variable->env_variable, $item->variable_value);
40			});
41
42			return response()->json([
43			'scripts' => [
44			'install' => (! $server->option->script_install) ? null : str_replace(["\r\n", "\n", "\r"], "\n", $server->option->script_install),
45			'privileged' => $server->option->script_is_privileged,
46			],
47			'config' => [
48			'container' => $server->option->script_container,
49			'entry' => $server->option->script_entry,
50			],
51			'env' => $environment->merge([
52			'STARTUP=' . $server->startup,
53			'SERVER_MEMORY=' . $server->memory,
54			'SERVER_IP=' . $server->allocation->ip,
55			'SERVER_PORT=' . $server->allocation->port,
56			])->toArray(),
57			]);
58			}
59			}
60

Pterodactyl / Panel

GitHub Access Token became invalid

Pull Request — develop (#401)

OptionController::details() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like