Pterodactyl\Http\Controllers\Base\IndexController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	79
Duplicated Lines	15.19 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getPassword()	0	14	4
A	getIndex()	12	12	2
B	status()	0	27	6

<?php
/**
 * Pterodactyl - Panel
 * Copyright (c) 2015 - 2017 Dane Everitt <dane@daneeveritt.com>
 * Some Modifications (c) 2015 Dylan Seidt <dylan.seidt@gmail.com>.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

namespace Pterodactyl\Http\Controllers\Base;

use Illuminate\Http\Request;
use Pterodactyl\Models\Server;
use Pterodactyl\Http\Controllers\Controller;

class IndexController extends Controller
{
    /**
     * Returns listing of user's servers.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\View\View
     */
    public function getIndex(Request $request)

This method seems to be duplicated in your project.

    {
        $servers = $request->user()->access()->with('user');

        if (! is_null($request->input('query'))) {
            $servers->search($request->input('query'));
        }

        return view('base.index', [

The expression view('base.index', array('servers' => $servers->paginate(config('pterodactyl.paginate.frontend.servers')))); of type Illuminate\View\View|Illuminate\Contracts\View\Factory adds the type Illuminate\Contracts\View\Factory to the return on line 48 which is incompatible with the return type documented by Pterodactyl\Http\Controllers\Base\IndexController::getIndex of type Illuminate\View\View.

            'servers' => $servers->paginate(config('pterodactyl.paginate.frontend.servers')),
        ]);
    }

    /**
     * Generate a random string.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int                       $length
     * @return string
     * @deprecated
     */
    public function getPassword(Request $request, $length = 16)

The parameter $request is not used and could be removed.

    {
        $length = ($length < 8) ? 8 : $length;

        $returnable = false;
        while (! $returnable) {
            $generated = str_random($length);
            if (preg_match('/[A-Z]+[a-z]+[0-9]+/', $generated)) {
                $returnable = true;
            }
        }

        return $generated;

The variable $generated does not seem to be defined for all execution paths leading up to this point.

    }

    /**
     * Returns status of the server in a JSON response used for populating active status list.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  string                    $uuid
     * @return \Illuminate\Http\JsonResponse
     */
    public function status(Request $request, $uuid)

The parameter $request is not used and could be removed.

    {
        $server = Server::byUuid($uuid);

        if (! $server) {
            return response()->json([], 404);
        }

        if (! $server->installed) {
            return response()->json(['status' => 20]);
        }

        if ($server->suspended) {
            return response()->json(['status' => 30]);
        }

        try {
            $res = $server->guzzleClient()->request('GET', '/server');
            if ($res->getStatusCode() === 200) {
                return response()->json(json_decode($res->getBody()));
            }
        } catch (\Exception $e) {
            //
        }

        return response()->json([]);
    }
}