OptionController::create() - Code Metrics - Inspection of "Merge service changes into develop" - Pterodactyl/Panel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#350)

by Dane

created 2017-03-16 00:53 UTC

OptionController::create() B

↳ Parent: OptionController

Complexity

Conditions	4
Paths	10

Size

Total Lines	24
Code Lines	17

Duplication

Lines	24
Ratio	100 %

Importance

Changes

Metric	Value
dl	24
loc	24
rs	8.6845
c	0
b	0
f	0
cc	4
eloc	17
nc	10
nop	1

<?php
/**
 * Pterodactyl - Panel
 * Copyright (c) 2015 - 2017 Dane Everitt <[email protected]>.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

namespace Pterodactyl\Http\Controllers\Admin;

use Log;
use Alert;
use Javascript;
use Illuminate\Http\Request;
use Pterodactyl\Models\Service;
use Pterodactyl\Models\ServiceOption;
use Pterodactyl\Exceptions\DisplayException;
use Pterodactyl\Http\Controllers\Controller;
use Pterodactyl\Repositories\OptionRepository;
use Pterodactyl\Repositories\VariableRepository;
use Pterodactyl\Exceptions\DisplayValidationException;

class OptionController extends Controller
{
    /**
     * Handles request to view page for adding new option.
     *
     * @param  Request $request
     * @return \Illuminate\View\View
     */
    public function new(Request $request)

    {
        $services = Service::with('options')->get();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        Javascript::put(['services' => $services->keyBy('id')]);

        return view('admin.services.options.new', ['services' => $services]);

    }

    /**
     * Handles POST request to create a new option.
     *
     * @param  Request $request
     * @return \Illuminate\Response\RedirectResponse
     */
    public function create(Request $request)

    {
        $repo = new OptionRepository;

        try {
            $option = $repo->create($request->intersect([
                'service_id', 'name', 'description', 'tag',
                'docker_image', 'startup', 'config_from', 'config_startup',
                'config_logs', 'config_files', 'config_stop',
            ]));
            Alert::success('Successfully created new service option.')->flash();

            return redirect()->route('admin.services.option.view', $option->id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } catch (DisplayValidationException $ex) {
            return redirect()->route('admin.services.option.new')->withErrors(json_decode($ex->getMessage()))->withInput();
        } catch (DisplayException $ex) {
            Alert::danger($ex->getMessage())->flash();
        } catch (\Exception $ex) {
            Log::error($ex);
            Alert::danger('An unhandled exception occurred while attempting to create this service. This error has been logged.')->flash();
        }

        return redirect()->route('admin.services.option.new')->withInput();
    }

    /**
     * Handles POST request to create a new option variable.
     *
     * @param  Request $request
     * @param  int     $id       The ID of the service option to assign this variable to.
     * @return \Illuminate\Response\RedirectResponse
     */
    public function createVariable(Request $request, $id)

    {
        $repo = new VariableRepository;

        try {
            $variable = $repo->create($id, $request->only([
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                'name', 'description', 'env_variable',
                'default_value', 'options', 'rules',
            ]));

            Alert::success('New variable successfully assigned to this service option.')->flash();
        } catch (DisplayValidationException $ex) {
            return redirect()->route('admin.services.option.variables', $id)->withErrors(json_decode($ex->getMessage()));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } catch (DisplayException $ex) {
            Alert::danger($ex->getMessage())->flash();
        } catch (\Exception $ex) {
            Log::error($ex);
            Alert::danger('An unhandled exception was encountered while attempting to process that request. This error has been logged.')->flash();
        }

        return redirect()->route('admin.services.option.variables', $id);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Display option overview page.
     *
     * @param  Request $request
     * @param  int     $id
     * @return \Illuminate\View\View
     */
    public function viewConfiguration(Request $request, $id)

    {
        return view('admin.services.options.view', ['option' => ServiceOption::findOrFail($id)]);

    }

    /**
     * Display variable overview page for a service option.
     *
     * @param  Request $request
     * @param  int     $id
     * @return \Illuminate\View\View
     */
    public function viewVariables(Request $request, $id)

    {
        return view('admin.services.options.variables', ['option' => ServiceOption::with('variables')->findOrFail($id)]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Handles POST when editing a configration for a service option.
     *
     * @param  Request $request
     * @return \Illuminate\Response\RedirectResponse
     */
    public function editConfiguration(Request $request, $id)
    {
        $repo = new OptionRepository;

        try {
            if ($request->input('action') !== 'delete') {
                $repo->update($id, $request->intersect([
                    'name', 'description', 'tag', 'docker_image', 'startup',
                    'config_from', 'config_stop', 'config_logs', 'config_files', 'config_startup',
                ]));
                Alert::success('Service option configuration has been successfully updated.')->flash();
            } else {
                $option = ServiceOption::with('service')->where('id', $id)->first();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                $repo->delete($id);
                Alert::success('Successfully deleted service option from the system.')->flash();

                return redirect()->route('admin.services.view', $option->service_id);
            }
        } catch (DisplayValidationException $ex) {
            return redirect()->route('admin.services.option.view', $id)->withErrors(json_decode($ex->getMessage()));
        } catch (DisplayException $ex) {
            Alert::danger($ex->getMessage())->flash();
        } catch (\Exception $ex) {
            Log::error($ex);
            Alert::danger('An unhandled exception occurred while attempting to perform that action. This error has been logged.')->flash();
        }

        return redirect()->route('admin.services.option.view', $id);
    }

    /**
     * Handles POST when editing a configration for a service option.
     *
     * @param  Request $request
     * @param  int     $option
     * @param  int     $variable
     * @return \Illuminate\Response\RedirectResponse
     */
    public function editVariable(Request $request, $option, $variable)
    {
        $repo = new VariableRepository;

        try {
            if ($request->input('action') !== 'delete') {
                $variable = $repo->update($variable, $request->only([
                    'name', 'description', 'env_variable',
                    'default_value', 'options', 'rules',
                ]));
                Alert::success("The service variable '{$variable->name}' has been updated.")->flash();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            } else {
                $repo->delete($variable);
                Alert::success('That service variable has been deleted.')->flash();
            }
        } catch (DisplayValidationException $ex) {
            return redirect()->route('admin.services.option.variables', $option)->withErrors(json_decode($ex->getMessage()));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } catch (DisplayException $ex) {
            Alert::danger($ex->getMessage())->flash();
        } catch (\Exception $ex) {
            Log::error($ex);
            Alert::danger('An unhandled exception was encountered while attempting to process that request. This error has been logged.')->flash();
        }

        return redirect()->route('admin.services.option.variables', $option);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


GitHub Access Token became invalid

Pull Request — develop (#350)

OptionController::create() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1		<?php
2		/**
3		* Pterodactyl - Panel
4		* Copyright (c) 2015 - 2017 Dane Everitt <[email protected]>.
5		*
6		* Permission is hereby granted, free of charge, to any person obtaining a copy
7		* of this software and associated documentation files (the "Software"), to deal
8		* in the Software without restriction, including without limitation the rights
9		* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10		* copies of the Software, and to permit persons to whom the Software is
11		* furnished to do so, subject to the following conditions:
12		*
13		* The above copyright notice and this permission notice shall be included in all
14		* copies or substantial portions of the Software.
15		*
16		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17		* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18		* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19		* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20		* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21		* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
22		* SOFTWARE.
23		*/
24
25		namespace Pterodactyl\Http\Controllers\Admin;
26
27		use Log;
28		use Alert;
29		use Javascript;
30		use Illuminate\Http\Request;
31		use Pterodactyl\Models\Service;
32		use Pterodactyl\Models\ServiceOption;
33		use Pterodactyl\Exceptions\DisplayException;
34		use Pterodactyl\Http\Controllers\Controller;
35		use Pterodactyl\Repositories\OptionRepository;
36		use Pterodactyl\Repositories\VariableRepository;
37		use Pterodactyl\Exceptions\DisplayValidationException;
38
39		class OptionController extends Controller
40		{
41		/**
42		* Handles request to view page for adding new option.
43		*
44		* @param Request $request
45		* @return \Illuminate\View\View
46		*/
47		public function new(Request $request)
		0 ignored issues – show Unused Code introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
48		{
49		$services = Service::with('options')->get();
		0 ignored issues – show Bug introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report The method `get` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
50		Javascript::put(['services' => $services->keyBy('id')]);
51
52		return view('admin.services.options.new', ['services' => $services]);
		0 ignored issues – show Bug Compatibility introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report The expression `view('admin.services.opt...rvices' => $services));` of type `Illuminate\View\View\|Ill...\Contracts\View\Factory` adds the type `Illuminate\Contracts\View\Factory` to the return on line 52 which is incompatible with the return type documented by `Pterodactyl\Http\Control...n\OptionController::new` of type `Illuminate\View\View`. Loading history...
53		}
54
55		/**
56		* Handles POST request to create a new option.
57		*
58		* @param Request $request
59		* @return \Illuminate\Response\RedirectResponse
60		*/
61	View Code Duplication	public function create(Request $request)
		0 ignored issues – show Duplication introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62		{
63		$repo = new OptionRepository;
64
65		try {
66		$option = $repo->create($request->intersect([
67		'service_id', 'name', 'description', 'tag',
68		'docker_image', 'startup', 'config_from', 'config_startup',
69		'config_logs', 'config_files', 'config_stop',
70		]));
71		Alert::success('Successfully created new service option.')->flash();
72
73		return redirect()->route('admin.services.option.view', $option->id);
		0 ignored issues – show Documentation introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Pterodactyl\Models\ServiceOption>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
74		} catch (DisplayValidationException $ex) {
75		return redirect()->route('admin.services.option.new')->withErrors(json_decode($ex->getMessage()))->withInput();
76		} catch (DisplayException $ex) {
77		Alert::danger($ex->getMessage())->flash();
78		} catch (\Exception $ex) {
79		Log::error($ex);
80		Alert::danger('An unhandled exception occurred while attempting to create this service. This error has been logged.')->flash();
81		}
82
83		return redirect()->route('admin.services.option.new')->withInput();
84		}
85
86		/**
87		* Handles POST request to create a new option variable.
88		*
89		* @param Request $request
90		* @param int $id The ID of the service option to assign this variable to.
91		* @return \Illuminate\Response\RedirectResponse
92		*/
93	View Code Duplication	public function createVariable(Request $request, $id)
		0 ignored issues – show Duplication introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
94		{
95		$repo = new VariableRepository;
96
97		try {
98		$variable = $repo->create($id, $request->only([
		0 ignored issues – show Unused Code introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report `$variable` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
99		'name', 'description', 'env_variable',
100		'default_value', 'options', 'rules',
101		]));
102
103		Alert::success('New variable successfully assigned to this service option.')->flash();
104		} catch (DisplayValidationException $ex) {
105		return redirect()->route('admin.services.option.variables', $id)->withErrors(json_decode($ex->getMessage()));
		0 ignored issues – show Documentation introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report `$id` is of type `integer`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
106		} catch (DisplayException $ex) {
107		Alert::danger($ex->getMessage())->flash();
108		} catch (\Exception $ex) {
109		Log::error($ex);
110		Alert::danger('An unhandled exception was encountered while attempting to process that request. This error has been logged.')->flash();
111		}
112
113		return redirect()->route('admin.services.option.variables', $id);
		0 ignored issues – show Documentation introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report `$id` is of type `integer`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
114		}
115
116		/**
117		* Display option overview page.
118		*
119		* @param Request $request
120		* @param int $id
121		* @return \Illuminate\View\View
122		*/
123		public function viewConfiguration(Request $request, $id)
		0 ignored issues – show Unused Code introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
124		{
125		return view('admin.services.options.view', ['option' => ServiceOption::findOrFail($id)]);
		0 ignored issues – show Bug Compatibility introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report The expression `view('admin.services.opt...ion::findOrFail($id)));` of type `Illuminate\View\View\|Ill...\Contracts\View\Factory` adds the type `Illuminate\Contracts\View\Factory` to the return on line 125 which is incompatible with the return type documented by `Pterodactyl\Http\Control...ller::viewConfiguration` of type `Illuminate\View\View`. Loading history...
126		}
127
128		/**
129		* Display variable overview page for a service option.
130		*
131		* @param Request $request
132		* @param int $id
133		* @return \Illuminate\View\View
134		*/
135		public function viewVariables(Request $request, $id)
		0 ignored issues – show Unused Code introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
136		{
137		return view('admin.services.options.variables', ['option' => ServiceOption::with('variables')->findOrFail($id)]);
		0 ignored issues – show Bug introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report The method `findOrFail` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history... Bug Compatibility introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report The expression `view('admin.services.opt...s')->findOrFail($id)));` of type `Illuminate\View\View\|Ill...\Contracts\View\Factory` adds the type `Illuminate\Contracts\View\Factory` to the return on line 137 which is incompatible with the return type documented by `Pterodactyl\Http\Control...ntroller::viewVariables` of type `Illuminate\View\View`. Loading history...
138		}
139
140		/**
141		* Handles POST when editing a configration for a service option.
142		*
143		* @param Request $request
144		* @return \Illuminate\Response\RedirectResponse
145		*/
146		public function editConfiguration(Request $request, $id)
147		{
148		$repo = new OptionRepository;
149
150		try {
151		if ($request->input('action') !== 'delete') {
152		$repo->update($id, $request->intersect([
153		'name', 'description', 'tag', 'docker_image', 'startup',
154		'config_from', 'config_stop', 'config_logs', 'config_files', 'config_startup',
155		]));
156		Alert::success('Service option configuration has been successfully updated.')->flash();
157		} else {
158		$option = ServiceOption::with('service')->where('id', $id)->first();
		0 ignored issues – show Bug introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report The method `where` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
159		$repo->delete($id);
160		Alert::success('Successfully deleted service option from the system.')->flash();
161
162		return redirect()->route('admin.services.view', $option->service_id);
163		}
164		} catch (DisplayValidationException $ex) {
165		return redirect()->route('admin.services.option.view', $id)->withErrors(json_decode($ex->getMessage()));
166		} catch (DisplayException $ex) {
167		Alert::danger($ex->getMessage())->flash();
168		} catch (\Exception $ex) {
169		Log::error($ex);
170		Alert::danger('An unhandled exception occurred while attempting to perform that action. This error has been logged.')->flash();
171		}
172
173		return redirect()->route('admin.services.option.view', $id);
174		}
175
176		/**
177		* Handles POST when editing a configration for a service option.
178		*
179		* @param Request $request
180		* @param int $option
181		* @param int $variable
182		* @return \Illuminate\Response\RedirectResponse
183		*/
184		public function editVariable(Request $request, $option, $variable)
185		{
186		$repo = new VariableRepository;
187
188		try {
189		if ($request->input('action') !== 'delete') {
190		$variable = $repo->update($variable, $request->only([
191		'name', 'description', 'env_variable',
192		'default_value', 'options', 'rules',
193		]));
194		Alert::success("The service variable '{$variable->name}' has been updated.")->flash();
		0 ignored issues – show Documentation introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<Pterodactyl\Models\ServiceVariable>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
195		} else {
196		$repo->delete($variable);
197		Alert::success('That service variable has been deleted.')->flash();
198		}
199		} catch (DisplayValidationException $ex) {
200		return redirect()->route('admin.services.option.variables', $option)->withErrors(json_decode($ex->getMessage()));
		0 ignored issues – show Documentation introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report `$option` is of type `integer`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
201		} catch (DisplayException $ex) {
202		Alert::danger($ex->getMessage())->flash();
203		} catch (\Exception $ex) {
204		Log::error($ex);
205		Alert::danger('An unhandled exception was encountered while attempting to process that request. This error has been logged.')->flash();
206		}
207
208		return redirect()->route('admin.services.option.variables', $option);
		0 ignored issues – show Documentation introduced 2017-03-16 01:04 UTC by Report Bug Copy Issue Report `$option` is of type `integer`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
209		}
210		}
211

Pterodactyl / Panel

GitHub Access Token became invalid

Pull Request — develop (#350)

OptionController::create() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like