Handler::render() - Code Metrics - Inspection of "Implement new API and Route Updates" - Pterodactyl/Panel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#371)

by Dane

created 2017-04-09 23:16 UTC

Handler::render() C

↳ Parent: Handler

Complexity

Conditions	10
Paths	8

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	6.1368
c	0
b	0
f	0
cc	10
eloc	13
nc	8
nop	2

How to fix Complexity

<?php

namespace Pterodactyl\Exceptions;

use Log;
use Exception;
use Illuminate\Auth\AuthenticationException;
use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;

class Handler extends ExceptionHandler
{
    /**
     * A list of the exception types that should not be reported.
     *
     * @var array
     */
    protected $dontReport = [
        \Illuminate\Auth\AuthenticationException::class,
        \Illuminate\Auth\Access\AuthorizationException::class,
        \Symfony\Component\HttpKernel\Exception\HttpException::class,
        \Illuminate\Database\Eloquent\ModelNotFoundException::class,
        \Illuminate\Session\TokenMismatchException::class,
        \Illuminate\Validation\ValidationException::class,
    ];

    /**
     * Report or log an exception.
     *
     * This is a great spot to send exceptions to Sentry, Bugsnag, etc.
     *
     * @param  \Exception  $exception
     * @return void
     */
    public function report(Exception $exception)
    {
        return parent::report($exception);
    }

    /**
     * Render an exception into an HTTP response.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Exception                $exception
     * @return \Illuminate\Http\Response
     */
    public function render($request, Exception $exception)
    {
        if ($request->expectsJson() || $request->isJson() || $request->is(...config('pterodactyl.json_routes'))) {
            $exception = $this->prepareException($exception);

            if (config('app.debug')) {
                $report = [
                    'code' => (! $this->isHttpException($exception)) ?: $exception->getStatusCode(),
                    'message' => class_basename($exception) . ' in ' . $exception->getFile() . ' on line ' . $exception->getLine(),
                ];
            }

            $response = response()->json([
                'error' => (config('app.debug')) ? $exception->getMessage() : 'An unhandled exception was encountered with this request.',
                'exception' => ! isset($report) ?: $report,
            ], ($this->isHttpException($exception)) ? $exception->getStatusCode() : 500, [], JSON_UNESCAPED_SLASHES);

            parent::report($exception);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        }

        return (isset($response)) ? $response : parent::render($request, $exception);

    }

    /**
     * Convert an authentication exception into an unauthenticated response.
     *
     * @param  \Illuminate\Http\Request                  $request
     * @param  \Illuminate\Auth\AuthenticationException  $exception
     * @return \Illuminate\Http\Response
     */
    protected function unauthenticated($request, AuthenticationException $exception)

    {
        if ($request->expectsJson()) {
            return response()->json(['error' => 'Unauthenticated.'], 401);
        }

        return redirect()->guest(route('auth.login'));
    }
}


GitHub Access Token became invalid

Pull Request — develop (#371)

Handler::render() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

1			<?php
2
3			namespace Pterodactyl\Exceptions;
4
5			use Log;
6			use Exception;
7			use Illuminate\Auth\AuthenticationException;
8			use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
9
10			class Handler extends ExceptionHandler
11			{
12			/**
13			* A list of the exception types that should not be reported.
14			*
15			* @var array
16			*/
17			protected $dontReport = [
18			\Illuminate\Auth\AuthenticationException::class,
19			\Illuminate\Auth\Access\AuthorizationException::class,
20			\Symfony\Component\HttpKernel\Exception\HttpException::class,
21			\Illuminate\Database\Eloquent\ModelNotFoundException::class,
22			\Illuminate\Session\TokenMismatchException::class,
23			\Illuminate\Validation\ValidationException::class,
24			];
25
26			/**
27			* Report or log an exception.
28			*
29			* This is a great spot to send exceptions to Sentry, Bugsnag, etc.
30			*
31			* @param \Exception $exception
32			* @return void
33			*/
34			public function report(Exception $exception)
35			{
36			return parent::report($exception);
37			}
38
39			/**
40			* Render an exception into an HTTP response.
41			*
42			* @param \Illuminate\Http\Request $request
43			* @param \Exception $exception
44			* @return \Illuminate\Http\Response
45			*/
46			public function render($request, Exception $exception)
47			{
48			if ($request->expectsJson() \|\| $request->isJson() \|\| $request->is(...config('pterodactyl.json_routes'))) {
49			$exception = $this->prepareException($exception);
50
51			if (config('app.debug')) {
52			$report = [
53			'code' => (! $this->isHttpException($exception)) ?: $exception->getStatusCode(),
54			'message' => class_basename($exception) . ' in ' . $exception->getFile() . ' on line ' . $exception->getLine(),
55			];
56			}
57
58			$response = response()->json([
59			'error' => (config('app.debug')) ? $exception->getMessage() : 'An unhandled exception was encountered with this request.',
60			'exception' => ! isset($report) ?: $report,
61			], ($this->isHttpException($exception)) ? $exception->getStatusCode() : 500, [], JSON_UNESCAPED_SLASHES);
62
63			parent::report($exception);
			0 ignored issues – show Comprehensibility Bug introduced 2017-01-12 20:50 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`report()` instead of `render()`). Are you sure this is correct? If so, you might want to change this to `$this->report()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
64			}
65
66			return (isset($response)) ? $response : parent::render($request, $exception);
			0 ignored issues – show Bug Compatibility introduced 2016-12-07 22:58 UTC by Report Bug Copy Issue Report The expression `isset($response) ? $resp...($request, $exception);` of type `Illuminate\Http\JsonResp...HttpFoundation\Response` adds the type `Illuminate\Http\JsonResponse` to the return on line 66 which is incompatible with the return type documented by `Pterodactyl\Exceptions\Handler::render` of type `Illuminate\Http\Response`. Loading history...
67			}
68
69			/**
70			* Convert an authentication exception into an unauthenticated response.
71			*
72			* @param \Illuminate\Http\Request $request
73			* @param \Illuminate\Auth\AuthenticationException $exception
74			* @return \Illuminate\Http\Response
75			*/
76			protected function unauthenticated($request, AuthenticationException $exception)
			0 ignored issues – show Unused Code introduced 2016-12-07 22:58 UTC by Report Bug Copy Issue Report The parameter `$exception` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
77			{
78			if ($request->expectsJson()) {
79			return response()->json(['error' => 'Unauthenticated.'], 401);
80			}
81
82			return redirect()->guest(route('auth.login'));
83			}
84			}
85

Pterodactyl / Panel

GitHub Access Token became invalid

Pull Request — develop (#371)

Handler::render() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like