NodesController::createAllocation() - Code Metrics - Inspection of "Retheme Admin Control" - Pterodactyl/Panel - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — develop (#334)

by Dane
created 2017-03-06 01:28 UTC
NodesController::createAllocation() A

↳ Parent: NodesController
Complexity

Conditions	4
Paths	7
Size

Total Lines	18
Code Lines	13
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
dl	0
loc	18
rs	9.2
c	0
b	0
f	0
cc	4
eloc	13
nc	7
nop	2
<?php
/**
 * Pterodactyl - Panel
 * Copyright (c) 2015 - 2017 Dane Everitt <[email protected]>.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

namespace Pterodactyl\Http\Controllers\Admin;

use DB;
use Log;
use Alert;
use Javascript;
use Pterodactyl\Models;
use Illuminate\Http\Request;
use Pterodactyl\Exceptions\DisplayException;
use Pterodactyl\Http\Controllers\Controller;
use Pterodactyl\Repositories\NodeRepository;
use Pterodactyl\Exceptions\DisplayValidationException;

class NodesController extends Controller
{
    /**
     * Displays the index page listing all nodes on the panel.
     *
     * @param  Request $request
     * @return \Illuminate\View\View
     */
    public function index(Request $request)

    {
        $nodes = Models\Node::with('location')->withCount('servers');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        if (! is_null($request->input('query'))) {
            $nodes->search($request->input('query'));
        }

        return view('admin.nodes.index', ['nodes' => $nodes->paginate(25)]);

    }

    /**
     * Displays create new node page.
     *
     * @param  Request $request
     * @return \Illuminate\View\View|\Illuminate\Response\RedirectResponse
     */
    public function new(Request $request)

    {
        $locations = Models\Location::all();
        if (! $locations->count()) {
            Alert::warning('You must add a location before you can add a new node.')->flash();

            return redirect()->route('admin.locations');
        }

        return view('admin.nodes.new', ['locations' => $locations]);
    }

    /**
     * Post controller to create a new node on the system.
     *
     * @param  Request $request
     * @return \Illuminate\Response\RedirectResponse
     */
    public function create(Request $request)

    {
        try {
            $repo = new NodeRepository;
            $node = $repo->create($request->intersect([
                'name', 'location_id', 'public', 'fqdn', 'scheme', 'memory',
                'memory_overallocate', 'disk', 'disk_overallocate',
                'daemonBase', 'daemonSFTP', 'daemonListen',
            ]));
            Alert::success('Successfully created new node that can be configured automatically on your remote machine by visiting the configuration tab. <strong>Before you can add any servers you need to first assign some IP addresses and ports.</strong>')->flash();

            return redirect()->route('admin.nodes.view', $node->id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } catch (DisplayValidationException $e) {
            return redirect()->route('admin.nodes.new')->withErrors(json_decode($e->getMessage()))->withInput();
        } catch (DisplayException $e) {
            Alert::danger($e->getMessage())->flash();
        } catch (\Exception $e) {
            Log::error($e);
            Alert::danger('An unhandled exception occured while attempting to add this node. Please try again.')->flash();
        }

        return redirect()->route('admin.nodes.new')->withInput();
    }

    /**
     * Shows the index overview page for a specific node.
     *
     * @param  Request $request
     * @param  int     $id      The ID of the node to display information for.
     *
     * @return \Illuminate\View\View
     */
    public function viewIndex(Request $request, $id)

    {
        $node = Models\Node::with('location')->withCount('servers')->findOrFail($id);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $stats = collect(
            Models\Server::select(

                DB::raw('SUM(memory) as memory, SUM(disk) as disk')
            )->where('node_id', $node->id)->first()
        )->mapWithKeys(function ($item, $key) use ($node) {
            $percent = ($item / $node->{$key}) * 100;

            return [$key => [
                'value' => $item,
                'percent' => $percent,
                'css' => ($percent <= 75) ? 'green' : (($percent > 90) ? 'red' : 'yellow'),
            ]];
        })->toArray();

        return view('admin.nodes.view.index', ['node' => $node, 'stats' => $stats]);

    }

    /**
     * Shows the settings page for a specific node.
     *
     * @param  Request $request
     * @param  int     $id      The ID of the node to display information for.
     *
     * @return \Illuminate\View\View
     */
    public function viewSettings(Request $request, $id)

    {
        return view('admin.nodes.view.settings', [

            'node' => Models\Node::findOrFail($id),
            'locations' => Models\Location::all(),
        ]);
    }

    /**
     * Shows the configuration page for a specific node.
     *
     * @param  Request $request
     * @param  int     $id      The ID of the node to display information for.
     *
     * @return \Illuminate\View\View
     */
    public function viewConfiguration(Request $request, $id)

    {
        return view('admin.nodes.view.configuration', [

            'node' => Models\Node::findOrFail($id),
        ]);
    }

    /**
     * Shows the allocation page for a specific node.
     *
     * @param  Request $request
     * @param  int     $id      The ID of the node to display information for.
     *
     * @return \Illuminate\View\View
     */
    public function viewAllocation(Request $request, $id)

    {
        $node = Models\Node::findOrFail($id);
        $node->setRelation('allocations', $node->allocations()->orderBy('ip', 'asc')->orderBy('port', 'asc')->with('server')->paginate(50));

        Javascript::put([
            'node' => collect($node)->only(['id']),
        ]);

        return view('admin.nodes.view.allocation', ['node' => $node]);

    }

    /**
     * Shows the server listing page for a specific node.
     *
     * @param  Request $request
     * @param  int     $id      The ID of the node to display information for.
     *
     * @return \Illuminate\View\View
     */
    public function viewServers(Request $request, $id)

    {
        $node = Models\Node::with('servers.user', 'servers.service', 'servers.option')->findOrFail($id);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        Javascript::put([
            'node' => collect($node->makeVisible('daemonSecret'))->only(['scheme', 'fqdn', 'daemonListen', 'daemonSecret']),
        ]);

        return view('admin.nodes.view.servers', [

            'node' => $node,
        ]);
    }

    /**
     * Updates settings for a node.
     *
     * @param  Request $request
     * @param  int $node
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\RedirectResponse
     */
    public function updateSettings(Request $request, $id)

    {
        $repo = new NodeRepository;

        try {
            $repo->update($id, $request->intersect([
                'name', 'location_id', 'public', 'fqdn', 'scheme', 'memory',
                'memory_overallocate', 'disk', 'disk_overallocate', 'upload_size',
                'daemonSFTP', 'daemonListen', 'reset_secret',
            ]));

            Alert::success('Successfully updated this node\'s information. If you changed any daemon settings you will need to restart it now.')->flash();
        } catch (DisplayValidationException $ex) {
            return redirect()->route('admin.nodes.view.settings', $id)->withErrors(json_decode($ex->getMessage()))->withInput();
        } catch (DisplayException $ex) {
            Alert::danger($ex->getMessage())->flash();
        } catch (\Exception $ex) {
            Log::error($ex);
            Alert::danger('An unhandled exception occured while attempting to edit this node. Please try again.')->flash();
        }

        return redirect()->route('admin.nodes.view.settings', $id)->withInput();
    }

    /**
     * Removes a single allocation from a node.
     *
     * @param  Request $request
     * @param  int $node
     * @param  int $allocation [description]
     * @return \Illuminate\Http\Response|\Illuminate\Http\JsonResponse
     */
    public function allocationRemoveSingle(Request $request, $node, $allocation)

    {
        $query = Models\Allocation::where('node_id', $node)->whereNull('server_id')->where('id', $allocation)->delete();
        if ($query < 1) {
            return response()->json([
                'error' => 'Unable to find an allocation matching those details to delete.',
            ], 400);
        }

        return response('', 204);
    }

    /**
     * Remove all allocations for a specific IP at once on a node.
     *
     * @param  Request $request
     * @param  int  $node
     * @return \Illuminate\Http\RedirectResponse
     */
    public function allocationRemoveBlock(Request $request, $node)
    {
        $query = Models\Allocation::where('node_id', $node)->whereNull('server_id')->where('ip', $request->input('ip'))->delete();
        if ($query < 1) {
            Alert::danger('There was an error while attempting to delete allocations on that IP.')->flash();
        } else {
            Alert::success('Deleted all unallocated ports for <code>' . $request->input('ip') . '</code>.')->flash();
        }

        return redirect()->route('admin.nodes.view.allocation', $node);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Sets an alias for a specific allocation on a node.
     *
     * @param  Request $request
     * @param  int $node
     * @return \Illuminate\Http\Response
     * @throws \Exception
     */
    public function allocationSetAlias(Request $request, $node)

    {
        if (! $request->input('allocation_id')) {
            return response('Missing required parameters.', 422);
        }

        try {
            $update = Models\Allocation::findOrFail($request->input('allocation_id'));
            $update->ip_alias = (empty($request->input('alias'))) ? null : $request->input('alias');
            $update->save();

            return response('', 204);
        } catch (\Exception $ex) {
            throw $ex;
        }
    }

    /**
     * Creates new allocations on a node.
     *
     * @param  Request $request
     * @param  int  $node
     * @return \Illuminate\Http\RedirectResponse
     */
    public function createAllocation(Request $request, $node)
    {
        $repo = new NodeRepository;

        try {
            $repo->addAllocations($node, $request->intersect(['allocation_ip', 'allocation_alias', 'allocation_ports']));
            Alert::success('Successfully added new allocations!')->flash();
        } catch (DisplayValidationException $ex) {
            return redirect()->route('admin.nodes.view.allocation', $node)->withErrors(json_decode($ex->getMessage()))->withInput();
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } catch (DisplayException $ex) {
            Alert::danger($ex->getMessage())->flash();
        } catch (\Exception $ex) {
            Log::error($ex);
            Alert::danger('An unhandled exception occured while attempting to add allocations this node. This error has been logged.')->flash();
        }

        return redirect()->route('admin.nodes.view.allocation', $node);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Deletes a node from the system.
     *
     * @param  Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\RedirectResponse
     */
    public function delete(Request $request, $id)

    {
        $repo = new NodeRepository;

        try {
            $repo->delete($id);
            Alert::success('Successfully deleted the requested node from the panel.')->flash();

            return redirect()->route('admin.nodes');
        } catch (DisplayException $ex) {
            Alert::danger($ex->getMessage())->flash();
        } catch (\Exception $ex) {
            Log::error($ex);
            Alert::danger('An unhandled exception occured while attempting to delete this node. Please try again.')->flash();
        }

        return redirect()->route('admin.nodes.view', $id);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Returns the configuration token to auto-deploy a node.
     *
     * @param  Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function setToken(Request $request, $id)

    {
        $node = Models\Node::findOrFail($id);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $t = Models\NodeConfigurationToken::create([
            'node_id' => $id,
            'token' => str_random(32),
        ]);

        return response()->json(['token' => $t->token]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}

GitHub Access Token became invalid

Pull Request — develop (#334)

NodesController::createAllocation() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Pterodactyl / Panel

GitHub Access Token became invalid

Pull Request — develop (#334)

NodesController::createAllocation() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
