UuidService::generateShort() - Code Metrics - Pterodactyl/Panel - Measure and Improve Code Quality continuously with Scrutinizer

UuidService::generateShort() A
last analyzed 2017-06-15 01:59 UTC

↳ Parent: UuidService

Complexity

Conditions	4
Paths	4

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.2
c	0
b	0
f	0
cc	4
eloc	9
nc	4
nop	3

<?php
/**
 * Pterodactyl - Panel
 * Copyright (c) 2015 - 2017 Dane Everitt <[email protected]>.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

namespace Pterodactyl\Services;

use DB;
use Uuid;

class UuidService
{
    /**
     * Generate a unique UUID validating against specified table and column.
     * Defaults to `users.uuid`.
     *
     * @param  string  $table
     * @param  string  $field
     * @param  int     $type
     * @return string
     */
    public function generate($table = 'users', $field = 'uuid', $type = 4)
    {
        $return = false;
        do {
            $uuid = Uuid::generate($type);
            if (! DB::table($table)->where($field, $uuid)->exists()) {
                $return = $uuid;
            }
        } while (! $return);

        return (string) $return;
    }

    /**
     * Generates a ShortUUID code which is 8 characters long and is used for identifying servers in the system.
     *
     * @param  string       $table
     * @param  string       $field
     * @param  null|string  $attachedUuid
     * @return string
     */
    public function generateShort($table = 'servers', $field = 'uuidShort', $attachedUuid = null)
    {
        $return = false;
        do {
            $short = (is_null($attachedUuid)) ? substr(Uuid::generate(4), 0, 8) : substr($attachedUuid, 0, 8);
            $attachedUuid = null;

            if (! DB::table($table)->where($field, $short)->exists()) {
                $return = $short;
            }
        } while (! $return);
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false

        return (string) $return;
    }
}


1			<?php
2			/**
3			* Pterodactyl - Panel
4			* Copyright (c) 2015 - 2017 Dane Everitt <[email protected]>.
5			*
6			* Permission is hereby granted, free of charge, to any person obtaining a copy
7			* of this software and associated documentation files (the "Software"), to deal
8			* in the Software without restriction, including without limitation the rights
9			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10			* copies of the Software, and to permit persons to whom the Software is
11			* furnished to do so, subject to the following conditions:
12			*
13			* The above copyright notice and this permission notice shall be included in all
14			* copies or substantial portions of the Software.
15			*
16			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
22			* SOFTWARE.
23			*/
24
25			namespace Pterodactyl\Services;
26
27			use DB;
28			use Uuid;
29
30			class UuidService
31			{
32			/**
33			* Generate a unique UUID validating against specified table and column.
34			* Defaults to `users.uuid`.
35			*
36			* @param string $table
37			* @param string $field
38			* @param int $type
39			* @return string
40			*/
41			public function generate($table = 'users', $field = 'uuid', $type = 4)
42			{
43			$return = false;
44			do {
45			$uuid = Uuid::generate($type);
46			if (! DB::table($table)->where($field, $uuid)->exists()) {
47			$return = $uuid;
48			}
49			} while (! $return);
50
51			return (string) $return;
52			}
53
54			/**
55			* Generates a ShortUUID code which is 8 characters long and is used for identifying servers in the system.
56			*
57			* @param string $table
58			* @param string $field
59			* @param null\|string $attachedUuid
60			* @return string
61			*/
62			public function generateShort($table = 'servers', $field = 'uuidShort', $attachedUuid = null)
63			{
64			$return = false;
65			do {
66			$short = (is_null($attachedUuid)) ? substr(Uuid::generate(4), 0, 8) : substr($attachedUuid, 0, 8);
67			$attachedUuid = null;
68
69			if (! DB::table($table)->where($field, $short)->exists()) {
70			$return = $short;
71			}
72			} while (! $return);
			0 ignored issues – show Bug Best Practice introduced 2016-12-07 22:58 UTC by Report Bug Copy Issue Report The expression `$return` of type `string\|false` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
73
74			return (string) $return;
75			}
76			}
77

Pterodactyl / Panel

GitHub Access Token became invalid

UuidService::generateShort() A last analyzed 2017-06-15 01:59 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

UuidService::generateShort() A
last analyzed 2017-06-15 01:59 UTC