APILogService::log() - Code Metrics - Pterodactyl/Panel - Measure and Improve Code Quality continuously with Scrutinizer

APILogService::log() B
last analyzed 2017-06-15 01:59 UTC

↳ Parent: APILogService

Complexity

Conditions	5
Paths	6

Size

Total Lines	25
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	25
rs	8.439
c	0
b	0
f	0
cc	5
eloc	18
nc	6
nop	3

<?php
/**
 * Pterodactyl - Panel
 * Copyright (c) 2015 - 2017 Dane Everitt <[email protected]>.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

namespace Pterodactyl\Services;

use Log;
use Illuminate\Http\Request;
use Pterodactyl\Models\APILog;

class APILogService
{
    /**
     * Log an API Request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  null|string               $error
     * @param  bool                      $authorized
     * @return void
     */
    public static function log(Request $request, $error = null, $authorized = false)
    {
        if ($request->bearerToken() && ! empty($request->bearerToken())) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            list($public, $hashed) = explode('.', $request->bearerToken());
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
        } else {
            $public = null;
        }

        try {
            $log = APILog::create([
                'authorized' => $authorized,
                'error' => $error,
                'key' => $public,
                'method' => $request->method(),
                'route' => $request->fullUrl(),
                'content' => (empty($request->getContent())) ? null : $request->getContent(),
                'user_agent' => $request->header('User-Agent'),
                'request_ip' => $request->ip(),
            ]);
            $log->save();
        } catch (\Exception $ex) {
            // Simply log it and move on.
            Log::error($ex);
        }
    }
}


1			<?php
2			/**
3			* Pterodactyl - Panel
4			* Copyright (c) 2015 - 2017 Dane Everitt <[email protected]>.
5			*
6			* Permission is hereby granted, free of charge, to any person obtaining a copy
7			* of this software and associated documentation files (the "Software"), to deal
8			* in the Software without restriction, including without limitation the rights
9			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10			* copies of the Software, and to permit persons to whom the Software is
11			* furnished to do so, subject to the following conditions:
12			*
13			* The above copyright notice and this permission notice shall be included in all
14			* copies or substantial portions of the Software.
15			*
16			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
22			* SOFTWARE.
23			*/
24
25			namespace Pterodactyl\Services;
26
27			use Log;
28			use Illuminate\Http\Request;
29			use Pterodactyl\Models\APILog;
30
31			class APILogService
32			{
33			/**
34			* Log an API Request.
35			*
36			* @param \Illuminate\Http\Request $request
37			* @param null\|string $error
38			* @param bool $authorized
39			* @return void
40			*/
41			public static function log(Request $request, $error = null, $authorized = false)
42			{
43			if ($request->bearerToken() && ! empty($request->bearerToken())) {
			0 ignored issues – show Bug Best Practice introduced 2016-12-07 22:58 UTC by Report Bug Copy Issue Report The expression `$request->bearerToken()` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
44			list($public, $hashed) = explode('.', $request->bearerToken());
			0 ignored issues – show Unused Code introduced 2016-12-07 22:58 UTC by Report Bug Copy Issue Report The assignment to `$hashed` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
45			} else {
46			$public = null;
47			}
48
49			try {
50			$log = APILog::create([
51			'authorized' => $authorized,
52			'error' => $error,
53			'key' => $public,
54			'method' => $request->method(),
55			'route' => $request->fullUrl(),
56			'content' => (empty($request->getContent())) ? null : $request->getContent(),
57			'user_agent' => $request->header('User-Agent'),
58			'request_ip' => $request->ip(),
59			]);
60			$log->save();
61			} catch (\Exception $ex) {
62			// Simply log it and move on.
63			Log::error($ex);
64			}
65			}
66			}
67

Pterodactyl / Panel

GitHub Access Token became invalid

APILogService::log() B last analyzed 2017-06-15 01:59 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

APILogService::log() B
last analyzed 2017-06-15 01:59 UTC