Conditions | 9 |
Paths | 16 |
Total Lines | 81 |
Code Lines | 53 |
Lines | 8 |
Ratio | 9.88 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
65 | public function handle() |
||
66 | { |
||
67 | if ($this->option('all')) { |
||
68 | $servers = Server::all(); |
||
69 | } elseif ($this->option('node')) { |
||
70 | $servers = Server::where('node_id', $this->option('node'))->get(); |
||
71 | } elseif ($this->option('server')) { |
||
72 | $servers = Server::where('id', $this->option('server'))->get(); |
||
73 | } else { |
||
74 | $this->error('You must pass a flag to determine which server(s) to rebuild.'); |
||
75 | |||
76 | return; |
||
77 | } |
||
78 | |||
79 | $servers->load('node', 'service', 'option.variables', 'pack'); |
||
80 | |||
81 | $this->line('Beginning processing, do not exit this script.'); |
||
82 | $bar = $this->output->createProgressBar(count($servers)); |
||
83 | $results = collect([]); |
||
84 | foreach ($servers as $server) { |
||
85 | try { |
||
86 | View Code Duplication | $environment = $server->option->variables->map(function ($item, $key) use ($server) { |
|
87 | $display = $server->variables->where('variable_id', $item->id)->pluck('variable_value')->first(); |
||
88 | |||
89 | return [ |
||
90 | 'variable' => $item->env_variable, |
||
91 | 'value' => (! is_null($display)) ? $display : $item->default_value, |
||
92 | ]; |
||
93 | }); |
||
94 | |||
95 | $server->node->guzzleClient([ |
||
96 | 'X-Access-Server' => $server->uuid, |
||
97 | 'X-Access-Token' => $server->node->daemonSecret, |
||
98 | ])->request('PATCH', '/server', [ |
||
99 | 'json' => [ |
||
100 | 'build' => [ |
||
101 | 'image' => $server->image, |
||
102 | 'env|overwrite' => $environment->pluck('value', 'variable')->merge(['STARTUP' => $server->startup]), |
||
103 | ], |
||
104 | 'service' => [ |
||
105 | 'type' => $server->service->folder, |
||
106 | 'option' => $server->option->tag, |
||
107 | 'pack' => ! is_null($server->pack) ? $server->pack->uuid : null, |
||
108 | ], |
||
109 | ], |
||
110 | ]); |
||
111 | |||
112 | $results = $results->merge([ |
||
113 | $server->uuid => [ |
||
114 | 'status' => 'info', |
||
115 | 'messages' => [ |
||
116 | '[✓] Processed rebuild request for ' . $server->uuid, |
||
117 | ], |
||
118 | ], |
||
119 | ]); |
||
120 | } catch (\Exception $ex) { |
||
121 | $results = $results->merge([ |
||
122 | $server->uuid => [ |
||
123 | 'status' => 'error', |
||
124 | 'messages' => [ |
||
125 | '[✗] Failed to process rebuild request for ' . $server->uuid, |
||
126 | $ex->getMessage(), |
||
127 | ], |
||
128 | ], |
||
129 | ]); |
||
130 | } |
||
131 | |||
132 | $bar->advance(); |
||
133 | } |
||
134 | |||
135 | $bar->finish(); |
||
136 | $console = $this; |
||
137 | |||
138 | $this->line("\n"); |
||
139 | $results->each(function ($item, $key) use ($console) { |
||
140 | foreach ($item['messages'] as $line) { |
||
141 | $console->{$item['status']}($line); |
||
142 | } |
||
143 | }); |
||
144 | $this->line("\nCompleted rebuild command processing."); |
||
145 | } |
||
146 | } |
||
147 |
Adding a
@return
annotation to a constructor is not recommended, since a constructor does not have a meaningful return value.Please refer to the PHP core documentation on constructors.