Pterodactyl\Http\Controllers\Base\APIController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	83
Duplicated Lines	26.51 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	6	1
A	create()	0	9	1
B	store()	22	22	4
A	revoke()	0	15	2

<?php
/**
 * Pterodactyl - Panel
 * Copyright (c) 2015 - 2017 Dane Everitt <dane@daneeveritt.com>
 * Some Modifications (c) 2015 Dylan Seidt <dylan.seidt@gmail.com>.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

namespace Pterodactyl\Http\Controllers\Base;

use Log;
use Alert;
use Illuminate\Http\Request;
use Pterodactyl\Models\APIKey;
use Pterodactyl\Models\APIPermission;
use Pterodactyl\Repositories\APIRepository;
use Pterodactyl\Exceptions\DisplayException;
use Pterodactyl\Http\Controllers\Controller;
use Pterodactyl\Exceptions\DisplayValidationException;

class APIController extends Controller
{
    /**
     * Display base API index page.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\View\View
     */
    public function index(Request $request)
    {
        return view('base.api.index', [

The expression view('base.api.index', array('keys' => \Pterodactyl\Models\APIKey::where('user_id', $request->user()->id)->get())); of type Illuminate\View\View|Illuminate\Contracts\View\Factory adds the type Illuminate\Contracts\View\Factory to the return on line 48 which is incompatible with the return type documented by Pterodactyl\Http\Controllers\Base\APIController::index of type Illuminate\View\View.

            'keys' => APIKey::where('user_id', $request->user()->id)->get(),
        ]);
    }

    /**
     * Display API key creation page.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\View\View
     */
    public function create(Request $request)

The parameter $request is not used and could be removed.

    {
        return view('base.api.new', [

The expression view('base.api.new', array('permissions' => array('user' => collect(\Pterodactyl\Models\APIPermission::permissions())->pull('_user'), 'admin' => collect(\Pterodactyl\Models\APIPermission::permissions())->except('_user')->toArray()))); of type Illuminate\View\View|Illuminate\Contracts\View\Factory adds the type Illuminate\Contracts\View\Factory to the return on line 61 which is incompatible with the return type documented by Pterodactyl\Http\Controllers\Base\APIController::create of type Illuminate\View\View.

            'permissions' => [
                'user' => collect(APIPermission::permissions())->pull('_user'),
                'admin' => collect(APIPermission::permissions())->except('_user')->toArray(),
            ],
        ]);
    }

    /**
     * Handle saving new API key.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(Request $request)

This method seems to be duplicated in your project.

    {
        try {
            $repo = new APIRepository($request->user());
            $secret = $repo->create($request->intersect([
                'memo', 'allowed_ips',
                'admin_permissions', 'permissions',
            ]));
            Alert::success('An API Key-Pair has successfully been generated. The API secret for this public key is shown below and will not be shown again.<br /><br /><code>' . $secret . '</code>')->flash();

            return redirect()->route('account.api');
        } catch (DisplayValidationException $ex) {
            return redirect()->route('account.api.new')->withErrors(json_decode($ex->getMessage()))->withInput();
        } catch (DisplayException $ex) {
            Alert::danger($ex->getMessage())->flash();
        } catch (\Exception $ex) {
            Log::error($ex);
            Alert::danger('An unhandled exception occured while attempting to add this API key.')->flash();
        }

        return redirect()->route('account.api.new')->withInput();
    }

    /**
     * Handle revoking API key.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  string                    $key
     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\Response
     */
    public function revoke(Request $request, $key)
    {
        try {
            $repo = new APIRepository($request->user());
            $repo->revoke($key);

            return response('', 204);
        } catch (\Exception $ex) {
            Log::error($ex);

            return response()->json([
                'error' => 'An error occured while attempting to remove this key.',
            ], 503);
        }
    }
}