Pterodactyl\Exceptions\Handler

Complexity

Total Complexity

13

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	report()	0	4	1
A	unauthenticated()	0	8	2
C	render()	0	22	10

<?php

namespace Pterodactyl\Exceptions;

use Log;
use Exception;
use Illuminate\Auth\AuthenticationException;
use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;

class Handler extends ExceptionHandler
{
    /**
     * A list of the exception types that should not be reported.
     *
     * @var array
     */
    protected $dontReport = [
        \Illuminate\Auth\AuthenticationException::class,
        \Illuminate\Auth\Access\AuthorizationException::class,
        \Symfony\Component\HttpKernel\Exception\HttpException::class,
        \Illuminate\Database\Eloquent\ModelNotFoundException::class,
        \Illuminate\Session\TokenMismatchException::class,
        \Illuminate\Validation\ValidationException::class,
    ];

    /**
     * Report or log an exception.
     *
     * This is a great spot to send exceptions to Sentry, Bugsnag, etc.
     *
     * @param  \Exception  $exception
     * @return void
     */
    public function report(Exception $exception)
    {
        return parent::report($exception);
    }

    /**
     * Render an exception into an HTTP response.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Exception                $exception
     * @return \Illuminate\Http\Response
     */
    public function render($request, Exception $exception)
    {
        if ($request->expectsJson() || $request->isJson() || $request->is(...config('pterodactyl.json_routes'))) {
            $exception = $this->prepareException($exception);

            if (config('app.debug') || $this->isHttpException($exception)) {
                $displayError = $exception->getMessage();
            } else {
                $displayError = 'An unhandled exception was encountered with this request.';
            }

            $response = response()->json([
                'error' => $displayError,
                'http_code' => (! $this->isHttpException($exception)) ?: $exception->getStatusCode(),
                'trace' => (! config('app.debug')) ? null : class_basename($exception) . ' in ' . $exception->getFile() . ' on line ' . $exception->getLine(),
            ], ($this->isHttpException($exception)) ? $exception->getStatusCode() : 500, [], JSON_UNESCAPED_SLASHES);

            parent::report($exception);

It seems like you call parent on a different method (report() instead of render()). Are you sure this is correct? If so, you might want to change this to $this->report().

        }

        return (isset($response)) ? $response : parent::render($request, $exception);

The expression isset($response) ? $response : parent::render($request, $exception); of type Illuminate\Http\JsonResponse|Symfony\Component\HttpFoundation\Response adds the type Illuminate\Http\JsonResponse to the return on line 66 which is incompatible with the return type documented by Pterodactyl\Exceptions\Handler::render of type Illuminate\Http\Response.

    }

    /**
     * Convert an authentication exception into an unauthenticated response.
     *
     * @param  \Illuminate\Http\Request                  $request
     * @param  \Illuminate\Auth\AuthenticationException  $exception
     * @return \Illuminate\Http\Response
     */
    protected function unauthenticated($request, AuthenticationException $exception)

The parameter $exception is not used and could be removed.

    {
        if ($request->expectsJson()) {
            return response()->json(['error' => 'Unauthenticated.'], 401);
        }

        return redirect()->guest(route('auth.login'));
    }
}