Psonrie\GeoLocation\Drivers\GeoLocationDb

Complexity

Total Complexity

3

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	url()	0	3	1
A	request()	0	9	2

<?php

namespace Psonrie\GeoLocation\Drivers;

use Psonrie\GeoLocation\Exceptions\AddressNotFoundException;
use Psonrie\GeoLocation\Response;

class GeoLocationDb extends Driver
{
    /**
     * {@inheritdoc}
     */
    protected function url($ip)
    {
        return "https://geolocation-db.com/jsonp/$ip";
    }

    /**
     * {@inheritdoc}
     */
    protected function request($ip)
    {
        $driverResponse = json_decode($this->executeRequest($this->url($ip)), true);

It seems like $this->executeRequest($this->url($ip)) can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

        if (null === $driverResponse) {
            throw new AddressNotFoundException("The IP address {$ip} could not be found.");
        }

        return new Response($driverResponse);
    }
}