Protoqol / Prequel

src/Http/Requests/PrequelDatabaseRequest.php

<?php

namespace Protoqol\Prequel\Http\Requests;

use Illuminate\Foundation\Http\FormRequest;
use Protoqol\Prequel\Classes\Database\DatabaseTraverser;

/**
 * Class PrequelDatabaseRequest
 *
 * @property mixed database
 * @property mixed table
 * @property mixed model
 * @property mixed qualifiedName
 * @package Protoqol\Prequel\Http\Requests
 */
class PrequelDatabaseRequest extends FormRequest
{

    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        return [
            'database'      => 'required|string',
            'table'         => 'required|string',
            'qualifiedName' => 'required|string',
        ];
    }

    /**
     * Get the validator instance for the request.
     *
     * @return \Illuminate\Contracts\Validation\Validator
     */
    public function getValidatorInstance()
    {
        $request = $this->validationData();

        try {
            $request['database'] = $this->route('database');
            $request['table']    = $this->route('table');

            $request['qualifiedName'] = $request['database'].'.'

Are you sure $request['database'] of type Illuminate\Routing\Route|object|string can be used in concatenation?

                .$request['table'];

Are you sure $request['table'] of type Illuminate\Routing\Route|object|string can be used in concatenation?

            $request['model'] = app(DatabaseTraverser::class)
                ->getModel($request['table']);

It seems like $request['table'] can also be of type Illuminate\Routing\Route and object; however, parameter $tableName of Protoqol\Prequel\Classes\Database\DatabaseTraverser::getModel() does only seem to accept null|string, maybe add an additional type check?

        } catch (\Exception $exception) {
            return parent::getValidatorInstance();
        }

        $this->getInputSource()->replace($request);
        return parent::getValidatorInstance();
    }

    /**
     * Get the error messages for the defined validation rules.
     *
     * @return array
     */
    public function messages()
    {
        return [
            'database.required'      => 'Database name is required',
            'table.required'         => 'Table name is required',
            'qualifiedName.required' => 'Could not construct sensible table name.',
        ];
    }
}