LocaleCallback - Code Metrics - Inspection of "Add forLocale() method" - Propaganistas/Laravel-Intl - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a9cf09...3ef192 )

by Propa

created 2017-01-29 09:10 UTC

LocaleCallback A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
dl	0
loc	26
ccs	10
cts	10
cp	1
rs	10
c	0
b	0
f	0
wmc	2
lcom	0
cbo	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	forLocale()	0	15	2

<?php namespace Propaganistas\LaravelIntl\Base;

trait LocaleCallback
{
    /**
     * Temporarily use another locale for the given callback.
     *
     * @param string   $locale
     * @param callable $callback
     * @param string   $fallbackLocale
     * @return mixed
     */
    public function forLocale($locale, callable $callback, $fallbackLocale = '')
    {
        $original = $this->getLocale();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $fallback = $this->getFallbackLocale();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->setLocale($locale);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->setFallbackLocale($fallbackLocale ?: $fallback);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $result = $callback($this);

        $this->setLocale($original);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->setFallbackLocale($fallback);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $result;
    }
}

1		<?php namespace Propaganistas\LaravelIntl\Base;
2
3		trait LocaleCallback
4		{
5		/**
6		* Temporarily use another locale for the given callback.
7		*
8		* @param string $locale
9		* @param callable $callback
10		* @param string $fallbackLocale
11		* @return mixed
12		*/
13	15	public function forLocale($locale, callable $callback, $fallbackLocale = '')
14		{
15	10	$original = $this->getLocale();
		0 ignored issues – show Bug introduced 2017-01-29 09:17 UTC by Report Bug Copy Issue Report It seems like `getLocale()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
16	10	$fallback = $this->getFallbackLocale();
		0 ignored issues – show Bug introduced 2017-01-29 09:17 UTC by Report Bug Copy Issue Report It seems like `getFallbackLocale()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17
18	10	$this->setLocale($locale);
		0 ignored issues – show Bug introduced 2017-01-29 09:17 UTC by Report Bug Copy Issue Report It seems like `setLocale()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19	10	$this->setFallbackLocale($fallbackLocale ?: $fallback);
		0 ignored issues – show Bug introduced 2017-01-29 09:17 UTC by Report Bug Copy Issue Report It seems like `setFallbackLocale()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20
21	10	$result = $callback($this);
22
23	10	$this->setLocale($original);
		0 ignored issues – show Bug introduced 2017-01-29 09:17 UTC by Report Bug Copy Issue Report It seems like `setLocale()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24	10	$this->setFallbackLocale($fallback);
		0 ignored issues – show Bug introduced 2017-01-29 09:17 UTC by Report Bug Copy Issue Report It seems like `setFallbackLocale()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25
26	15	return $result;
27		}
28		}

Propaganistas / Laravel-Intl

Push — master ( a9cf09...3ef192 )

LocaleCallback A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Duplication Side-by-Side

Filter issues like