Number::all() - Code Metrics - Inspection of "Refactoring" - Propaganistas/Laravel-Intl - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#18)

by Propa

created 2018-06-06 06:27 UTC

Number::all() A

↳ Parent: Number

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	5
ccs	2
cts	2
cp	1
crap	1
rs	9.4285
c	0
b	0
f	0

<?php

namespace Propaganistas\LaravelIntl;

use CommerceGuys\Intl\Formatter\NumberFormatter;
use CommerceGuys\Intl\NumberFormat\NumberFormatRepository;
use Illuminate\Support\Arr;
use Propaganistas\LaravelIntl\Contracts\Intl;

class Number extends Intl
{
    /**
     * Array of localized number formatters.
     *
     * @var array
     */
    protected $formatters;

    /**
     * The current locale.
     *
     * @var string $locale
     */
    protected $locale;

    /**
     * The current locale.
     *
     * @var string $locale
     */
    protected $fallbackLocale;

    /**
     * Format a number.
     *
     * @param string|int|float $number
     * @param array $options
     * @return string
     */
    public function format($number, $options = [])
    {
        return $this->formatter()->format($number,
            $this->mergeOptions($options)
        );
    }

    /**
     * Format as percentage.
     *
     * @param string|int|float $number
     * @param array $options
     * @return string
     */
    public function percent($number, $options = [])
    {
        return $this->formatter()->format($number,
            $this->mergeOptions($options, ['style' => 'percent'])
        );
    }

    /**
     * Parse a localized number into native PHP format.
     *
     * @param string|int|float $number
     * @param array $options
     * @return string|false
     */
    public function parse($number, $options = [])
    {
        return $this->formatter()->parse($number,
            $this->mergeOptions($options)
        );
    }

    /**
     * Get the current locale.
     *
     * @return string
     */
    public function getLocale()
    {
        return $this->locale;
    }

    /**
     * Set the current locale.
     *
     * @param $locale
     * @return $this
     */
    public function setLocale($locale)
    {
        $this->locale = $locale;

        $this->load($locale, $this->getFallbackLocale());

        return $this;
    }

    /**
     * Get the fallback locale.
     *
     * @return string
     */
    public function getFallbackLocale()
    {
        return $this->fallbackLocale;
    }

    /**
     * Set the fallback locale.
     *
     * @param $locale
     * @return $this
     */
    public function setFallbackLocale($locale)
    {
        $this->fallbackLocale = $locale;

        $this->load($this->getLocale(), $locale);

        return $this;
    }

    /**
     * Load the format repository for the given locale.
     *
     * @param string $locale
     * @return void
     */
    protected function load($locale, $fallbackLocale)
    {
        $key = $this->getLocalesKey($locale, $fallbackLocale);

        if (! isset($this->repositories[$key])) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->formatters[$key] = new NumberFormatter(new NumberFormatRepository($fallbackLocale), ['locale' => $locale]);
        }
    }

    /**
     * Get the formatter's key.
     *
     * @param string|null $locale
     * @param string|null $fallbackLocale
     * @return string
     */
    protected function getLocalesKey($locale = null, $fallbackLocale = null)

    {
        return implode('|', [
            $locale ?: $this->getLocale(),
            $fallbackLocale ?: $this->getFallbackLocale(),
        ]);
    }

    /**
     * The current number formatter.
     *
     * @return \CommerceGuys\Intl\Formatter\NumberFormatter
     */
    protected function formatter()
    {
        return $this->formatters[$this->getLocalesKey()];
    }

    /**
     * Merges the options array.
     *
     * @param array $options
     * @param array $defaults
     * @return array
     */
    protected function mergeOptions(array $options, array $defaults = [])
    {
        Arr::forget($options, 'locale');

        return $defaults + $options;
    }
}

1			<?php
2
3			namespace Propaganistas\LaravelIntl;
4
5			use CommerceGuys\Intl\Formatter\NumberFormatter;
6			use CommerceGuys\Intl\NumberFormat\NumberFormatRepository;
7			use Illuminate\Support\Arr;
8			use Propaganistas\LaravelIntl\Contracts\Intl;
9
10			class Number extends Intl
11			{
12			/**
13			* Array of localized number formatters.
14			*
15			* @var array
16			*/
17			protected $formatters;
18
19			/**
20			* The current locale.
21			*
22			* @var string $locale
23			*/
24			protected $locale;
25
26			/**
27			* The current locale.
28			*
29			* @var string $locale
30			*/
31			protected $fallbackLocale;
32
33			/**
34			* Format a number.
35			*
36			* @param string\|int\|float $number
37			* @param array $options
38			* @return string
39			*/
40	15		public function format($number, $options = [])
41			{
42	15		return $this->formatter()->format($number,
43	15		$this->mergeOptions($options)
44			);
45			}
46
47			/**
48			* Format as percentage.
49			*
50			* @param string\|int\|float $number
51			* @param array $options
52			* @return string
53			*/
54	3		public function percent($number, $options = [])
55			{
56	3		return $this->formatter()->format($number,
57	3		$this->mergeOptions($options, ['style' => 'percent'])
58			);
59			}
60
61			/**
62			* Parse a localized number into native PHP format.
63			*
64			* @param string\|int\|float $number
65			* @param array $options
66			* @return string\|false
67			*/
68	3		public function parse($number, $options = [])
69			{
70	3		return $this->formatter()->parse($number,
71	3		$this->mergeOptions($options)
72			);
73			}
74
75			/**
76			* Get the current locale.
77			*
78			* @return string
79			*/
80	24		public function getLocale()
81			{
82	24		return $this->locale;
83			}
84
85			/**
86			* Set the current locale.
87			*
88			* @param $locale
89			* @return $this
90			*/
91	24		public function setLocale($locale)
92			{
93	24		$this->locale = $locale;
94
95	24		$this->load($locale, $this->getFallbackLocale());
96
97	24		return $this;
98			}
99
100			/**
101			* Get the fallback locale.
102			*
103			* @return string
104			*/
105	24		public function getFallbackLocale()
106			{
107	24		return $this->fallbackLocale;
108			}
109
110			/**
111			* Set the fallback locale.
112			*
113			* @param $locale
114			* @return $this
115			*/
116	24		public function setFallbackLocale($locale)
117			{
118	24		$this->fallbackLocale = $locale;
119
120	24		$this->load($this->getLocale(), $locale);
121
122	24		return $this;
123			}
124
125			/**
126			* Load the format repository for the given locale.
127			*
128			* @param string $locale
129			* @return void
130			*/
131	24		protected function load($locale, $fallbackLocale)
132			{
133	24		$key = $this->getLocalesKey($locale, $fallbackLocale);
134
135	24	View Code Duplication	if (! isset($this->repositories[$key])) {
			0 ignored issues – show Bug introduced 2018-06-06 06:37 UTC by Report Bug Copy Issue Report The property `repositories` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Duplication introduced 2018-06-06 06:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
136	24		$this->formatters[$key] = new NumberFormatter(new NumberFormatRepository($fallbackLocale), ['locale' => $locale]);
137			}
138	24		}
139
140			/**
141			* Get the formatter's key.
142			*
143			* @param string\|null $locale
144			* @param string\|null $fallbackLocale
145			* @return string
146			*/
147	24	View Code Duplication	protected function getLocalesKey($locale = null, $fallbackLocale = null)
			0 ignored issues – show Duplication introduced 2018-06-06 06:37 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
148			{
149	24		return implode('\|', [
150	24		$locale ?: $this->getLocale(),
151	24		$fallbackLocale ?: $this->getFallbackLocale(),
152			]);
153			}
154
155			/**
156			* The current number formatter.
157			*
158			* @return \CommerceGuys\Intl\Formatter\NumberFormatter
159			*/
160	21		protected function formatter()
161			{
162	21		return $this->formatters[$this->getLocalesKey()];
163			}
164
165			/**
166			* Merges the options array.
167			*
168			* @param array $options
169			* @param array $defaults
170			* @return array
171			*/
172	21		protected function mergeOptions(array $options, array $defaults = [])
173			{
174	21		Arr::forget($options, 'locale');
175
176	21		return $defaults + $options;
177			}
178			}

Propaganistas / Laravel-Intl

Pull Request — master (#18)

Number::all() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like