RoutesWithFakeIds::resolveRouteBinding() - Code Metrics - Inspection of "Use `resolveRouteBinding()` and rename trait" - Propaganistas/Laravel-FakeId - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9b69eb...27cadc )

by Propa

created 2018-07-23 17:21 UTC

RoutesWithFakeIds::resolveRouteBinding() A

↳ Parent: RoutesWithFakeIds

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
ccs	5
cts	5
cp	1
cc	2
nc	2
nop	1
crap	2

<?php namespace Propaganistas\LaravelFakeId;

use Illuminate\Support\Facades\App;
use Exception;

trait RoutesWithFakeIds
{
    /**
     * Get the value of the model's route key.
     *
     * @return mixed
     */
    public function getRouteKey()
    {
        return App::make('fakeid')->encode($this->getKey());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Retrieve model for route model binding
     *
     * @param  mixed  $routeKey
     * @return null|\Illuminate\Database\Eloquent\Model
     */
    public function resolveRouteBinding($routeKey)
    {
        try {
            $key = App::make('fakeid')->decode($routeKey);
        } catch (Exception $e) {
            return null;
        }

        return $this->where($this->getRouteKeyName(), $key)->first();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php namespace Propaganistas\LaravelFakeId;
2
3		use Illuminate\Support\Facades\App;
4		use Exception;
5
6		trait RoutesWithFakeIds
7		{
8		/**
9		* Get the value of the model's route key.
10		*
11		* @return mixed
12		*/
13	9	public function getRouteKey()
14		{
15	9	return App::make('fakeid')->encode($this->getKey());
		0 ignored issues – show Bug introduced 2015-12-03 16:48 UTC by Report Bug Copy Issue Report It seems like `getKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
16		}
17
18		/**
19		* Retrieve model for route model binding
20		*
21		* @param mixed $routeKey
22		* @return null\|\Illuminate\Database\Eloquent\Model
23		*/
24	9	public function resolveRouteBinding($routeKey)
25		{
26		try {
27	9	$key = App::make('fakeid')->decode($routeKey);
28	3	} catch (Exception $e) {
29	3	return null;
30		}
31
32	6	return $this->where($this->getRouteKeyName(), $key)->first();
		0 ignored issues – show Bug introduced 2018-07-23 17:28 UTC by Report Bug Copy Issue Report The method `getRouteKeyName()` does not exist on `Propaganistas\LaravelFakeId\RoutesWithFakeIds`. Did you maybe mean `getRouteKey()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history... Bug introduced 2018-07-23 17:28 UTC by Report Bug Copy Issue Report It seems like `where()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
33		}
34		}
35

Propaganistas / Laravel-FakeId

Push — master ( 9b69eb...27cadc )

RoutesWithFakeIds::resolveRouteBinding() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like