FakeIdServiceProvider::registerRouterMacro() - Code Metrics - Inspection of "Throw NotFoundHttpException when debug is disabled..." - Propaganistas/Laravel-FakeId - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b3d16e...13cecf )

by Propa

created 2017-04-12 15:49 UTC

FakeIdServiceProvider::registerRouterMacro() C

↳ Parent: FakeIdServiceProvider

Complexity

Conditions	7
Paths	1

Size

Total Lines	37
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	7.0099

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	37
ccs	16
cts	17
cp	0.9412
rs	6.7272
cc	7
eloc	16
nc	1
nop	0
crap	7.0099

<?php namespace Propaganistas\LaravelFakeId;

use Closure;
use Illuminate\Support\ServiceProvider;
use Jenssegers\Optimus\Optimus;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class FakeIdServiceProvider extends ServiceProvider
{
    /**
     * Boots the service provider.
     *
     * @return void
     */
    public function boot()
    {
        // Publish config.
        $this->publishes([
            __DIR__ . '/../config/config.php' => config_path('fakeid.php'),
        ], 'config');
    }

    /**
     * Register the service provider.
     *
     * @return void
     */
    public function register()
    {
        // Merge default config.
        $this->mergeConfigFrom(__DIR__ . '/../config/config.php', 'fakeid');

        // Register setup command.
        $this->app->singleton('fakeid.command.setup', function ($app) {

            return new Commands\FakeIdSetupCommand();
        });
        $this->commands('fakeid.command.setup');

        // Register FakeId driver.
        $this->app->singleton('Jenssegers\Optimus\Optimus', function ($app) {
            return new Optimus(
                $app['config']['fakeid.prime'],
                $app['config']['fakeid.inverse'],
                $app['config']['fakeid.random']
            );
        });

        $this->app->alias('Jenssegers\Optimus\Optimus', 'optimus');
        $this->app->alias('Jenssegers\Optimus\Optimus', 'fakeid');

        $this->registerRouterMacro();
    }

    /**
     * Register the custom router macro.
     */
    protected function registerRouterMacro()
    {
        $this->app['router']->macro('fakeIdModel', function ($key, $class, Closure $callback = null) {
            $this->bind($key, function ($value) use ($key, $class, $callback) {

                if (is_null($value)) {
                    return;
                }

                // For model binders, we will attempt to retrieve the models using the first
                // method on the model instance. If we cannot retrieve the models we'll
                // throw a not found exception otherwise we will return the instance.
                $instance = $this->container->make($class);
class MyClass { }

$x = new MyClass();
$x->foo = true;

                // Decode FakeId first if applicable.
                if (in_array('Propaganistas\LaravelFakeId\FakeIdTrait', class_uses_recursive($class))) {
                    try {
                        $value = $this->container->make('fakeid')->decode($value);
                    } catch (\InvalidArgumentException $e) {
                        throw config('app.debug') ? $e : new NotFoundHttpException;
                    }
                }

                if ($model = $instance->where($instance->getRouteKeyName(), $value)->first()) {
                    return $model;
                }

                // If a callback was supplied to the method we will call that to determine
                // what we should do when the model is not found. This just gives these
                // developer a little greater flexibility to decide what will happen.
                if ($callback instanceof Closure) {
                    return call_user_func($callback, $value);
                }

                throw new NotFoundHttpException;
            });
        });
    }

}


1		<?php namespace Propaganistas\LaravelFakeId;
2
3		use Closure;
4		use Illuminate\Support\ServiceProvider;
5		use Jenssegers\Optimus\Optimus;
6		use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
7
8		class FakeIdServiceProvider extends ServiceProvider
9		{
10		/**
11		* Boots the service provider.
12		*
13		* @return void
14		*/
15	27	public function boot()
16		{
17		// Publish config.
18	27	$this->publishes([
19	27	__DIR__ . '/../config/config.php' => config_path('fakeid.php'),
20	27	], 'config');
21	27	}
22
23		/**
24		* Register the service provider.
25		*
26		* @return void
27		*/
28	27	public function register()
29		{
30		// Merge default config.
31	27	$this->mergeConfigFrom(__DIR__ . '/../config/config.php', 'fakeid');
32
33		// Register setup command.
34		$this->app->singleton('fakeid.command.setup', function ($app) {
		0 ignored issues – show Unused Code introduced 2015-12-03 16:48 UTC by Report Bug Copy Issue Report The parameter `$app` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
35		return new Commands\FakeIdSetupCommand();
36	27	});
37	27	$this->commands('fakeid.command.setup');
38
39		// Register FakeId driver.
40		$this->app->singleton('Jenssegers\Optimus\Optimus', function ($app) {
41	21	return new Optimus(
42	21	$app['config']['fakeid.prime'],
43	21	$app['config']['fakeid.inverse'],
44	21	$app['config']['fakeid.random']
45	21	);
46	27	});
47
48	27	$this->app->alias('Jenssegers\Optimus\Optimus', 'optimus');
49	27	$this->app->alias('Jenssegers\Optimus\Optimus', 'fakeid');
50
51	27	$this->registerRouterMacro();
52	27	}
53
54		/**
55		* Register the custom router macro.
56		*/
57		protected function registerRouterMacro()
58		{
59		$this->app['router']->macro('fakeIdModel', function ($key, $class, Closure $callback = null) {
60	27	$this->bind($key, function ($value) use ($key, $class, $callback) {
		0 ignored issues – show Bug introduced 2016-09-13 20:58 UTC by Report Bug Copy Issue Report The method `bind()` does not seem to exist on `object<Propaganistas\Lar...\FakeIdServiceProvider>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
61	12	if (is_null($value)) {
62	9	return;
63		}
64
65		// For model binders, we will attempt to retrieve the models using the first
66		// method on the model instance. If we cannot retrieve the models we'll
67		// throw a not found exception otherwise we will return the instance.
68	12	$instance = $this->container->make($class);
		0 ignored issues – show Bug introduced 2016-08-03 20:51 UTC by Report Bug Copy Issue Report The property `container` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
69
70		// Decode FakeId first if applicable.
71	12	if (in_array('Propaganistas\LaravelFakeId\FakeIdTrait', class_uses_recursive($class))) {
72		try {
73	12	$value = $this->container->make('fakeid')->decode($value);
74	12	} catch (\InvalidArgumentException $e) {
75	6	throw config('app.debug') ? $e : new NotFoundHttpException;
76		}
77	6	}
78
79	6	if ($model = $instance->where($instance->getRouteKeyName(), $value)->first()) {
80	3	return $model;
81		}
82
83		// If a callback was supplied to the method we will call that to determine
84		// what we should do when the model is not found. This just gives these
85		// developer a little greater flexibility to decide what will happen.
86	3	if ($callback instanceof Closure) {
87		return call_user_func($callback, $value);
88		}
89
90	3	throw new NotFoundHttpException;
91	27	});
92	27	});
93	27	}
94
95		}
96

Propaganistas / Laravel-FakeId

Push — master ( b3d16e...13cecf )

FakeIdServiceProvider::registerRouterMacro() C

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like