UserViewSet.me() - Code Metrics - Inspection of "Improve profile edition" - ProjetSigma/backend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

by Camille

created 2015-12-22 23:23 UTC

UserViewSet.me() A

↳ Parent: UserViewSet

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	2
dl	0
loc	10
rs	9.4286

from rest_framework import viewsets, decorators, status
from rest_framework.response import Response
from dry_rest_permissions.generics import DRYPermissions

from sigma_core.models.user import User
from sigma_core.serializers.user import UserSerializer, UserWithoutNamesSerializer


class UserViewSet(viewsets.ModelViewSet):
    permission_classes = (DRYPermissions, )
    queryset = User.objects.all()

    def get_serializer_class(self):
        """
        Users cannot change their lastname and firstname, but admins can.
        """
        if self.request.method == 'PUT' and not (self.request.user.is_staff or self.request.user.is_superuser):
            return UserWithoutNamesSerializer
        else:
            return UserSerializer

    @decorators.list_route(methods=['get'])
    def me(self, request):
        """
        Gives the data of the current user
        """
        if request.user.__class__.__name__ == 'AnonymousUser':
            return Response(status=status.HTTP_401_UNAUTHORIZED)
        else:
            serializer = self.get_serializer_class()(request.user, context={'request': request})
            return Response(serializer.data)


1			from rest_framework import viewsets, decorators, status
2			from rest_framework.response import Response
3			from dry_rest_permissions.generics import DRYPermissions
4
5			from sigma_core.models.user import User
6			from sigma_core.serializers.user import UserSerializer, UserWithoutNamesSerializer
7
8
9			class UserViewSet(viewsets.ModelViewSet):
10			permission_classes = (DRYPermissions, )
11			queryset = User.objects.all()
12
13			def get_serializer_class(self):
14			"""
15			Users cannot change their lastname and firstname, but admins can.
16			"""
17			if self.request.method == 'PUT' and not (self.request.user.is_staff or self.request.user.is_superuser):
18			return UserWithoutNamesSerializer
19			else:
20			return UserSerializer
21
22			@decorators.list_route(methods=['get'])
23			def me(self, request):
24			"""
25			Gives the data of the current user
26			"""
27			if request.user.__class__.__name__ == 'AnonymousUser':
28			return Response(status=status.HTTP_401_UNAUTHORIZED)
29			else:
30			serializer = self.get_serializer_class()(request.user, context={'request': request})
31			return Response(serializer.data)
32

ProjetSigma / backend

Pull Request — master (#11)

UserViewSet.me() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like