ClusterTests.test_update_cluster_ok_staff() - Code Metrics - Inspection of "Feature/130 cluster permissions" - ProjetSigma/backend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#24)

unknown

created 2016-02-11 23:06 UTC

ClusterTests.test_update_cluster_ok_staff() A

↳ Parent: ClusterTests

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	1
dl	0
loc	6
rs	9.4285

from rest_framework import status
from rest_framework.test import APITestCase, force_authenticate

from sigma_core.models.group import Group
from sigma_core.models.cluster import Cluster
from sigma_core.serializers.group import GroupSerializer
from sigma_core.serializers.cluster import BasicClusterSerializer
from sigma_core.tests.factories import UserFactory, GroupFactory, GroupMemberFactory, ClusterFactory


def reload(obj):
    return obj.__class__.objects.get(pk=obj.pk)


class ClusterTests(APITestCase):
    @classmethod
    def setUpTestData(self):
        super().setUpTestData()

        # Clusters
        self.clusters = ClusterFactory.create_batch(2)

        # Users
        self.users = UserFactory.create_batch(4)
        self.users[2].is_staff = True # Sigma admin
        self.users[2].save()

        # Memberships
        self.member1 = GroupMemberFactory(user=self.users[0], group=self.clusters[0], perm_rank=Group.ADMINISTRATOR_RANK)
        self.member2 = GroupMemberFactory(user=self.users[1], group=self.clusters[0], perm_rank=1)

        serializer = BasicClusterSerializer(self.clusters[0])
        self.cluster_data = serializer.data
        self.clusters_url = "/cluster/"
        self.cluster_url = self.clusters_url + "%d/"

        self.new_cluster_data = {"name": "Ecole polytechnique", "design": "default"}
        # self.invite_data = {"user": self.users[0].id}

    #### List requests
    def test_get_clusters_list_unauthed(self):
        # Client not authenticated but can see clusters list
        response = self.client.get(self.clusters_url)
        self.assertEqual(response.status_code, status.HTTP_200_OK)
        self.assertEqual(len(response.data), len(self.clusters))

    def test_get_clusters_list_ok(self):
        self.client.force_authenticate(user=self.users[0])
        response = self.client.get(self.clusters_url)
        self.assertEqual(response.status_code, status.HTTP_200_OK)
        self.assertEqual(len(response.data), len(self.clusters))

    #### Get requests
    def test_get_cluster_unauthed(self):
        # Client is not authenticated, can see cluster data but cannot see cluster details (especially members)
        response = self.client.get(self.cluster_url % self.clusters[0].id)
        self.assertEqual(response.status_code, status.HTTP_200_OK)
        self.assertEqual(response.data.get('users', None), None)

    def test_get_cluster_forbidden(self):
        # Client wants to see a cluster whose he is not member of
        self.client.force_authenticate(user=self.users[0])
        response = self.client.get(self.cluster_url % self.clusters[1].id)
        self.assertEqual(response.status_code, status.HTTP_200_OK)
        self.assertEqual(response.data.get('users', None), None)

    def test_get_cluster_ok(self):
        # Client wants to see a cluster to which he belongs
        self.client.force_authenticate(user=self.users[1])
        response = self.client.get(self.cluster_url % self.clusters[0].id)
        self.assertEqual(response.status_code, status.HTTP_200_OK)
        self.assertEqual(response.data.get('name', None), self.cluster_data['name'])

    #### Create requests
    def test_create_cluster_unauthed(self):
        response = self.client.post(self.clusters_url, self.new_cluster_data)
        self.assertEqual(response.status_code, status.HTTP_401_UNAUTHORIZED)

    def test_create_cluster_forbidden(self):
        self.client.force_authenticate(user=self.users[0])
        response = self.client.post(self.clusters_url, self.new_cluster_data)
        self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)

    def test_create_cluster_wrong_data(self):
        self.client.force_authenticate(user=self.users[2])
        response = self.client.post(self.clusters_url, {"name": ""})
        self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)

    def test_create_cluster_ok(self):
        self.client.force_authenticate(user=self.users[2])
        response = self.client.post(self.clusters_url, self.new_cluster_data)
        self.assertEqual(response.status_code, status.HTTP_201_CREATED)
        cluster = Cluster.objects.filter(pk=response.data['id']).get()
        self.assertEqual(cluster.name, "Ecole polytechnique")
        self.assertEqual(cluster.private, False)
        self.assertEqual(cluster.default_member_rank, -1)
        self.assertEqual(cluster.req_rank_invite, Group.ADMINISTRATOR_RANK)

    #### Modification requests
    def test_update_cluster_unauthed(self):
        self.cluster_data['name'] = "Ecole polytechnique"
        response = self.client.put(self.cluster_url % self.cluster_data['id'], self.cluster_data)
        self.assertEqual(response.status_code, status.HTTP_401_UNAUTHORIZED)

    def test_update_cluster_forbidden_1(self):
        self.client.force_authenticate(user=self.users[3])
        self.cluster_data['name'] = "Ecole polytechnique"
        response = self.client.put(self.cluster_url % self.cluster_data['id'], self.cluster_data)
        self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)

    def test_update_cluster_forbidden_2(self):
        self.client.force_authenticate(user=self.users[1])
        self.cluster_data['name'] = "Ecole polytechnique"
        response = self.client.put(self.cluster_url % self.cluster_data['id'], self.cluster_data)
        self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)

    def test_update_cluster_wrong_data(self):
        self.client.force_authenticate(user=self.users[2])
        self.cluster_data['name'] = ""
        response = self.client.put(self.cluster_url % self.cluster_data['id'], self.cluster_data)
        self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)

    def test_update_cluster_ok_staff(self):

        self.client.force_authenticate(user=self.users[2])
        self.cluster_data['name'] = "Ecole polytechnique"
        response = self.client.put(self.cluster_url % self.cluster_data['id'], self.cluster_data)
        self.assertEqual(response.status_code, status.HTTP_200_OK)
        self.assertEqual(response.data['name'], "Ecole polytechnique")

    def test_update_cluster_ok_cluster_admin(self):

        self.client.force_authenticate(user=self.users[0])
        self.cluster_data['name'] = "Ecole polytechnique"
        response = self.client.put(self.cluster_url % self.cluster_data['id'], self.cluster_data)
        self.assertEqual(response.status_code, status.HTTP_200_OK)
        self.assertEqual(response.data['name'], "Ecole polytechnique")

    #### Invitation process

    #### Deletion requests


1			from rest_framework import status
2			from rest_framework.test import APITestCase, force_authenticate
3
4			from sigma_core.models.group import Group
5			from sigma_core.models.cluster import Cluster
6			from sigma_core.serializers.group import GroupSerializer
7			from sigma_core.serializers.cluster import BasicClusterSerializer
8			from sigma_core.tests.factories import UserFactory, GroupFactory, GroupMemberFactory, ClusterFactory
9
10
11			def reload(obj):
12			return obj.__class__.objects.get(pk=obj.pk)
13
14
15			class ClusterTests(APITestCase):
16			@classmethod
17			def setUpTestData(self):
18			super().setUpTestData()
19
20			# Clusters
21			self.clusters = ClusterFactory.create_batch(2)
22
23			# Users
24			self.users = UserFactory.create_batch(4)
25			self.users[2].is_staff = True # Sigma admin
26			self.users[2].save()
27
28			# Memberships
29			self.member1 = GroupMemberFactory(user=self.users[0], group=self.clusters[0], perm_rank=Group.ADMINISTRATOR_RANK)
30			self.member2 = GroupMemberFactory(user=self.users[1], group=self.clusters[0], perm_rank=1)
31
32			serializer = BasicClusterSerializer(self.clusters[0])
33			self.cluster_data = serializer.data
34			self.clusters_url = "/cluster/"
35			self.cluster_url = self.clusters_url + "%d/"
36
37			self.new_cluster_data = {"name": "Ecole polytechnique", "design": "default"}
38			# self.invite_data = {"user": self.users[0].id}
39
40			#### List requests
41			def test_get_clusters_list_unauthed(self):
42			# Client not authenticated but can see clusters list
43			response = self.client.get(self.clusters_url)
44			self.assertEqual(response.status_code, status.HTTP_200_OK)
45			self.assertEqual(len(response.data), len(self.clusters))
46
47			def test_get_clusters_list_ok(self):
48			self.client.force_authenticate(user=self.users[0])
49			response = self.client.get(self.clusters_url)
50			self.assertEqual(response.status_code, status.HTTP_200_OK)
51			self.assertEqual(len(response.data), len(self.clusters))
52
53			#### Get requests
54			def test_get_cluster_unauthed(self):
55			# Client is not authenticated, can see cluster data but cannot see cluster details (especially members)
56			response = self.client.get(self.cluster_url % self.clusters[0].id)
57			self.assertEqual(response.status_code, status.HTTP_200_OK)
58			self.assertEqual(response.data.get('users', None), None)
59
60			def test_get_cluster_forbidden(self):
61			# Client wants to see a cluster whose he is not member of
62			self.client.force_authenticate(user=self.users[0])
63			response = self.client.get(self.cluster_url % self.clusters[1].id)
64			self.assertEqual(response.status_code, status.HTTP_200_OK)
65			self.assertEqual(response.data.get('users', None), None)
66
67			def test_get_cluster_ok(self):
68			# Client wants to see a cluster to which he belongs
69			self.client.force_authenticate(user=self.users[1])
70			response = self.client.get(self.cluster_url % self.clusters[0].id)
71			self.assertEqual(response.status_code, status.HTTP_200_OK)
72			self.assertEqual(response.data.get('name', None), self.cluster_data['name'])
73
74			#### Create requests
75			def test_create_cluster_unauthed(self):
76			response = self.client.post(self.clusters_url, self.new_cluster_data)
77			self.assertEqual(response.status_code, status.HTTP_401_UNAUTHORIZED)
78
79			def test_create_cluster_forbidden(self):
80			self.client.force_authenticate(user=self.users[0])
81			response = self.client.post(self.clusters_url, self.new_cluster_data)
82			self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
83
84			def test_create_cluster_wrong_data(self):
85			self.client.force_authenticate(user=self.users[2])
86			response = self.client.post(self.clusters_url, {"name": ""})
87			self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
88
89			def test_create_cluster_ok(self):
90			self.client.force_authenticate(user=self.users[2])
91			response = self.client.post(self.clusters_url, self.new_cluster_data)
92			self.assertEqual(response.status_code, status.HTTP_201_CREATED)
93			cluster = Cluster.objects.filter(pk=response.data['id']).get()
94			self.assertEqual(cluster.name, "Ecole polytechnique")
95			self.assertEqual(cluster.private, False)
96			self.assertEqual(cluster.default_member_rank, -1)
97			self.assertEqual(cluster.req_rank_invite, Group.ADMINISTRATOR_RANK)
98
99			#### Modification requests
100			def test_update_cluster_unauthed(self):
101			self.cluster_data['name'] = "Ecole polytechnique"
102			response = self.client.put(self.cluster_url % self.cluster_data['id'], self.cluster_data)
103			self.assertEqual(response.status_code, status.HTTP_401_UNAUTHORIZED)
104
105			def test_update_cluster_forbidden_1(self):
106			self.client.force_authenticate(user=self.users[3])
107			self.cluster_data['name'] = "Ecole polytechnique"
108			response = self.client.put(self.cluster_url % self.cluster_data['id'], self.cluster_data)
109			self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)
110
111			def test_update_cluster_forbidden_2(self):
112			self.client.force_authenticate(user=self.users[1])
113			self.cluster_data['name'] = "Ecole polytechnique"
114			response = self.client.put(self.cluster_url % self.cluster_data['id'], self.cluster_data)
115			self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)
116
117			def test_update_cluster_wrong_data(self):
118			self.client.force_authenticate(user=self.users[2])
119			self.cluster_data['name'] = ""
120			response = self.client.put(self.cluster_url % self.cluster_data['id'], self.cluster_data)
121			self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
122
123			def test_update_cluster_ok_staff(self):
			0 ignored issues – show Duplication introduced 2016-02-11 17:22 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
124			self.client.force_authenticate(user=self.users[2])
125			self.cluster_data['name'] = "Ecole polytechnique"
126			response = self.client.put(self.cluster_url % self.cluster_data['id'], self.cluster_data)
127			self.assertEqual(response.status_code, status.HTTP_200_OK)
128			self.assertEqual(response.data['name'], "Ecole polytechnique")
129
130			def test_update_cluster_ok_cluster_admin(self):
			0 ignored issues – show Duplication introduced 2016-02-11 17:22 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
131			self.client.force_authenticate(user=self.users[0])
132			self.cluster_data['name'] = "Ecole polytechnique"
133			response = self.client.put(self.cluster_url % self.cluster_data['id'], self.cluster_data)
134			self.assertEqual(response.status_code, status.HTTP_200_OK)
135			self.assertEqual(response.data['name'], "Ecole polytechnique")
136
137			#### Invitation process
138
139			#### Deletion requests
140

ProjetSigma / backend

Pull Request — master (#24)

ClusterTests.test_update_cluster_ok_staff() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like