ProjetSigma /
backend
| Conditions | 5 |
| Total Lines | 52 |
| Lines | 0 |
| Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | import json |
||
| 60 | @classmethod |
||
| 61 | def setUpTestData(self): |
||
| 62 | super(APITestCase, self).setUpTestData() |
||
| 63 | |||
| 64 | # Routes |
||
| 65 | self.members_url = "/group-member/" |
||
| 66 | self.member_url = self.members_url + "%d/" |
||
| 67 | |||
| 68 | # Group with membership request |
||
| 69 | self.group = GroupFactory() |
||
| 70 | self.group.default_member_rank = 0 |
||
| 71 | self.group.req_rank_accept_join_requests = 5 |
||
| 72 | self.group.save() |
||
| 73 | |||
| 74 | # Users already in group |
||
| 75 | self.users = UserFactory.create_batch(3) |
||
| 76 | # Associated GroupMember |
||
| 77 | self.group_member1 = GroupMember(user=self.users[0], group=self.group, perm_rank=Group.ADMINISTRATOR_RANK) # can validate requests |
||
| 78 | self.group_member2 = GroupMember(user=self.users[1], group=self.group, perm_rank=1) # cannot validate requests |
||
| 79 | self.group_member3 = GroupMember(user=self.users[2], group=self.group, perm_rank=0) # request to be validated |
||
| 80 | |||
| 81 | # Testing user |
||
| 82 | self.user = UserFactory() |
||
| 83 | |||
| 84 | # Misc |
||
| 85 | self.new_membership_data = {"group": self.group.id, "user": self.user.id} |
||
| 86 | |||
| 87 | def test_create_not_authed(self): |
||
| 88 | self.client.force_authenticate(user=None) |
||
| 89 | response = self.client.post(self.members_url, self.new_membership_data) |
||
| 90 | self.assertEqual(response.status_code, status.HTTP_401_UNAUTHORIZED) |
||
| 91 | |||
| 92 | def test_create_success(self): |
||
| 93 | # Succesful attempt to request group membership |
||
| 94 | self.client.force_authenticate(user=self.user) |
||
| 95 | response = self.client.post(self.members_url, self.new_membership_data) |
||
| 96 | self.assertEqual(response.status_code, status.HTTP_201_CREATED) |
||
| 97 | self.assertEqual(response.data['perm_rank'], self.group.default_member_rank) |
||
| 98 | |||
| 99 | def test_validate_forbidden(self): |
||
| 100 | # Attempt to validate a request but not enough permission |
||
| 101 | self.client.force_authenticate(user=self.users[1]) |
||
| 102 | response = self.client.put(self.member_url + "accept_join_request/" % self.group_member3.id, {}) |
||
| 103 | self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN) |
||
| 104 | self.assertEqual(response.data['perm_rank'], 0) |
||
| 105 | |||
| 106 | def test_validate_success(self): |
||
| 107 | # Succesful attempt to validate a request |
||
| 108 | self.client.force_authenticate(user=self.users[0]) |
||
| 109 | response = self.client.put(self.member_url + "accept_join_request/" % self.group_member3.id, {}) |
||
| 110 | self.assertEqual(response.status_code, status.HTTP_200_OK) |
||
| 111 | self.assertEqual(response.data['perm_rank'], 1) |
||
| 112 | |||
| 144 |
