MongoDBTest::testMongoDbStore() - Code Metrics - Inspection of "Adds supports for WikibaseDataModel 5 and 6" - ProjetPP/WikibaseEntityStore - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#18)

by Thomas

created 2016-04-07 15:38 UTC

MongoDBTest::testMongoDbStore() A

↳ Parent: MongoDBTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	60
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	11
Bugs	0	Features	5

Metric	Value
c	11
b	0
f	5
dl	0
loc	60
rs	9.5555
cc	2
eloc	37
nc	2
nop	0

How to fix Long Method

<?php

namespace Wikibase\EntityStore;

use Ask\Language\Description\AnyValue;
use Ask\Language\Description\SomeProperty;
use Ask\Language\Description\ValueDescription;
use Ask\Language\Option\QueryOptions;
use DataValues\StringValue;
use MongoConnectionException;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Output\NullOutput;
use Wikibase\DataModel\Entity\EntityIdValue;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Entity\PropertyId;
use Wikibase\DataModel\Term\Term;
use Wikibase\EntityStore\Config\EntityStoreFromConfigurationBuilder;
use Wikibase\EntityStore\Console\CliApplicationFactory;

/**
 * @licence GNU GPL v2+
 * @author Thomas Pellissier Tanon
 */
class MongoDBTest extends \PHPUnit_Framework_TestCase {

	public function testMongoDbStore() {
		try {
			$this->setupMongoDb();
		} catch( MongoConnectionException $e ) {
			$this->markTestSkipped( 'MongoDB is not running: ' . $e->getMessage() );
			return;
		}

		$store = $this->getEntityStoreFromConfiguration();

		$this->assertEquals(
			new ItemId( 'Q1' ),
			$store->getItemLookup()->getItemForId( new ItemId( 'Q1' ) )->getId()
		);

		$this->assertEquals(
			new PropertyId( 'P1' ),
			$store->getPropertyLookup()->getPropertyForId( new PropertyId( 'P1' ) )->getId()
		);

		$results = $store->getEntityDocumentLookup()->getEntityDocumentsForIds(
			[ new ItemId( 'Q1' ), new ItemId( 'Q1000' ) ]
		);
		$this->assertEquals( 1, count( $results ) );
		$this->assertEquals( new ItemId( 'Q1' ), $results[0]->getId() );

		$this->assertEquals(
			[ new ItemId( 'Q1' ) ],
			$store->getItemIdForTermLookup()->getItemIdsForTerm( new Term( 'en', 'universe' ) )
		);

		$this->assertEquals(
			[],
			$store->getItemIdForTermLookup()->getItemIdsForTerm( new Term( 'pl', 'Kosmos' ) )
		);

		$this->assertEquals(
			[ new PropertyId( 'P16' ) ],
			$store->getPropertyIdForTermLookup()->getPropertyIdsForTerm( new Term( 'en', 'highway system' ) )
		);

		$this->assertEquals(
			[ new PropertyId( 'P16' ) ],
			$store->getPropertyIdForQueryLookup()->getPropertyIdsForQuery(
				new AnyValue(),
				new QueryOptions( 1, 0 )
			)
		);

		$this->assertEquals(
			[ new ItemId( 'Q1' ) ],
			$store->getItemIdForQueryLookup()->getItemIdsForQuery(
				new SomeProperty(
					new EntityIdValue( new PropertyId( 'P18' ) ),
					new ValueDescription( new StringValue( 'Hubble ultra deep field.jpg' ) )
				),
				new QueryOptions( 10, 0 )
			)
		);
	}

	private function setupMongoDb() {
		$this->importCommand( 'import-json-dump', 'valid.json' );
		$this->importCommand( 'import-incremental-xml-dump', 'valid-incremental.xml' );
	}

	private function importCommand( $command, $file ) {
		$applicationFactory = new CliApplicationFactory();
		$importCommand = $applicationFactory->newApplication()->find( $command );
		$input = new ArrayInput( [
			'command' => $command,
			'file' => __DIR__ . '/../data/' . $file,
			'configuration' => __DIR__ . '/../data/valid-config-mongodb.json'
		] );
		$importCommand->run( $input, new NullOutput() );
	}

	private function getEntityStoreFromConfiguration() {
		$configBuilder = new EntityStoreFromConfigurationBuilder();
		return $configBuilder->buildEntityStore( __DIR__ . '/../data/valid-config-mongodb.json' );
	}
}


1			<?php
2
3			namespace Wikibase\EntityStore;
4
5			use Ask\Language\Description\AnyValue;
6			use Ask\Language\Description\SomeProperty;
7			use Ask\Language\Description\ValueDescription;
8			use Ask\Language\Option\QueryOptions;
9			use DataValues\StringValue;
10			use MongoConnectionException;
11			use Symfony\Component\Console\Input\ArrayInput;
12			use Symfony\Component\Console\Output\NullOutput;
13			use Wikibase\DataModel\Entity\EntityIdValue;
14			use Wikibase\DataModel\Entity\ItemId;
15			use Wikibase\DataModel\Entity\PropertyId;
16			use Wikibase\DataModel\Term\Term;
17			use Wikibase\EntityStore\Config\EntityStoreFromConfigurationBuilder;
18			use Wikibase\EntityStore\Console\CliApplicationFactory;
19
20			/**
21			* @licence GNU GPL v2+
22			* @author Thomas Pellissier Tanon
23			*/
24			class MongoDBTest extends \PHPUnit_Framework_TestCase {
25
26			public function testMongoDbStore() {
27			try {
28			$this->setupMongoDb();
29			} catch( MongoConnectionException $e ) {
30			$this->markTestSkipped( 'MongoDB is not running: ' . $e->getMessage() );
31			return;
32			}
33
34			$store = $this->getEntityStoreFromConfiguration();
35
36			$this->assertEquals(
37			new ItemId( 'Q1' ),
38			$store->getItemLookup()->getItemForId( new ItemId( 'Q1' ) )->getId()
39			);
40
41			$this->assertEquals(
42			new PropertyId( 'P1' ),
43			$store->getPropertyLookup()->getPropertyForId( new PropertyId( 'P1' ) )->getId()
44			);
45
46			$results = $store->getEntityDocumentLookup()->getEntityDocumentsForIds(
47			[ new ItemId( 'Q1' ), new ItemId( 'Q1000' ) ]
48			);
49			$this->assertEquals( 1, count( $results ) );
50			$this->assertEquals( new ItemId( 'Q1' ), $results[0]->getId() );
51
52			$this->assertEquals(
53			[ new ItemId( 'Q1' ) ],
54			$store->getItemIdForTermLookup()->getItemIdsForTerm( new Term( 'en', 'universe' ) )
55			);
56
57			$this->assertEquals(
58			[],
59			$store->getItemIdForTermLookup()->getItemIdsForTerm( new Term( 'pl', 'Kosmos' ) )
60			);
61
62			$this->assertEquals(
63			[ new PropertyId( 'P16' ) ],
64			$store->getPropertyIdForTermLookup()->getPropertyIdsForTerm( new Term( 'en', 'highway system' ) )
65			);
66
67			$this->assertEquals(
68			[ new PropertyId( 'P16' ) ],
69			$store->getPropertyIdForQueryLookup()->getPropertyIdsForQuery(
70			new AnyValue(),
71			new QueryOptions( 1, 0 )
72			)
73			);
74
75			$this->assertEquals(
76			[ new ItemId( 'Q1' ) ],
77			$store->getItemIdForQueryLookup()->getItemIdsForQuery(
78			new SomeProperty(
79			new EntityIdValue( new PropertyId( 'P18' ) ),
80			new ValueDescription( new StringValue( 'Hubble ultra deep field.jpg' ) )
81			),
82			new QueryOptions( 10, 0 )
83			)
84			);
85			}
86
87			private function setupMongoDb() {
88			$this->importCommand( 'import-json-dump', 'valid.json' );
89			$this->importCommand( 'import-incremental-xml-dump', 'valid-incremental.xml' );
90			}
91
92			private function importCommand( $command, $file ) {
93			$applicationFactory = new CliApplicationFactory();
94			$importCommand = $applicationFactory->newApplication()->find( $command );
95			$input = new ArrayInput( [
96			'command' => $command,
97			'file' => __DIR__ . '/../data/' . $file,
98			'configuration' => __DIR__ . '/../data/valid-config-mongodb.json'
99			] );
100			$importCommand->run( $input, new NullOutput() );
101			}
102
103			private function getEntityStoreFromConfiguration() {
104			$configBuilder = new EntityStoreFromConfigurationBuilder();
105			return $configBuilder->buildEntityStore( __DIR__ . '/../data/valid-config-mongodb.json' );
106			}
107			}
108

ProjetPP / WikibaseEntityStore

Pull Request — master (#18)

MongoDBTest::testMongoDbStore() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like