| Conditions | 1 |
| Paths | 1 |
| Total Lines | 205 |
| Code Lines | 128 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 15 | ||
| Bugs | 0 | Features | 3 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 26 | public function testBuildDocumentForEntity() { |
||
| 27 | $item = new Item( |
||
| 28 | new ItemId( 'Q1' ), |
||
| 29 | new Fingerprint( |
||
| 30 | new TermList( [ new Term( 'en', 'foo ' ) ] ), |
||
| 31 | new TermList( [ new Term( 'en', 'bar' ) ] ), |
||
| 32 | new AliasGroupList( [ new AliasGroup( 'fr', [ 'BAZée', 'bat' ] ) ] ) |
||
| 33 | ) |
||
| 34 | ); |
||
| 35 | |||
| 36 | $entitySerializerMock = $this->getMock( 'Serializers\Serializer' ); |
||
| 37 | $entitySerializerMock->expects( $this->once() ) |
||
| 38 | ->method( 'serialize' ) |
||
| 39 | ->with( $this->equalTo( $item ) ) |
||
| 40 | ->willReturn( [ |
||
| 41 | 'type' => 'item', |
||
| 42 | 'id' => 'Q1', |
||
| 43 | 'labels' => [ |
||
| 44 | 'en' => [ 'language' => 'en', 'value' => 'foo ' ] |
||
| 45 | ], |
||
| 46 | 'descriptions' => [ |
||
| 47 | 'en' => [ 'language' => 'en', 'value' => 'bar' ], |
||
| 48 | ], |
||
| 49 | 'aliases' => [ |
||
| 50 | 'fr' => [ |
||
| 51 | [ 'language' => 'fr', 'value' => 'BAZée' ], |
||
| 52 | [ 'language' => 'fr', 'value' => 'bat' ] |
||
| 53 | ] |
||
| 54 | ], |
||
| 55 | 'claims' => [ |
||
| 56 | 'P1' => [ |
||
| 57 | [ |
||
| 58 | 'mainsnak' => [ |
||
| 59 | 'snaktype' => 'value', |
||
| 60 | 'property' => 'P1', |
||
| 61 | 'datavalue' => [ |
||
| 62 | 'value' => 'foo', |
||
| 63 | 'type' => 'string' |
||
| 64 | ] |
||
| 65 | ] |
||
| 66 | ], |
||
| 67 | [ |
||
| 68 | 'mainsnak' => [ |
||
| 69 | 'snaktype' => 'value', |
||
| 70 | 'property' => 'P1', |
||
| 71 | 'datavalue' => [ |
||
| 72 | 'value' => str_repeat( '0123456789', 20 ), |
||
| 73 | 'type' => 'string' |
||
| 74 | ] |
||
| 75 | ] |
||
| 76 | ], |
||
| 77 | [ |
||
| 78 | 'mainsnak' => [ |
||
| 79 | 'snaktype' => 'value', |
||
| 80 | 'property' => 'P1', |
||
| 81 | 'datavalue' => [ |
||
| 82 | 'value' => [ 'entity-type' => 'item', 'numeric-id' => 1 ], |
||
| 83 | 'type' => 'wikibase-entityid' |
||
| 84 | ] |
||
| 85 | ] |
||
| 86 | ], |
||
| 87 | [ |
||
| 88 | 'mainsnak' => [ |
||
| 89 | 'snaktype' => 'value', |
||
| 90 | 'property' => 'P1', |
||
| 91 | 'datavalue' => [ |
||
| 92 | 'value' => [ 'entity-type' => 'property', 'numeric-id' => 1 ], |
||
| 93 | 'type' => 'wikibase-entityid' |
||
| 94 | ] |
||
| 95 | ] |
||
| 96 | ] |
||
| 97 | ], |
||
| 98 | 'P2' => [ |
||
| 99 | [ |
||
| 100 | 'mainsnak' => [ |
||
| 101 | 'snaktype' => 'value', |
||
| 102 | 'property' => 'P2', |
||
| 103 | 'datavalue' => [ |
||
| 104 | 'value' => [ 'time' => '+00000001952-03-11T00:00:00Z' ], |
||
| 105 | 'type' => 'time' |
||
| 106 | ] |
||
| 107 | ] |
||
| 108 | ], |
||
| 109 | [ |
||
| 110 | 'mainsnak' => [ |
||
| 111 | 'snaktype' => 'value', |
||
| 112 | 'property' => 'P2', |
||
| 113 | 'datavalue' => [ |
||
| 114 | 'value' => [ 'latitude' => 1, 'longitude' => 1 ], |
||
| 115 | 'type' => 'globecoordinate' |
||
| 116 | ] |
||
| 117 | ] |
||
| 118 | ] |
||
| 119 | ] |
||
| 120 | ] |
||
| 121 | ] ); |
||
| 122 | |||
| 123 | $entityDeserializerMock = $this->getMock( 'Deserializers\Deserializer' ); |
||
| 124 | |||
| 125 | $documentBuilder = new MongoDBDocumentBuilder( |
||
| 126 | $entitySerializerMock, |
||
| 127 | $entityDeserializerMock, |
||
| 128 | new BasicEntityIdParser(), |
||
| 129 | new EntityStoreOptions([ EntityStore::OPTION_LANGUAGES => null ] ) |
||
| 130 | ); |
||
| 131 | |||
| 132 | $this->assertEquals( |
||
| 133 | [ |
||
| 134 | '_id' => 'Q1', |
||
| 135 | 'type' => 'item', |
||
| 136 | 'id' => 'Q1', |
||
| 137 | 'labels' => [ |
||
| 138 | 'en' => [ 'language' => 'en', 'value' => 'foo ' ], |
||
| 139 | ], |
||
| 140 | 'descriptions' => [ |
||
| 141 | 'en' => [ 'language' => 'en', 'value' => 'bar' ], |
||
| 142 | ], |
||
| 143 | 'aliases' => [ |
||
| 144 | 'fr' => [ |
||
| 145 | [ 'language' => 'fr', 'value' => 'BAZée' ], |
||
| 146 | [ 'language' => 'fr', 'value' => 'bat' ] |
||
| 147 | ] |
||
| 148 | ], |
||
| 149 | 'claims' => [ |
||
| 150 | 'P1' => [ |
||
| 151 | [ |
||
| 152 | 'mainsnak' => [ |
||
| 153 | 'snaktype' => 'value', |
||
| 154 | 'property' => 'P1', |
||
| 155 | 'datavalue' => [ |
||
| 156 | 'value' => 'foo', |
||
| 157 | 'type' => 'string' |
||
| 158 | ] |
||
| 159 | ] |
||
| 160 | ], |
||
| 161 | [ |
||
| 162 | 'mainsnak' => [ |
||
| 163 | 'snaktype' => 'value', |
||
| 164 | 'property' => 'P1', |
||
| 165 | 'datavalue' => [ |
||
| 166 | 'value' => str_repeat( '0123456789', 20 ), |
||
| 167 | 'type' => 'string' |
||
| 168 | ] |
||
| 169 | ] |
||
| 170 | ], |
||
| 171 | [ |
||
| 172 | 'mainsnak' => [ |
||
| 173 | 'snaktype' => 'value', |
||
| 174 | 'property' => 'P1', |
||
| 175 | 'datavalue' => [ |
||
| 176 | 'value' => [ 'entity-type' => 'item', 'numeric-id' => 1 ], |
||
| 177 | 'type' => 'wikibase-entityid' |
||
| 178 | ] |
||
| 179 | ] |
||
| 180 | ], |
||
| 181 | [ |
||
| 182 | 'mainsnak' => [ |
||
| 183 | 'snaktype' => 'value', |
||
| 184 | 'property' => 'P1', |
||
| 185 | 'datavalue' => [ |
||
| 186 | 'value' => [ 'entity-type' => 'property', 'numeric-id' => 1 ], |
||
| 187 | 'type' => 'wikibase-entityid' |
||
| 188 | ] |
||
| 189 | ] |
||
| 190 | ] |
||
| 191 | ], |
||
| 192 | 'P2' => [ |
||
| 193 | [ |
||
| 194 | 'mainsnak' => [ |
||
| 195 | 'snaktype' => 'value', |
||
| 196 | 'property' => 'P2', |
||
| 197 | 'datavalue' => [ |
||
| 198 | 'value' => [ 'time' => '+00000001952-03-11T00:00:00Z' ], |
||
| 199 | 'type' => 'time' |
||
| 200 | ] |
||
| 201 | ] |
||
| 202 | ], |
||
| 203 | [ |
||
| 204 | 'mainsnak' => [ |
||
| 205 | 'snaktype' => 'value', |
||
| 206 | 'property' => 'P2', |
||
| 207 | 'datavalue' => [ |
||
| 208 | 'value' => [ 'latitude' => 1, 'longitude' => 1 ], |
||
| 209 | 'type' => 'globecoordinate' |
||
| 210 | ] |
||
| 211 | ] |
||
| 212 | ] |
||
| 213 | ] |
||
| 214 | ], |
||
| 215 | 'sterms' => [ |
||
| 216 | 'en' => [ new MongoBinData( md5( 'foo', true ), MongoBinData::GENERIC ) ], |
||
| 217 | 'fr' => [ |
||
| 218 | new MongoBinData( md5( 'bazée', true ), MongoBinData::GENERIC ), |
||
| 219 | new MongoBinData( md5( 'bat', true ), MongoBinData::GENERIC ) |
||
| 220 | ] |
||
| 221 | ], |
||
| 222 | 'sclaims' => [ |
||
| 223 | 'string' => [ 'P1-foo', 'P1-c902a17556796a9f97afa23bad130b04' ], |
||
| 224 | 'wikibase-entityid' => [ 'P1-Q1', 'P1-P1' ], |
||
| 225 | 'time' => [ 'P2-+00000001952-03-11T00:00:00Z' ] |
||
| 226 | ] |
||
| 227 | ], |
||
| 228 | $documentBuilder->buildDocumentForEntity( $item ) |
||
| 229 | ); |
||
| 230 | } |
||
| 231 | |||
| 419 |