StringResourceNodeSerializer - Code Metrics - ProjetPP/PPP-datamodel-PHP - Measure and Improve Code Quality continuously with Scrutinizer

StringResourceNodeSerializer A
last analyzed 2017-11-28 20:07 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	1
dl	0
loc	20
c	0
b	0
f	0
ccs	9
cts	9
cp	1
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	getAdditionalSerialization()	0	9	2

<?php

namespace PPP\DataModel\Serializers;

use PPP\DataModel\ResourceNode;
use PPP\DataModel\StringResourceNode;

/**
 * @licence AGPLv3+
 * @author Thomas Pellissier Tanon
 */
class StringResourceNodeSerializer extends BasicResourceNodeSerializer {

	public function __construct() {
		parent::__construct('string');
	}

	/**
	 * @see AbstractResourceNodeSerializer::getAdditionalSerialization
	 * @param StringResourceNode $node
	 */
	protected function getAdditionalSerialization(ResourceNode $node) {
		$serialization = array();

		if($node->getLanguageCode() !== '') {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
			$serialization['language'] = $node->getLanguageCode();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
		}

		return $serialization;
	}
}


StringResourceNodeSerializer A
last analyzed 2017-11-28 20:07 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Available Fixes

Available Fixes

1		<?php
2
3		namespace PPP\DataModel\Serializers;
4
5		use PPP\DataModel\ResourceNode;
6		use PPP\DataModel\StringResourceNode;
7
8		/**
9		* @licence AGPLv3+
10		* @author Thomas Pellissier Tanon
11		*/
12		class StringResourceNodeSerializer extends BasicResourceNodeSerializer {
13
14	10	public function __construct() {
15	10	parent::__construct('string');
16	10	}
17
18		/**
19		* @see AbstractResourceNodeSerializer::getAdditionalSerialization
20		* @param StringResourceNode $node
21		*/
22	2	protected function getAdditionalSerialization(ResourceNode $node) {
23	2	$serialization = array();
24
25	2	if($node->getLanguageCode() !== '') {
		0 ignored issues – show Bug introduced 2015-12-08 13:19 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `PPP\DataModel\ResourceNode` as the method `getLanguageCode()` does only exist in the following sub-classes of `PPP\DataModel\ResourceNode`: `PPP\DataModel\StringResourceNode`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
26	1	$serialization['language'] = $node->getLanguageCode();
		0 ignored issues – show Bug introduced 2015-12-08 13:19 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `PPP\DataModel\ResourceNode` as the method `getLanguageCode()` does only exist in the following sub-classes of `PPP\DataModel\ResourceNode`: `PPP\DataModel\StringResourceNode`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
27	1	}
28
29	2	return $serialization;
30		}
31		}
32

ProjetPP / PPP-datamodel-PHP

StringResourceNodeSerializer A last analyzed 2017-11-28 20:07 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

StringResourceNodeSerializer A
last analyzed 2017-11-28 20:07 UTC