Issues in MissingObjectTripleNodeSimplifier.php (master) - Issues in master - ProjetPP/PPP-Wikidata - Measure and Improve Code Quality continuously with Scrutinizer

Issues (43)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

MissingObjectTripleNodeSimplifier.php (5 issues)

Labels

Severity

Minor 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace PPP\Wikidata\TreeSimplifier;

use InvalidArgumentException;
use PPP\DataModel\AbstractNode;
use PPP\DataModel\MissingNode;
use PPP\DataModel\ResourceListNode;
use PPP\DataModel\TripleNode;
use PPP\Module\TreeSimplifier\NodeSimplifier;
use PPP\Wikidata\ValueParsers\ResourceListNodeParser;
use PPP\Wikidata\WikibaseResourceNode;

/**
 * Simplifies a triple node when the object is missing.
 *
 * @licence AGPLv3+
 * @author Thomas Pellissier Tanon
 */
class MissingObjectTripleNodeSimplifier implements NodeSimplifier {

	/**
	 * @var ResourceListNodeParser
	 */
	private $resourceListNodeParser;

	/**
	 * @var ResourceListForEntityProperty
	 */
	private $resourceListForEntityProperty;

	/**
	 * @param ResourceListNodeParser $resourceListNodeParser
	 * @param ResourceListForEntityProperty $resourceListForEntityProperty
	 */
	public function __construct(ResourceListNodeParser $resourceListNodeParser, ResourceListForEntityProperty $resourceListForEntityProperty) {
		$this->resourceListNodeParser = $resourceListNodeParser;
		$this->resourceListForEntityProperty = $resourceListForEntityProperty;
	}

	/**
	 * @see NodeSimplifier::isSimplifierFor
	 */
	public function isSimplifierFor(AbstractNode $node) {
		return $node instanceof TripleNode &&
			$node->getSubject() instanceof ResourceListNode &&
			$node->getPredicate() instanceof ResourceListNode &&
			$node->getObject() instanceof MissingNode;
	}

	/**
	 * @see NodeSimplifier::doSimplification
	 */
	public function simplify(AbstractNode $node) {
		if(!$this->isSimplifierFor($node)) {
			throw new InvalidArgumentException('MissingObjectTripleNodeSimplifier can only simplify TripleNode with a missing object');
		}

		return $this->doSimplification($node);

	}

	private function doSimplification(TripleNode $node) {
		$subjectNodes = $this->resourceListNodeParser->parse($node->getSubject(), 'wikibase-item');

		$propertyNodes = $this->resourceListNodeParser->parse($node->getPredicate(), 'wikibase-property');

		$results = array();

		foreach($subjectNodes as $subject) {
			foreach($propertyNodes as $predicate) {
				$results[] = $this->getNodesForObject($subject, $predicate);
			}
		}

		$node = new ResourceListNode($results);
		return $node;
	}

	protected function getNodesForObject(WikibaseResourceNode $subject, WikibaseResourceNode $predicate) {
		return $this->resourceListForEntityProperty->getForEntityProperty(
			$subject->getDataValue()->getEntityId(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
			$predicate->getDataValue()->getEntityId()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
		);
	}
}


1		<?php
2
3		namespace PPP\Wikidata\TreeSimplifier;
4
5		use InvalidArgumentException;
6		use PPP\DataModel\AbstractNode;
7		use PPP\DataModel\MissingNode;
8		use PPP\DataModel\ResourceListNode;
9		use PPP\DataModel\TripleNode;
10		use PPP\Module\TreeSimplifier\NodeSimplifier;
11		use PPP\Wikidata\ValueParsers\ResourceListNodeParser;
12		use PPP\Wikidata\WikibaseResourceNode;
13
14		/**
15		* Simplifies a triple node when the object is missing.
16		*
17		* @licence AGPLv3+
18		* @author Thomas Pellissier Tanon
19		*/
20		class MissingObjectTripleNodeSimplifier implements NodeSimplifier {
21
22		/**
23		* @var ResourceListNodeParser
24		*/
25		private $resourceListNodeParser;
26
27		/**
28		* @var ResourceListForEntityProperty
29		*/
30		private $resourceListForEntityProperty;
31
32		/**
33		* @param ResourceListNodeParser $resourceListNodeParser
34		* @param ResourceListForEntityProperty $resourceListForEntityProperty
35		*/
36	13	public function __construct(ResourceListNodeParser $resourceListNodeParser, ResourceListForEntityProperty $resourceListForEntityProperty) {
37	13	$this->resourceListNodeParser = $resourceListNodeParser;
38	13	$this->resourceListForEntityProperty = $resourceListForEntityProperty;
39	13	}
40
41		/**
42		* @see NodeSimplifier::isSimplifierFor
43		*/
44	12	public function isSimplifierFor(AbstractNode $node) {
45	12	return $node instanceof TripleNode &&
46	12	$node->getSubject() instanceof ResourceListNode &&
47	12	$node->getPredicate() instanceof ResourceListNode &&
48	12	$node->getObject() instanceof MissingNode;
49		}
50
51		/**
52		* @see NodeSimplifier::doSimplification
53		*/
54	7	public function simplify(AbstractNode $node) {
55	7	if(!$this->isSimplifierFor($node)) {
56	3	throw new InvalidArgumentException('MissingObjectTripleNodeSimplifier can only simplify TripleNode with a missing object');
57		}
58
59	4	return $this->doSimplification($node);
		0 ignored issues – show Compatibility introduced 2016-01-11 15:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$node` of type `object<PPP\DataModel\AbstractNode>` is not a sub-type of `object<PPP\DataModel\TripleNode>`. It seems like you assume a child class of the class `PPP\DataModel\AbstractNode` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
60		}
61
62	4	private function doSimplification(TripleNode $node) {
63	4	$subjectNodes = $this->resourceListNodeParser->parse($node->getSubject(), 'wikibase-item');
		0 ignored issues – show Compatibility introduced 2016-01-11 15:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$node->getSubject()` of type `object<PPP\DataModel\AbstractNode>` is not a sub-type of `object<PPP\DataModel\ResourceListNode>`. It seems like you assume a child class of the class `PPP\DataModel\AbstractNode` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
64	4	$propertyNodes = $this->resourceListNodeParser->parse($node->getPredicate(), 'wikibase-property');
		0 ignored issues – show Compatibility introduced 2016-01-11 15:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$node->getPredicate()` of type `object<PPP\DataModel\AbstractNode>` is not a sub-type of `object<PPP\DataModel\ResourceListNode>`. It seems like you assume a child class of the class `PPP\DataModel\AbstractNode` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
65	4	$results = array();
66
67	4	foreach($subjectNodes as $subject) {
68	4	foreach($propertyNodes as $predicate) {
69	4	$results[] = $this->getNodesForObject($subject, $predicate);
70	4	}
71	4	}
72
73	4	$node = new ResourceListNode($results);
74	4	return $node;
75		}
76
77	4	protected function getNodesForObject(WikibaseResourceNode $subject, WikibaseResourceNode $predicate) {
78	4	return $this->resourceListForEntityProperty->getForEntityProperty(
79	4	$subject->getDataValue()->getEntityId(),
		0 ignored issues – show Bug introduced 2016-01-11 15:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `DataValues\DataValue` as the method `getEntityId()` does only exist in the following implementations of said interface: `Wikibase\DataModel\Entity\EntityIdValue`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
80	4	$predicate->getDataValue()->getEntityId()
		0 ignored issues – show Bug introduced 2016-01-11 15:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `DataValues\DataValue` as the method `getEntityId()` does only exist in the following implementations of said interface: `Wikibase\DataModel\Entity\EntityIdValue`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
81	4	);
82		}
83		}
84

ProjetPP / PPP-Wikidata

Issues (43)

Security Analysis no request data

MissingObjectTripleNodeSimplifier.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like