RecursiveSortNodeSimplifier::simplify() - Code Metrics - ProjetPP/PPP-LibModule-PHP - Measure and Improve Code Quality continuously with Scrutinizer

RecursiveSortNodeSimplifier::simplify() A
last analyzed 2016-03-10 13:37 UTC

↳ Parent: RecursiveSortNodeSimplifier

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	10
ccs	7
cts	7
cp	1
rs	9.4285
cc	2
eloc	6
nc	2
nop	1
crap	2

<?php

namespace PPP\Module\TreeSimplifier;

use InvalidArgumentException;
use PPP\DataModel\AbstractNode;
use PPP\DataModel\SortNode;

class RecursiveSortNodeSimplifier implements NodeSimplifier {

	/**
	 * @var NodeSimplifierFactory
	 */
	private $simplifierFactory;

	/**
	 * @param NodeSimplifierFactory $simplifierFactory
	 */
	public function __construct(NodeSimplifierFactory $simplifierFactory) {
		$this->simplifierFactory = $simplifierFactory;
	}

	/**
	 * @see NodeSimplifier::isSimplifierFor
	 */
	public function isSimplifierFor(AbstractNode $node) {
		return $node instanceof SortNode;
	}

	/**
	 * @see NodeSimplifier::simplify
	 * @param SortNode $node
	 */
	public function simplify(AbstractNode $node) {
		if(!$this->isSimplifierFor($node)) {
			throw new InvalidArgumentException('RecursiveSortSimplifier can only simplify SortNode');
		}

		return new SortNode(
			$this->simplifierFactory->newNodeSimplifier()->simplify($node->getOperand()),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
			$node->getPredicate()
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
		);
	}
}


RecursiveSortNodeSimplifier::simplify() A
last analyzed 2016-03-10 13:37 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

1		<?php
2
3		namespace PPP\Module\TreeSimplifier;
4
5		use InvalidArgumentException;
6		use PPP\DataModel\AbstractNode;
7		use PPP\DataModel\SortNode;
8
9		class RecursiveSortNodeSimplifier implements NodeSimplifier {
10
11		/**
12		* @var NodeSimplifierFactory
13		*/
14		private $simplifierFactory;
15
16		/**
17		* @param NodeSimplifierFactory $simplifierFactory
18		*/
19	5	public function __construct(NodeSimplifierFactory $simplifierFactory) {
20	5	$this->simplifierFactory = $simplifierFactory;
21	5	}
22
23		/**
24		* @see NodeSimplifier::isSimplifierFor
25		*/
26	4	public function isSimplifierFor(AbstractNode $node) {
27	4	return $node instanceof SortNode;
28		}
29
30		/**
31		* @see NodeSimplifier::simplify
32		* @param SortNode $node
33		*/
34	2	public function simplify(AbstractNode $node) {
35	2	if(!$this->isSimplifierFor($node)) {
36	1	throw new InvalidArgumentException('RecursiveSortSimplifier can only simplify SortNode');
37		}
38
39	1	return new SortNode(
40	1	$this->simplifierFactory->newNodeSimplifier()->simplify($node->getOperand()),
		0 ignored issues – show Bug introduced 2015-12-08 13:20 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `PPP\DataModel\AbstractNode` as the method `getOperand()` does only exist in the following sub-classes of `PPP\DataModel\AbstractNode`: `PPP\DataModel\FirstNode`, `PPP\DataModel\LastNode`, `PPP\DataModel\ReducerNode`, `PPP\DataModel\SortNode`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
41	1	$node->getPredicate()
		0 ignored issues – show Bug introduced 2015-12-08 13:20 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `PPP\DataModel\AbstractNode` as the method `getPredicate()` does only exist in the following sub-classes of `PPP\DataModel\AbstractNode`: `PPP\DataModel\SortNode`, `PPP\DataModel\TripleNode`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
42	1	);
43		}
44		}
45

ProjetPP / PPP-LibModule-PHP

RecursiveSortNodeSimplifier::simplify() A last analyzed 2016-03-10 13:37 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

RecursiveSortNodeSimplifier::simplify() A
last analyzed 2016-03-10 13:37 UTC