projectcleverweb\color\modify

Complexity

Total Complexity

8

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	2

5 Methods

Rating	Name	Duplication	Size	Complexity
A	rgb()	0	8	1
A	hsl()	0	12	2
A	_convert_to_exact()	0	6	2
A	_convert_to_abs()	0	6	2
A	regenerate_rgb()	0	7	1

<?php


namespace projectcleverweb\color;

class modify {
	
	public static function rgb(data $data, string $scope, float $adjustment, bool $as_percentage, bool $set_absolute) {
		$current         = array_combine(['red', 'green', 'blue'], $data->rgb);

The property rgb cannot be accessed from this context as it is declared private in class projectcleverweb\color\data.

		$scope           = strtolower($scope); // [todo] Validate scope

Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker.

		$adjustment      = max(min($adjustment, 255), 0 - 255); // Force valid range
		$adjustment      = static::_convert_to_exact($adjustment, 255, $as_percentage);
		$current[$scope] = static::_convert_to_abs($current[$scope], $adjustment, $set_absolute, 0, 255);
		return static::regenerate_rgb($data, $current);
	}
	
	public static function hsl(data $data, string $scope, float $adjustment, bool $as_percentage, bool $set_absolute) {

The return type could not be reliably inferred; please add a @return annotation.

		$current = array_combine(['hue', 'saturation', 'light'], $data->hsl->hsl);

The property hsl cannot be accessed from this context as it is declared private in class projectcleverweb\color\data.

The property hsl cannot be accessed from this context as it is declared private in class projectcleverweb\color\hsl.

		$scope   = strtolower($scope); // [todo] Validate scope

Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker.

		$max     = 100;
		if ($scope == 'hue') {
			$max = 359;
		}
		$adjustment = max(min($adjustment, $max), 0 - $max); // Force valid range

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

		$adjustment = static::_convert_to_exact($adjustment, $max, $as_percentage);

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

		$current[$scope] = static::_convert_to_abs($current[$scope], $adjustment, $set_absolute, 0, $max);
		return static::regenerate_hsl($data, $current);

The method regenerate_hsl() does not seem to exist on object<projectcleverweb\color\modify>.

	}
	
	protected static function _convert_to_exact(float $adjustment, float $max, bool $as_percentage) {
		if ($as_percentage) {
			return ($adjustment / 100) * abs($max);
		}
		return $adjustment;
	}
	
	protected static function _convert_to_abs(float $current, float $adjustment, bool $set_absolute, float $min = 0, float $max = PHP_INT_MAX) {
		if ($set_absolute) {
			return abs($adjustment);
		}
		return max(min($current + $adjustment, $max), $min);
	}
	
	protected static function regenerate_rgb(data $data, array $update) {
		$data->import_rgb([
			'r' => $update['red'],
			'g' => $update['green'],
			'b' => $update['blue']
		]);
	}
}