SimpleSlidePresenter::getDisplayValues() - Code Metrics - Inspection of "Finish up image addition" - ProfessionalWiki/ModernTimeline - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 21291c...2ce44d )

by Jeroen De

created 2020-03-29 13:18 UTC

SimpleSlidePresenter::getDisplayValues() A

↳ Parent: SimpleSlidePresenter

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	6
cts	6
cp	1
rs	9.9666
c	0
b	0
f	0
cc	4
nc	4
nop	1
crap	4

<?php

declare( strict_types = 1 );

namespace ModernTimeline\SlidePresenter;

use ModernTimeline\ResultFacade\Subject;
use SMW\DataValueFactory;
use SMW\Query\PrintRequest;

class SimpleSlidePresenter implements SlidePresenter {

	private $parameters;

	public function __construct( array $parameters ) {
		$this->parameters = $parameters;
	}

	public function getText( Subject $subject ): string {
		return implode( '<br>', iterator_to_array( $this->getDisplayValues( $subject ) ) );
	}

	private function getDisplayValues( Subject $subject ) {
		foreach ( $subject->getPropertyValueCollections() as $propertyValues ) {
			foreach ( $propertyValues->getDataItems() as $dataItem ) {
				if ( !$this->isHiddenPrintRequest( $propertyValues->getPrintRequest() ) ) {
					yield $this->getDisplayValue( $propertyValues->getPrintRequest(), $dataItem );
				}
			}
		}
	}

	private function isHiddenPrintRequest( PrintRequest $pr ) {
		return $pr->getText( null ) === $this->parameters['image property'];
	}

	private function getDisplayValue( PrintRequest $pr, \SMWDataItem $dataItem ) {
		$property = $pr->getText( null );
		$value = $this->dataItemToText( $dataItem );

		if ( $property === '' ) {
			return $value;
		}

		return $property . ': ' . $value;
	}

	private function dataItemToText( \SMWDataItem $dataItem ): string {
		return DataValueFactory::getInstance()->newDataValueByItem( $dataItem )->getLongHTMLText();
	}

}


1		<?php
2
3		declare( strict_types = 1 );
4
5		namespace ModernTimeline\SlidePresenter;
6
7		use ModernTimeline\ResultFacade\Subject;
8		use SMW\DataValueFactory;
9		use SMW\Query\PrintRequest;
10
11		class SimpleSlidePresenter implements SlidePresenter {
12
13	2	private $parameters;
14	2
15		public function __construct( array $parameters ) {
16		$this->parameters = $parameters;
17	2	}
18	2
19	2	public function getText( Subject $subject ): string {
20	2	return implode( '<br>', iterator_to_array( $this->getDisplayValues( $subject ) ) );
21		}
22
23	2	private function getDisplayValues( Subject $subject ) {
24		foreach ( $subject->getPropertyValueCollections() as $propertyValues ) {
25	2	foreach ( $propertyValues->getDataItems() as $dataItem ) {
26	2	if ( !$this->isHiddenPrintRequest( $propertyValues->getPrintRequest() ) ) {
27	2	yield $this->getDisplayValue( $propertyValues->getPrintRequest(), $dataItem );
28		}
29	2	}
30	2	}
31		}
32
33	2	private function isHiddenPrintRequest( PrintRequest $pr ) {
34		return $pr->getText( null ) === $this->parameters['image property'];
35		}
36	2
37	2	private function getDisplayValue( PrintRequest $pr, \SMWDataItem $dataItem ) {
38		$property = $pr->getText( null );
39		$value = $this->dataItemToText( $dataItem );
40
41		if ( $property === '' ) {
42		return $value;
43		}
44
45		return $property . ': ' . $value;
46		}
47
48		private function dataItemToText( \SMWDataItem $dataItem ): string {
49		return DataValueFactory::getInstance()->newDataValueByItem( $dataItem )->getLongHTMLText();
50		}
51
52		}
53

ProfessionalWiki / ModernTimeline

Push — master ( 21291c...2ce44d )

SimpleSlidePresenter::getDisplayValues() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like