SmallerThanOrEquals::isValid() - Code Metrics - Inspection of "Improve boolean handling in PropertyValidator" - PrinsFrank/php-validated-properties - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — main (#3)

by Viktor

created 2022-07-07 10:21 UTC

SmallerThanOrEquals::isValid() A

↳ Parent: SmallerThanOrEquals

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	5
c	2
b	0
f	0
dl	0
loc	11
ccs	6
cts	6
cp	1
rs	10
cc	3
nc	3
nop	1
crap	3

<?php
declare(strict_types=1);

namespace PrinsFrank\PhpStrictModels\Rule;

use Attribute;
use PrinsFrank\PhpStrictModels\Enum\Type;

#[Attribute]
class SmallerThanOrEquals implements Rule
{
    public function __construct(private float|int $smallerThanOrEquals){}

    public function applicableToTypes(): array
    {
        return [Type::float, Type::int, Type::array, Type::string];
    }

    /**
     * @param int|float|string|mixed[] $value
     */
    public function isValid(mixed $value): bool
    {
        if (is_array($value)) {
            return count($value) <= $this->smallerThanOrEquals;
        }

        if (is_string($value)) {
            return mb_strlen($value) <= $this->smallerThanOrEquals;
        }

        return $value <= $this->smallerThanOrEquals;
    }

    public function getMessage(): string
    {
        return 'Should be smaller than or equal to ' . $this->smallerThanOrEquals;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace PrinsFrank\PhpStrictModels\Rule;
5
6		use Attribute;
7		use PrinsFrank\PhpStrictModels\Enum\Type;
8
9		#[Attribute]
10		class SmallerThanOrEquals implements Rule
11		{
12	1	public function __construct(private float\|int $smallerThanOrEquals){}
13
14	1	public function applicableToTypes(): array
15		{
16	1	return [Type::float, Type::int, Type::array, Type::string];
17		}
18
19		/**
20		* @param int\|float\|string\|mixed[] $value
21		*/
22	1	public function isValid(mixed $value): bool
23		{
24	1	if (is_array($value)) {
25	1	return count($value) <= $this->smallerThanOrEquals;
26		}
27
28	1	if (is_string($value)) {
29	1	return mb_strlen($value) <= $this->smallerThanOrEquals;
30		}
31
32	1	return $value <= $this->smallerThanOrEquals;
33		}
34
35	1	public function getMessage(): string
36		{
37	1	return 'Should be smaller than or equal to ' . $this->smallerThanOrEquals;
38		}
39		}
40

PrinsFrank / php-validated-properties

Pull Request — main (#3)

SmallerThanOrEquals::isValid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like