Between::isValid() - Code Metrics - Inspection of "Improve boolean handling in PropertyValidator" - PrinsFrank/php-validated-properties - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — main (#3)

by Viktor

created 2022-07-07 10:21 UTC

Between::isValid() A

↳ Parent: Between

Complexity

Conditions	6
Paths	6

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	7
c	1
b	0
f	0
dl	0
loc	15
ccs	8
cts	8
cp	1
rs	9.2222
cc	6
nc	6
nop	1
crap	6

<?php
declare(strict_types=1);

namespace PrinsFrank\PhpStrictModels\Rule;

use Attribute;
use PrinsFrank\PhpStrictModels\Enum\Type;

#[Attribute]
class Between implements Rule
{
    public function __construct(private float|int $largerThanOrEquals, private float|int $smallerThanOrEquals){}

    public function applicableToTypes(): array
    {
        return [Type::float, Type::int, Type::array, Type::string];
    }

    /**
     * @param int|float|string|mixed[] $value
     */
    public function isValid(mixed $value): bool
    {
        if (is_array($value)) {
            $nrOfItemsInArray = count($value);

            return $nrOfItemsInArray >= $this->largerThanOrEquals && $nrOfItemsInArray <= $this->smallerThanOrEquals;
        }

        if (is_string($value)) {
            $nrOfCharacters = mb_strlen($value);

            return $nrOfCharacters >= $this->largerThanOrEquals && $nrOfCharacters <= $this->smallerThanOrEquals;
        }

        return $value >= $this->largerThanOrEquals && $value <= $this->smallerThanOrEquals;
    }

    public function getMessage(): string
    {
        return 'Should be between ' . $this->largerThanOrEquals . ' and ' . $this->smallerThanOrEquals . '';
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace PrinsFrank\PhpStrictModels\Rule;
5
6		use Attribute;
7		use PrinsFrank\PhpStrictModels\Enum\Type;
8
9		#[Attribute]
10		class Between implements Rule
11		{
12	1	public function __construct(private float\|int $largerThanOrEquals, private float\|int $smallerThanOrEquals){}
13
14	1	public function applicableToTypes(): array
15		{
16	1	return [Type::float, Type::int, Type::array, Type::string];
17		}
18
19		/**
20		* @param int\|float\|string\|mixed[] $value
21		*/
22	1	public function isValid(mixed $value): bool
23		{
24	1	if (is_array($value)) {
25	1	$nrOfItemsInArray = count($value);
26
27	1	return $nrOfItemsInArray >= $this->largerThanOrEquals && $nrOfItemsInArray <= $this->smallerThanOrEquals;
28		}
29
30	1	if (is_string($value)) {
31	1	$nrOfCharacters = mb_strlen($value);
32
33	1	return $nrOfCharacters >= $this->largerThanOrEquals && $nrOfCharacters <= $this->smallerThanOrEquals;
34		}
35
36	1	return $value >= $this->largerThanOrEquals && $value <= $this->smallerThanOrEquals;
37		}
38
39	1	public function getMessage(): string
40		{
41	1	return 'Should be between ' . $this->largerThanOrEquals . ' and ' . $this->smallerThanOrEquals . '';
42		}
43		}
44

PrinsFrank / php-validated-properties

Pull Request — main (#3)

Between::isValid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like