PragmaBroadvertising / laravel-solaredge-api

src/Models/SolarEdgeClient.php

<?php
/**
 * Created by PhpStorm.
 * User: evert
 * Date: 27/09/2017
 * Time: 09:38
 */

namespace PragmaBroadvertising\SolarEdge\Models;

use Ixudra\Curl\Facades\Curl;
use PragmaBroadvertising\SolarEdge\Interfaces\ApiConnectorInterface;

class SolarEdgeClient implements ApiConnectorInterface
{
    public function __construct()
    {
        $this->key = '?api_key=' . env('SOLAREDGE_API_KEY','');

The property key does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->id = env('SOLAREDGE_INSTALLATION_ID','');

The property id does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->endpoint = env('SOLAREDGE_ENDPOINT','https://monitoringapi.solaredge.com/');

The property endpoint does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Get from Site
     * - endpoint
     * - id
     * - key
     * @param $siteProperty
     * @return mixed
     */
    function getFromSite($siteProperty){

It is generally recommended to explicitly declare the visibility for methods.

        $request = Curl::to($this->endpoint . 'site/' . $this->id . '/' . $siteProperty . $this->key)->asJson()->get()->{$siteProperty};
        return $request;
    }

    /**
     * Get from Site with start- and end date
     * - endpoint
     * - id
     * - key
     * - timeUnit
     * - startDate
     * - endDate
     * - withTime
     * @param $siteProperty
     * @return mixed
     */
    function getFromSiteWithStartAndEnd($siteProperty,$timeUnit,$startDate,$endDate,$withTime = false){

It is generally recommended to explicitly declare the visibility for methods.

        if(!$withTime) {
            $request =
                Curl::to($this->endpoint . 'site/' . $this->id . '/' . $siteProperty .
                    $this->key .
                    '&startDate=' . $startDate .
                    '&endDate=' . $endDate .
                    '&timeUnit=' . $timeUnit
                )->asJson()->get()->{$siteProperty};
        }
        else {
            $request =
                Curl::to($this->endpoint . 'site/' . $this->id . '/' . $siteProperty .
                    $this->key .
                    '&startTime=' . $startDate .
                    '&endTime=' . $endDate
                )->asJson()->get()->{$siteProperty};
        }

        return $request;
    }
}